)]}'
{"nodepool/zk/zookeeper.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"e410dcedcd99b887c6d2c936d97920f5fcf87a33","unresolved":true,"context_lines":[{"line_number":742,"context_line":"        self._cached_objects \u003d {}"},{"line_number":743,"context_line":"        self._cached_paths \u003d set()"},{"line_number":744,"context_line":"        self._ready \u003d False"},{"line_number":745,"context_line":"        self._stopped \u003d False"},{"line_number":746,"context_line":"        self._queue \u003d queue.Queue()"},{"line_number":747,"context_line":"        self._background_thread \u003d threading.Thread("},{"line_number":748,"context_line":"            target\u003dself._backgroundWorker)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0eb44aff_08db1310","line":745,"updated":"2023-05-02 22:03:58.000000000","message":"Would it be possible to use a status enum in order to prevent _ready and _stopped to be True at the same time?","commit_id":"0cab9ea5fb88ec234231f337e8b1455093b449f2"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f80b7ff8c0f20a4af2a2f1b19ed6705d507e3be0","unresolved":true,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def _sessionListener(self, state):"},{"line_number":765,"context_line":"        if state \u003d\u003d KazooState.LOST:"},{"line_number":766,"context_line":"            self._ready \u003d False"},{"line_number":767,"context_line":"        elif state \u003d\u003d KazooState.CONNECTED and not self._stopped:"},{"line_number":768,"context_line":"            self._ready \u003d False"},{"line_number":769,"context_line":"            self.zk.kazoo_client.handler.short_spawn(self._start)"}],"source_content_type":"text/x-python","patch_set":3,"id":"278a9fa8_a5d5b080","line":766,"updated":"2023-05-02 22:08:24.000000000","message":"To make this simpler, the LOST check can be removed and _ready could be set to False when entering _sessionListener?","commit_id":"c4c7052f10c41f4919c9a8c0a1ab9c78aeebc72b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"6a244a6343d722e4e57102815fa7dc1dabd62c77","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def _sessionListener(self, state):"},{"line_number":765,"context_line":"        if state \u003d\u003d KazooState.LOST:"},{"line_number":766,"context_line":"            self._ready \u003d False"},{"line_number":767,"context_line":"        elif state \u003d\u003d KazooState.CONNECTED and not self._stopped:"},{"line_number":768,"context_line":"            self._ready \u003d False"},{"line_number":769,"context_line":"            self.zk.kazoo_client.handler.short_spawn(self._start)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7eacff04_8dc9d991","line":766,"in_reply_to":"278a9fa8_a5d5b080","updated":"2023-05-02 22:13:21.000000000","message":"That\u0027s an option.  The current code would consider the cache to continue to be ready during the \"suspended\" time period, and only transition to \"not ready\" after the timeout.\n\nI don\u0027t have a strong opinion on which we should use.  I think either is appropriate for a \"cache\".","commit_id":"c4c7052f10c41f4919c9a8c0a1ab9c78aeebc72b"}]}