)]}'
{"nodepool/driver/statemachine.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7f6eaa9b07841b0e4919df404268ad2781311cd9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return keys"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# TODO is StatsReporter subclass appropriate now after stats client refactor?"},{"line_number":62,"context_line":"class StateMachineNodeLauncher(stats.StatsReporter):"},{"line_number":63,"context_line":"    \"\"\"The state of the state machine."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4afa7401_d94eeec4","line":61,"updated":"2023-05-03 16:51:03.000000000","message":"I think this change is mixing two ideas; the original StatsReporter was basically a mix-in that added functionality (specifically it added an implementation to report launch stats), and the new StatsReporter is a proxy that masks the presence or absence of a statsd object.\n\nTBH, as we move everything to the statemachine driver, I think the original mix-in class will become less valuable.  But perhaps for now, it would be easiest to keep them separate and make the nex proxy object a new class and leave StatsReporter alone?","commit_id":"bd2fb9ec1a006a698410ee08f190a61a396f69c8"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1fa09a55427af9af1dce722f429c7dcbdd1989b5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return keys"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# TODO is StatsReporter subclass appropriate now after stats client refactor?"},{"line_number":62,"context_line":"class StateMachineNodeLauncher(stats.StatsReporter):"},{"line_number":63,"context_line":"    \"\"\"The state of the state machine."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"631cc341_6237d79b","line":61,"in_reply_to":"4afa7401_d94eeec4","updated":"2023-05-03 16:51:58.000000000","message":"s/nex/new/","commit_id":"bd2fb9ec1a006a698410ee08f190a61a396f69c8"}]}