)]}'
{"nodepool/driver/static/provider.py":[{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"acbcbbbbd78902834917f0b08ae0b98935a17f5d","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # This can be very chatty, so we don\u0027t normally log it.  It"},{"line_number":192,"context_line":"        # can be helpful when debugging tests."},{"line_number":193,"context_line":"        self._debugSlots(node_slots, unslotted_nodes)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Find all nodes without slot ids, store each in first available slot"},{"line_number":196,"context_line":"        for node in unslotted_nodes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7561adb_47912962","line":193,"updated":"2023-06-02 13:45:02.000000000","message":"Should this be enabled by default?","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"38cee2c61111bf072247dcffb8068a4e700ad1d2","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        # This can be very chatty, so we don\u0027t normally log it.  It"},{"line_number":192,"context_line":"        # can be helpful when debugging tests."},{"line_number":193,"context_line":"        self._debugSlots(node_slots, unslotted_nodes)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # Find all nodes without slot ids, store each in first available slot"},{"line_number":196,"context_line":"        for node in unslotted_nodes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3153d2fc_2d1d60e0","line":193,"in_reply_to":"d7561adb_47912962","updated":"2023-06-26 22:32:52.000000000","message":"Nope, leftover after debugging, thanks for catching that.  :)","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"acbcbbbbd78902834917f0b08ae0b98935a17f5d","unresolved":true,"context_lines":[{"line_number":502,"context_line":"            try:"},{"line_number":503,"context_line":"                existing_node_slots.index(node)"},{"line_number":504,"context_line":"                # If we found an existing node slot, that\u0027s"},{"line_number":505,"context_line":"                # unexpected, we should let resync fix anything."},{"line_number":506,"context_line":"                return"},{"line_number":507,"context_line":"            except ValueError:"},{"line_number":508,"context_line":"                # The expected case is that the slot is occupied by"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7750c4_92f3d3a5","line":505,"updated":"2023-06-02 13:45:02.000000000","message":"Should we log some kind of warning here?","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"38cee2c61111bf072247dcffb8068a4e700ad1d2","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            try:"},{"line_number":503,"context_line":"                existing_node_slots.index(node)"},{"line_number":504,"context_line":"                # If we found an existing node slot, that\u0027s"},{"line_number":505,"context_line":"                # unexpected, we should let resync fix anything."},{"line_number":506,"context_line":"                return"},{"line_number":507,"context_line":"            except ValueError:"},{"line_number":508,"context_line":"                # The expected case is that the slot is occupied by"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc954a31_0121a104","line":505,"in_reply_to":"1a7750c4_92f3d3a5","updated":"2023-06-26 22:32:52.000000000","message":"Okay, but how about just at debug level, since we expect the resync handler to correct any inconsistencies.","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"},{"author":{"_account_id":27582,"name":"Simon Westphahl","email":"simon.westphahl@bmw.de","username":"simon.westphahl"},"change_message_id":"acbcbbbbd78902834917f0b08ae0b98935a17f5d","unresolved":true,"context_lines":[{"line_number":512,"context_line":"            try:"},{"line_number":513,"context_line":"                existing_node \u003d existing_node_slots[node.slot]"},{"line_number":514,"context_line":"                if existing_node is not None:"},{"line_number":515,"context_line":"                    # The current slot entry should be None."},{"line_number":516,"context_line":"                    return"},{"line_number":517,"context_line":"            except IndexError:"},{"line_number":518,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"d20a33ae_8fc9dffd","line":515,"updated":"2023-06-02 13:45:02.000000000","message":"Should we also log something here?","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"38cee2c61111bf072247dcffb8068a4e700ad1d2","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            try:"},{"line_number":513,"context_line":"                existing_node \u003d existing_node_slots[node.slot]"},{"line_number":514,"context_line":"                if existing_node is not None:"},{"line_number":515,"context_line":"                    # The current slot entry should be None."},{"line_number":516,"context_line":"                    return"},{"line_number":517,"context_line":"            except IndexError:"},{"line_number":518,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6da394f_f1acb816","line":515,"in_reply_to":"d20a33ae_8fc9dffd","updated":"2023-06-26 22:32:52.000000000","message":"Ditto.","commit_id":"ffe05578efbbc70156d7504d86a400bf91d9ac0c"}]}