)]}'
{"nodepool/tests/unit/test_zk.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f05ef5791ab998232057947533e231cd2c84b70d","unresolved":true,"context_lines":[{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"        for test in test_paths:"},{"line_number":1367,"context_line":"            res \u003d my_zk._image_cache.parsePath(test[\u0027path\u0027])"},{"line_number":1368,"context_line":"            if test[\u0027result\u0027] and test[\u0027kind\u0027] !\u003d \u0027image pause\u0027:"},{"line_number":1369,"context_line":"                self.assertEqual(test[\u0027result\u0027], res)"},{"line_number":1370,"context_line":"            else:"},{"line_number":1371,"context_line":"                self.assertIsNone(res)"}],"source_content_type":"text/x-python","patch_set":2,"id":"673acdbc_2ef46af7","line":1368,"range":{"start_line":1368,"start_character":50,"end_line":1368,"end_character":63},"updated":"2023-06-02 18:11:46.000000000","message":"The image pause case has a result of `(\u0027NAME\u0027,)` which means that we\u0027ll try to assert None below which doesn\u0027t match the result value above. To avoid confusion should we set the result to `None` instead?\n\nI guess the issue below is that we are calling two different parsing methods and expect different results. Maybe worth a comment at least?","commit_id":"a21245d5952bfc0f18332dac95ce1559e9b811db"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"14c59cbc378135389d58195f5a1e182637ea40a2","unresolved":false,"context_lines":[{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"        for test in test_paths:"},{"line_number":1367,"context_line":"            res \u003d my_zk._image_cache.parsePath(test[\u0027path\u0027])"},{"line_number":1368,"context_line":"            if test[\u0027result\u0027] and test[\u0027kind\u0027] !\u003d \u0027image pause\u0027:"},{"line_number":1369,"context_line":"                self.assertEqual(test[\u0027result\u0027], res)"},{"line_number":1370,"context_line":"            else:"},{"line_number":1371,"context_line":"                self.assertIsNone(res)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8189cbd_f122ae86","line":1368,"in_reply_to":"673acdbc_2ef46af7","updated":"2023-06-05 16:01:01.000000000","message":"Yes to the second paragraph, one indicates whether the node is an object that is carried by this cache, the other doesn\u0027t.  In retrospect, probably worth a note.","commit_id":"a21245d5952bfc0f18332dac95ce1559e9b811db"}],"nodepool/zk/zookeeper.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f05ef5791ab998232057947533e231cd2c84b70d","unresolved":true,"context_lines":[{"line_number":757,"context_line":"        self._playback_worker \u003d threading.Thread("},{"line_number":758,"context_line":"            target\u003dself._playbackWorker)"},{"line_number":759,"context_line":"        self._playback_worker.daemon \u003d True"},{"line_number":760,"context_line":"        self._playback_worker.start()"},{"line_number":761,"context_line":"        zk.kazoo_client.add_listener(self._sessionListener)"},{"line_number":762,"context_line":"        self._start()"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"617cb488_beb9791b","line":760,"updated":"2023-06-02 18:11:46.000000000","message":"Should these two thread start() calls be moved into the _start() method so that if you stop() there is a way to start again without creating a new object?","commit_id":"a21245d5952bfc0f18332dac95ce1559e9b811db"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"14c59cbc378135389d58195f5a1e182637ea40a2","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        self._playback_worker \u003d threading.Thread("},{"line_number":758,"context_line":"            target\u003dself._playbackWorker)"},{"line_number":759,"context_line":"        self._playback_worker.daemon \u003d True"},{"line_number":760,"context_line":"        self._playback_worker.start()"},{"line_number":761,"context_line":"        zk.kazoo_client.add_listener(self._sessionListener)"},{"line_number":762,"context_line":"        self._start()"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"94f4b668_c0a6d2c5","line":760,"in_reply_to":"617cb488_beb9791b","updated":"2023-06-05 16:01:01.000000000","message":"That would be a good design and we should probably do that if we generalize this more.  I was trying to avoid changes to the startup/shutdown sequence in nodepool.","commit_id":"a21245d5952bfc0f18332dac95ce1559e9b811db"}]}