)]}'
{"nodepool/driver/kubernetes/provider.py":[{"author":{"_account_id":35200,"name":"Marvin Becker","email":"marvinbecker@mail.de","username":"mbecker"},"change_message_id":"f01f071dae5f25fe7aeeb9970f69ba2724e1c607","unresolved":true,"context_lines":[{"line_number":429,"context_line":"        if provider_label.storage:"},{"line_number":430,"context_line":"            resources[\"ephemeral-storage\"] \u003d provider_label.storage"},{"line_number":431,"context_line":"        resources.update(provider_label.extra_resources)"},{"line_number":432,"context_line":"        return QuotaInformation(instances\u003d1, default\u003d1, **resources)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":435,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f422b1d_e9f38c83","line":432,"range":{"start_line":432,"start_character":45,"end_line":432,"end_character":54},"updated":"2023-06-07 09:20:12.000000000","message":"I remember seeing some problems when using 1 as the default for gpu resources. This would mean that any pod would claim 1 GPU unless otherwise specified, or 1 milli-GPU if we go that way.","commit_id":"934bc5f43254bc47cb95ca2d96228cfca99137d0"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"32a3ef06011d1b8b26375428cef4c2b8f80c408e","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if provider_label.storage:"},{"line_number":430,"context_line":"            resources[\"ephemeral-storage\"] \u003d provider_label.storage"},{"line_number":431,"context_line":"        resources.update(provider_label.extra_resources)"},{"line_number":432,"context_line":"        return QuotaInformation(instances\u003d1, default\u003d1, **resources)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":435,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a0414a4_ae797989","line":432,"in_reply_to":"7f422b1d_e9f38c83","updated":"2023-06-07 20:35:00.000000000","message":"You are right, this is incorrect and should be left to the default of 0 in all 3 drivers.","commit_id":"934bc5f43254bc47cb95ca2d96228cfca99137d0"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"19a040023078694db623b9f8fd6d9807f3540580","unresolved":true,"context_lines":[{"line_number":429,"context_line":"        if provider_label.storage:"},{"line_number":430,"context_line":"            resources[\"ephemeral-storage\"] \u003d provider_label.storage"},{"line_number":431,"context_line":"        resources.update(provider_label.extra_resources)"},{"line_number":432,"context_line":"        return QuotaInformation(instances\u003d1, **resources)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":435,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"cce315c0_f5ff039c","line":432,"updated":"2023-06-26 05:27:56.000000000","message":"What\u0027s the reason to remove default\u003d1 here?","commit_id":"56c3a45e48b7e4a1414660408a15c6053a59488c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"c532ee3e08cb650ad594574b30100f3b8306dfe7","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        if provider_label.storage:"},{"line_number":430,"context_line":"            resources[\"ephemeral-storage\"] \u003d provider_label.storage"},{"line_number":431,"context_line":"        resources.update(provider_label.extra_resources)"},{"line_number":432,"context_line":"        return QuotaInformation(instances\u003d1, **resources)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def unmanagedQuotaUsed(self):"},{"line_number":435,"context_line":"        # TODO: return real quota information about quota"}],"source_content_type":"text/x-python","patch_set":2,"id":"2181b6c1_83c11a65","line":432,"in_reply_to":"cce315c0_f5ff039c","updated":"2023-06-26 21:49:30.000000000","message":"There\u0027s more detail on the comment on the previous patchset, but in short, I think this was an error that caused us to \"over-claim\" quota resources.  We only didn\u0027t notice it because these drivers barely, if at all, actually did anything with quota.  We shouldn\u0027t claim to use one unit of quota for any unknown resource; this returns it to the default of 0.","commit_id":"56c3a45e48b7e4a1414660408a15c6053a59488c"}]}