)]}'
{"nodepool/zk/zookeeper.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"71699966a3e62cf46bb403ef7d0d86f20567da18","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"    def preCacheHook(self, event, exists):"},{"line_number":1075,"context_line":"        key \u003d self.zk._parseImagePausePath(event.path)"},{"line_number":1076,"context_line":"        if key is None:"},{"line_number":1077,"context_line":"            return"},{"line_number":1078,"context_line":"        # A pause flag is being added or removed"},{"line_number":1079,"context_line":"        # The image key is identical to the image pause path key."},{"line_number":1080,"context_line":"        image \u003d self._cached_objects.get(key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4ff59ae_5e45e990","line":1077,"updated":"2023-06-07 15:37:31.000000000","message":"According to the commit message we\u0027re interested in short circuiting via preCacheHook if the key is None. However we updated below to return True not here. Was the intent to modify this check here for the key being None and returning True here instead?\n\nIt looks like image being falsey is a valid use case reading _handlePlayback as cases like that can result in entries being added to the cache so I\u0027m not sure we want to short circuit here.","commit_id":"11bbfc2589506df2572bd4e5178a7e26a5fdb408"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"924228c5961a17e392c615fbc5b3e5d638ad04f7","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"    def preCacheHook(self, event, exists):"},{"line_number":1075,"context_line":"        key \u003d self.zk._parseImagePausePath(event.path)"},{"line_number":1076,"context_line":"        if key is None:"},{"line_number":1077,"context_line":"            return"},{"line_number":1078,"context_line":"        # A pause flag is being added or removed"},{"line_number":1079,"context_line":"        # The image key is identical to the image pause path key."},{"line_number":1080,"context_line":"        image \u003d self._cached_objects.get(key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f930a59_a7dc0188","line":1077,"in_reply_to":"a4ff59ae_5e45e990","updated":"2023-06-07 15:51:32.000000000","message":"You know what, I think at this point we should just remove all the short circuiting in the pre cache hook.  I think that\u0027s no longer needed since we\u0027re checking the object key in the main method.","commit_id":"11bbfc2589506df2572bd4e5178a7e26a5fdb408"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"71699966a3e62cf46bb403ef7d0d86f20567da18","unresolved":true,"context_lines":[{"line_number":1133,"context_line":"    def preCacheHook(self, event, exists):"},{"line_number":1134,"context_line":"        key \u003d self.zk._parseNodeLockPath(event.path)"},{"line_number":1135,"context_line":"        if key is None:"},{"line_number":1136,"context_line":"            return"},{"line_number":1137,"context_line":"        # A lock contender is being added or removed"},{"line_number":1138,"context_line":"        node_id, contender \u003d key"},{"line_number":1139,"context_line":"        # Construct a key for the node object"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b5c5374_3f3f382c","line":1136,"updated":"2023-06-07 15:37:31.000000000","message":"See above.","commit_id":"11bbfc2589506df2572bd4e5178a7e26a5fdb408"}]}