)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2452245da2bc8b744b42b79090dfd204a2d3f967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa156cac_92fc253c","updated":"2023-08-31 18:49:10.000000000","message":"One thought inline. Probably worth getting more opinions on that before changing anything though as I think it requires a big refactor of the ssh scanning method.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"}],"nodepool/nodeutils.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"90c645b24a984863dd6422775909e5a0402cde6b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if e.errno not in [errno.ECONNREFUSED, errno.EHOSTUNREACH, None]:"},{"line_number":95,"context_line":"                log.exception("},{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"46931a7c_d48050f5","line":97,"updated":"2023-08-31 18:50:25.000000000","message":"The exact reason that the condition above exists is because this happens all the time, is expected, and is extremely verbose.  I don\u0027t think we should log it.\n\nI think what would be acceptable is, at the end of the timeout sequence, you logged the final error in this way.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3dc17b20d271e7674866cdd090f1bc700c5913e5","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            if e.errno not in [errno.ECONNREFUSED, errno.EHOSTUNREACH, None]:"},{"line_number":95,"context_line":"                log.exception("},{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e840ebe5_786199d1","line":97,"in_reply_to":"46931a7c_d48050f5","updated":"2023-08-31 18:51:56.000000000","message":"Not resolved.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"916ec7bfb4d3b6de835989f05f9955ec88d2f2fd","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                log.exception("},{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"33856786_1b718234","line":98,"updated":"2023-08-31 18:44:30.000000000","message":"Since you mention that this can flood the log, then we might want to use the auto formatting logic of logging to avoid un-necessary work in non debug mode with:\n\n```\n  log.debug(\"Unable to connect to %s on port %s: %s\", ip, port, e)\n```","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2452245da2bc8b744b42b79090dfd204a2d3f967","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"},{"line_number":102,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc9da7e_388bfebf","line":99,"updated":"2023-08-31 18:49:10.000000000","message":"I think I have a preference for recording the last connection error type if the timeout is reached. We know that we\u0027ll have connection errors for every (most?) node booted while we wait for it to boot enough to have an ssh port litsening. But if we have an error after the acceptable timeout knowing what the connection error was for that would be helpful.\n\nRather than spam the logs we could just record that last occurrence. Unfortunately, I think that might mean completely refactoring the loop control here.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7a9c8b44851d2fe844e48f627e2fa84254a7eac9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"},{"line_number":102,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"85954357_e9549d25","line":99,"in_reply_to":"0bc9da7e_388bfebf","updated":"2023-08-31 18:51:26.000000000","message":"It\u0027s just an extra exception handler.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3dc17b20d271e7674866cdd090f1bc700c5913e5","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"},{"line_number":102,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba27f422_19640751","line":99,"in_reply_to":"0bc9da7e_388bfebf","updated":"2023-08-31 18:51:56.000000000","message":"Not resolved.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"06123065e3a2c94daf590ad16bc9af2725f11364","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"},{"line_number":102,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e976853f_eae26000","line":99,"in_reply_to":"0bc9da7e_388bfebf","updated":"2023-08-31 19:05:08.000000000","message":"Sigh.  Not resolved.","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"696fef6756a7e15e01c461b815fa1d8351195f6d","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                    \u0027Exception connecting to %s on port %s:\u0027 % (ip, port))"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                log.debug(\"Unable to connect to %s on port %s: %s\" % ("},{"line_number":99,"context_line":"                          ip, port, e))"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            log.exception(\"ssh socket connection failure\")"},{"line_number":102,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d18f723_24189877","line":99,"in_reply_to":"e976853f_eae26000","updated":"2023-08-31 19:06:24.000000000","message":"...","commit_id":"b239ec3a1199da3359237936bf2b110ebbd4ff3f"}]}