)]}'
{"doc/source/kubernetes.rst":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f613c2e43398bbeca78689c54f4529fdbcf46a2b","unresolved":true,"context_lines":[{"line_number":248,"context_line":"               with a service account that can create pods, services,"},{"line_number":249,"context_line":"               configmaps, etc."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            .. value:: pod"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"               Pod labels provide a dedicated namespace with a single pod"},{"line_number":254,"context_line":"               created using the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bdb9d9a3_29032d3c","line":251,"updated":"2024-01-30 20:01:45.000000000","message":"I wonder if we should use a new type here, does custom spec works for namespaces?","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0a6ec0e1c9282c3e6e90f26c0cad6266b45fd060","unresolved":false,"context_lines":[{"line_number":248,"context_line":"               with a service account that can create pods, services,"},{"line_number":249,"context_line":"               configmaps, etc."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            .. value:: pod"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"               Pod labels provide a dedicated namespace with a single pod"},{"line_number":254,"context_line":"               created using the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"27b7ecbd_ec50fbf5","line":251,"in_reply_to":"bdb9d9a3_29032d3c","updated":"2024-01-30 20:20:17.000000000","message":"No, it only works for pod.  I think it makes sense to keep the pod type and use specs with it.  The structure is still the same: Nodepool delivers a Pod to Zuul.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f613c2e43398bbeca78689c54f4529fdbcf46a2b","unresolved":true,"context_lines":[{"line_number":498,"context_line":"            This attribute is exclusive with all other label"},{"line_number":499,"context_line":"            attributes except"},{"line_number":500,"context_line":"            :attr:`providers.[kubernetes].pools.labels.name` and"},{"line_number":501,"context_line":"            :attr:`providers.[kubernetes].pools.labels.type`.  If a"},{"line_number":502,"context_line":"            `spec` is provided, then Nodepool will supply the contents"},{"line_number":503,"context_line":"            of this value verbatim to Kubernetes as the ``spec``"},{"line_number":504,"context_line":"            attribute of the Kubernetes ``Pod`` definition.  No other"}],"source_content_type":"text/x-rst","patch_set":2,"id":"be9e632c_1aaa6fa0","line":501,"updated":"2024-01-30 20:01:45.000000000","message":"It looks like annotations are also taken into account.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0a6ec0e1c9282c3e6e90f26c0cad6266b45fd060","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            This attribute is exclusive with all other label"},{"line_number":499,"context_line":"            attributes except"},{"line_number":500,"context_line":"            :attr:`providers.[kubernetes].pools.labels.name` and"},{"line_number":501,"context_line":"            :attr:`providers.[kubernetes].pools.labels.type`.  If a"},{"line_number":502,"context_line":"            `spec` is provided, then Nodepool will supply the contents"},{"line_number":503,"context_line":"            of this value verbatim to Kubernetes as the ``spec``"},{"line_number":504,"context_line":"            attribute of the Kubernetes ``Pod`` definition.  No other"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e970cff7_660e3e62","line":501,"in_reply_to":"be9e632c_1aaa6fa0","updated":"2024-01-30 20:20:17.000000000","message":"Ack, I\u0027ll update.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f613c2e43398bbeca78689c54f4529fdbcf46a2b","unresolved":true,"context_lines":[{"line_number":525,"context_line":"                         image: ubuntu:jammy"},{"line_number":526,"context_line":"                         imagePullPolicy: IfNotPresent"},{"line_number":527,"context_line":"                         command: [\"/bin/sh\", \"-c\"]"},{"line_number":528,"context_line":"                         args: [\"while true; do sleep 30; done;\"]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"68f81553_75e03b1f","line":528,"updated":"2024-01-30 20:01:45.000000000","message":"Perhaps we can use a simpler?:\n```\n  command: [\"sleep\", \"infinity\"]\n```","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0a6ec0e1c9282c3e6e90f26c0cad6266b45fd060","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                         image: ubuntu:jammy"},{"line_number":526,"context_line":"                         imagePullPolicy: IfNotPresent"},{"line_number":527,"context_line":"                         command: [\"/bin/sh\", \"-c\"]"},{"line_number":528,"context_line":"                         args: [\"while true; do sleep 30; done;\"]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dd4c5499_6401c140","line":528,"in_reply_to":"68f81553_75e03b1f","updated":"2024-01-30 20:20:17.000000000","message":"That sounds good, but let\u0027s do that in a followup since that\u0027s a distinct change and this one is well tested and doesn\u0027t really need to change.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"}],"doc/source/openshift-pods.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"17607efe0e356ac47066667380062c0ecfccefbf","unresolved":true,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"               labels:"},{"line_number":451,"context_line":"                 - name: custom-pod"},{"line_number":452,"context_line":"                   type: pod"},{"line_number":453,"context_line":"                   spec:"},{"line_number":454,"context_line":"                     containers:"},{"line_number":455,"context_line":"                       - name: custom-pod"}],"source_content_type":"text/x-rst","patch_set":5,"id":"56b5e937_07d9dd5d","line":452,"range":{"start_line":452,"start_character":19,"end_line":452,"end_character":28},"updated":"2024-01-30 23:52:38.000000000","message":"I don\u0027t think the openshift pods driver has a type field since it only does pods.","commit_id":"015d07cf2f423a4f824cb2fcc2b9c43ffe5ea925"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b42931d98941c2437c2257ed20a63e834dd31281","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"               labels:"},{"line_number":451,"context_line":"                 - name: custom-pod"},{"line_number":452,"context_line":"                   type: pod"},{"line_number":453,"context_line":"                   spec:"},{"line_number":454,"context_line":"                     containers:"},{"line_number":455,"context_line":"                       - name: custom-pod"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fbe097e2_ab80f04d","line":452,"in_reply_to":"56b5e937_07d9dd5d","updated":"2024-01-30 23:59:14.000000000","message":"Gah, every time!  I\u0027ll fix.","commit_id":"015d07cf2f423a4f824cb2fcc2b9c43ffe5ea925"}],"nodepool/driver/kubernetes/config.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f613c2e43398bbeca78689c54f4529fdbcf46a2b","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        k8s_label_from_user \u003d {"},{"line_number":165,"context_line":"            v.Required(\u0027name\u0027): str,"},{"line_number":166,"context_line":"            v.Required(\u0027type\u0027): str,"},{"line_number":167,"context_line":"            \u0027spec\u0027: dict,"},{"line_number":168,"context_line":"        }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        pool \u003d ConfigPool.getCommonSchemaDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7887a739_d37d77df","line":167,"range":{"start_line":167,"start_character":13,"end_line":167,"end_character":17},"updated":"2024-01-30 20:01:45.000000000","message":"Shouldn\u0027t the spec be Required?","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0a6ec0e1c9282c3e6e90f26c0cad6266b45fd060","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        k8s_label_from_user \u003d {"},{"line_number":165,"context_line":"            v.Required(\u0027name\u0027): str,"},{"line_number":166,"context_line":"            v.Required(\u0027type\u0027): str,"},{"line_number":167,"context_line":"            \u0027spec\u0027: dict,"},{"line_number":168,"context_line":"        }"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        pool \u003d ConfigPool.getCommonSchemaDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3cce93b3_534f5b9e","line":167,"in_reply_to":"7887a739_d37d77df","updated":"2024-01-30 20:20:17.000000000","message":"Yep (technically it works without it, but it\u0027s a better/more expressive schema with it, so we should include it).","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"}],"nodepool/driver/openshiftpods/config.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f613c2e43398bbeca78689c54f4529fdbcf46a2b","unresolved":true,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        openshift_label_from_user \u003d {"},{"line_number":92,"context_line":"            v.Required(\u0027name\u0027): str,"},{"line_number":93,"context_line":"            v.Required(\u0027type\u0027): str,"},{"line_number":94,"context_line":"            \u0027spec\u0027: dict,"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"023eb496_161072f8","line":93,"updated":"2024-01-30 20:01:45.000000000","message":"Is this actually used? The openshiftpods documentation doesn\u0027t mention any label type.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0a6ec0e1c9282c3e6e90f26c0cad6266b45fd060","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        openshift_label_from_user \u003d {"},{"line_number":92,"context_line":"            v.Required(\u0027name\u0027): str,"},{"line_number":93,"context_line":"            v.Required(\u0027type\u0027): str,"},{"line_number":94,"context_line":"            \u0027spec\u0027: dict,"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3c917549_6437491e","line":93,"in_reply_to":"023eb496_161072f8","updated":"2024-01-30 20:20:17.000000000","message":"Nope we should drop that.","commit_id":"c12dfd042318ebce681667c2a02c92bb01cc6464"}],"nodepool/tests/unit/test_driver_openshift.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"17607efe0e356ac47066667380062c0ecfccefbf","unresolved":true,"context_lines":[{"line_number":643,"context_line":"        self.assertEqual(node.attributes,"},{"line_number":644,"context_line":"                         {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027})"},{"line_number":645,"context_line":"        self.assertEqual(node.cloud, \u0027admin-cluster.local\u0027)"},{"line_number":646,"context_line":"        self.assertIsNone(node.host_id)"},{"line_number":647,"context_line":"        ns, pod \u003d self.fake_k8s_client._pod_requests[0]"},{"line_number":648,"context_line":"        self.assertEqual(pod[\u0027metadata\u0027], {"},{"line_number":649,"context_line":"            \u0027name\u0027: \u0027pod-custom\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b6b16e2e_66bd970c","line":646,"updated":"2024-01-30 23:52:38.000000000","message":"Why is the host_id None for openshift but not k8s or openshift pods?","commit_id":"015d07cf2f423a4f824cb2fcc2b9c43ffe5ea925"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b42931d98941c2437c2257ed20a63e834dd31281","unresolved":false,"context_lines":[{"line_number":643,"context_line":"        self.assertEqual(node.attributes,"},{"line_number":644,"context_line":"                         {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027value2\u0027})"},{"line_number":645,"context_line":"        self.assertEqual(node.cloud, \u0027admin-cluster.local\u0027)"},{"line_number":646,"context_line":"        self.assertIsNone(node.host_id)"},{"line_number":647,"context_line":"        ns, pod \u003d self.fake_k8s_client._pod_requests[0]"},{"line_number":648,"context_line":"        self.assertEqual(pod[\u0027metadata\u0027], {"},{"line_number":649,"context_line":"            \u0027name\u0027: \u0027pod-custom\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"92655177_93a3fbb0","line":646,"in_reply_to":"b6b16e2e_66bd970c","updated":"2024-01-30 23:59:14.000000000","message":"It looks like it\u0027s because the openshift driver just never sets it.  All the tests in this file match this behavior.\n\nThat should be fixed, but not relevant to this change.","commit_id":"015d07cf2f423a4f824cb2fcc2b9c43ffe5ea925"}]}