)]}'
{"nodepool/driver/aws/adapter.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16a32f4b5395e7e87ebb1979a05c2fd38ec534a9","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                SPOT if instance.get(\u0027InstanceLifecycle\u0027) \u003d\u003d \u0027spot\u0027"},{"line_number":427,"context_line":"                else ON_DEMAND)"},{"line_number":428,"context_line":"            if not quota:"},{"line_number":429,"context_line":"                continue"},{"line_number":430,"context_line":"            for attachment in instance[\u0027BlockDeviceMappings\u0027]:"},{"line_number":431,"context_line":"                volume_id \u003d attachment[\u0027Ebs\u0027][\u0027VolumeId\u0027]"},{"line_number":432,"context_line":"                volume \u003d volumes.get(volume_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6758fd20_3edbe9e9","line":429,"updated":"2024-03-27 16:25:57.000000000","message":"We don\u0027t need this because we\u0027re always going to return a quota info object (see comment below).","commit_id":"31847a2cfd57981e7b47de45c3599a2cfeb4e846"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16a32f4b5395e7e87ebb1979a05c2fd38ec534a9","unresolved":false,"context_lines":[{"line_number":935,"context_line":"                self.log.warning("},{"line_number":936,"context_line":"                    \"Unknown quota code for instance type: %s\","},{"line_number":937,"context_line":"                    instance_type)"},{"line_number":938,"context_line":"                return None"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def _getQuotaForInstanceType(self, instance_type, market_type_option):"},{"line_number":941,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ec17d8d_d42a6cb9","line":938,"updated":"2024-03-27 16:25:57.000000000","message":"returning None isn\u0027t necessary in python (that\u0027s the default), but it\u0027s fine to do so explicitly for clarity.  But it\u0027s a little weird to do it here and not also at the top level.  If you want to add it for clarity, I\u0027d probably just do it there.","commit_id":"31847a2cfd57981e7b47de45c3599a2cfeb4e846"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"16a32f4b5395e7e87ebb1979a05c2fd38ec534a9","unresolved":false,"context_lines":[{"line_number":963,"context_line":"        if code:"},{"line_number":964,"context_line":"            args[code] \u003d vcpus"},{"line_number":965,"context_line":"        else:"},{"line_number":966,"context_line":"            return None"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        return QuotaInformation(**args)"},{"line_number":969,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"668b9a6b_87a2ba62","line":966,"updated":"2024-03-27 16:25:57.000000000","message":"We want to return as much quota information as we can here, even if it\u0027s only \"instances\u003d1\" or maybe the cores and ram, so we should not return None here.","commit_id":"31847a2cfd57981e7b47de45c3599a2cfeb4e846"}]}