)]}'
{"nodepool/driver/fake/adapter.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5a2fdf0d586ba430853bf778fbea68511acb2c39","unresolved":true,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def create_server(self, **kw):"},{"line_number":335,"context_line":"        if self._create_server_timeout:"},{"line_number":336,"context_line":"            self._create_server_timeout -\u003d 1"},{"line_number":337,"context_line":"            kw[\u0027_test_timeout\u0027] \u003d True"},{"line_number":338,"context_line":"        return self._create(self._server_list, **kw)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"319e1f7c_5a351cfe","line":336,"updated":"2024-04-24 20:42:43.000000000","message":"This counter is just here to force multiple failures due to timeouts then an eventual success?","commit_id":"64452f1a263b3457ea6c948376158fe61c5e9a77"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0aa28589571262c2d80128e39fedb4d4b0d16c44","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def create_server(self, **kw):"},{"line_number":335,"context_line":"        if self._create_server_timeout:"},{"line_number":336,"context_line":"            self._create_server_timeout -\u003d 1"},{"line_number":337,"context_line":"            kw[\u0027_test_timeout\u0027] \u003d True"},{"line_number":338,"context_line":"        return self._create(self._server_list, **kw)"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8f9114e9_91eae862","line":336,"in_reply_to":"319e1f7c_5a351cfe","updated":"2024-04-24 20:51:12.000000000","message":"Exactly.","commit_id":"64452f1a263b3457ea6c948376158fe61c5e9a77"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5a2fdf0d586ba430853bf778fbea68511acb2c39","unresolved":true,"context_lines":[{"line_number":480,"context_line":"            raise Exception(\"Test fail server delete.\")"},{"line_number":481,"context_line":"        if self.times_failed_delete \u003c self.times_to_fail_delete:"},{"line_number":482,"context_line":"            self.times_failed_delete +\u003d 1"},{"line_number":483,"context_line":"            raise Exception(\"Test fail server delete.\")"},{"line_number":484,"context_line":"        else:"},{"line_number":485,"context_line":"            self.delete_success \u003d True"},{"line_number":486,"context_line":"            return super().delete_server(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b38fa5f_ae151c40","line":483,"updated":"2024-04-24 20:42:43.000000000","message":"Why did we change the exception type here? Wasn\u0027t this effectively a timeout test for deletions before?","commit_id":"64452f1a263b3457ea6c948376158fe61c5e9a77"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0aa28589571262c2d80128e39fedb4d4b0d16c44","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            raise Exception(\"Test fail server delete.\")"},{"line_number":481,"context_line":"        if self.times_failed_delete \u003c self.times_to_fail_delete:"},{"line_number":482,"context_line":"            self.times_failed_delete +\u003d 1"},{"line_number":483,"context_line":"            raise Exception(\"Test fail server delete.\")"},{"line_number":484,"context_line":"        else:"},{"line_number":485,"context_line":"            self.delete_success \u003d True"},{"line_number":486,"context_line":"            return super().delete_server(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"385e68ac_ec356aa6","line":483,"in_reply_to":"9b38fa5f_ae151c40","updated":"2024-04-24 20:51:12.000000000","message":"This is cleanup.  This test code was the only place the exception was raised.  It is never explicitly caught, but it was a subclass of TimeoutException, which means it could have theoretically been caught somewhere.  However, this method is a fake for the openstack client, and the openstack client is never going to raise a \"nodepool.exceptions.ServerDeleteException\".  That means this code was incorrectly faking the openstack sdk, and if any code was actually relying on it (I don\u0027t think it was) that would be erroneous too.\n\nWith that cleanup out of the way, I can make the new ServerDeleteTimeoutException and not have it be confused with the defunct ServerDeleteException.","commit_id":"64452f1a263b3457ea6c948376158fe61c5e9a77"}]}