)]}'
{"nodepool/driver/openstack/adapter.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ba85ecfbe4ab375ab699dd494fb16ef39c72166f","unresolved":true,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def listResources(self):"},{"line_number":470,"context_line":"        # Cleanup any leaked futures"},{"line_number":471,"context_line":"        for key, future in list(self.api_futures.items()):"},{"line_number":472,"context_line":"            if future.done():"},{"line_number":473,"context_line":"                self.api_futures.pop(key, None)"},{"line_number":474,"context_line":"        for server in self._listServers():"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff4ec7ec_67271814","line":471,"updated":"2024-06-27 18:08:29.000000000","message":"We don\u0027t seem to initialize self.api_futures anywhere and grepping the repo doesn\u0027t show it set in a parent class.","commit_id":"d1d8ea89baf4c9f330f93b0bd3db0540cba3b25c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"14eb21830f7ce65fe93b2f8958c119a54f6d96ac","unresolved":false,"context_lines":[{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def listResources(self):"},{"line_number":470,"context_line":"        # Cleanup any leaked futures"},{"line_number":471,"context_line":"        for key, future in list(self.api_futures.items()):"},{"line_number":472,"context_line":"            if future.done():"},{"line_number":473,"context_line":"                self.api_futures.pop(key, None)"},{"line_number":474,"context_line":"        for server in self._listServers():"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d6cad3e_4cc651a3","line":471,"in_reply_to":"ff4ec7ec_67271814","updated":"2024-06-27 18:11:59.000000000","message":"Oops.  :)","commit_id":"d1d8ea89baf4c9f330f93b0bd3db0540cba3b25c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ba85ecfbe4ab375ab699dd494fb16ef39c72166f","unresolved":true,"context_lines":[{"line_number":470,"context_line":"        # Cleanup any leaked futures"},{"line_number":471,"context_line":"        for key, future in list(self.api_futures.items()):"},{"line_number":472,"context_line":"            if future.done():"},{"line_number":473,"context_line":"                self.api_futures.pop(key, None)"},{"line_number":474,"context_line":"        for server in self._listServers():"},{"line_number":475,"context_line":"            if server[\u0027status\u0027].lower() \u003d\u003d \u0027deleted\u0027:"},{"line_number":476,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2aa7c0a_df7e25fa","line":473,"updated":"2024-06-27 18:08:29.000000000","message":"By popping these completed futures we won\u0027t return their result like we do in _completeApi() below. Would that cause us to miss important events (like the server being created?).","commit_id":"d1d8ea89baf4c9f330f93b0bd3db0540cba3b25c"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"14eb21830f7ce65fe93b2f8958c119a54f6d96ac","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        # Cleanup any leaked futures"},{"line_number":471,"context_line":"        for key, future in list(self.api_futures.items()):"},{"line_number":472,"context_line":"            if future.done():"},{"line_number":473,"context_line":"                self.api_futures.pop(key, None)"},{"line_number":474,"context_line":"        for server in self._listServers():"},{"line_number":475,"context_line":"            if server[\u0027status\u0027].lower() \u003d\u003d \u0027deleted\u0027:"},{"line_number":476,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"209da274_35aaad78","line":473,"in_reply_to":"d2aa7c0a_df7e25fa","updated":"2024-06-27 18:11:59.000000000","message":"No, because if anyone is still waiting for it, they will have a pointer to it.\n\n(We\u0027re abusing this method to do a periodic cleanup, since it\u0027s only use is in a periodic cleanup.  It\u0027s counter-intuitive that we would ignore something like that in this method, but that\u0027s really all we\u0027re doing here.  Note that lines 400+ also have some periodic cleanup going on.)","commit_id":"d1d8ea89baf4c9f330f93b0bd3db0540cba3b25c"}]}