)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f74b100559cf3e5efc1a45068f73fa33dfb138fd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Mean while, we do not need to check the \u0027node.resources[\u0027cores\u0027]\u0027,"},{"line_number":20,"context_line":"because for fleet api, if it is 0, means it is not lauched yet, and"},{"line_number":21,"context_line":"it\u0027s correct to return the empty qi. For others, it is not possible"},{"line_number":22,"context_line":"for it to be 0."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ibe3795be3082cac358ca68fba6b8bdb52af3d7dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"77785eb3_3ad23867","line":22,"updated":"2024-07-30 13:47:24.000000000","message":"This code doesn\u0027t know anything about the fleet api; so you should add the None check in addition to the existing cores check.","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"315962af107454c9f5e2482a154da8c4b58a7f2a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Mean while, we do not need to check the \u0027node.resources[\u0027cores\u0027]\u0027,"},{"line_number":20,"context_line":"because for fleet api, if it is 0, means it is not lauched yet, and"},{"line_number":21,"context_line":"it\u0027s correct to return the empty qi. For others, it is not possible"},{"line_number":22,"context_line":"for it to be 0."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ibe3795be3082cac358ca68fba6b8bdb52af3d7dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e6001c36_3e5d4473","line":22,"in_reply_to":"77785eb3_3ad23867","updated":"2024-07-30 16:09:53.000000000","message":"I believe we originally added the cores check because in the fleet api, we:\n1) Send the create fleet api call\n2) Set node.resources to QuotaInformation(instances\u003d1)\n3) Receive the create fleet api response\n4) Set node.resources to QuotaInformation(instances\u003d1, cores\u003dX)\n\nSo this was originally designed to only trigger once step #4 happened.  However, I think I agree with you that it should be safe to run any time we have a non-null node.resources, so I think this change is okay as written.","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"},{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"270ad0ab23f277f6b5544a19e5cd6ebf77d79966","unresolved":true,"context_lines":[{"line_number":19,"context_line":"Mean while, we do not need to check the \u0027node.resources[\u0027cores\u0027]\u0027,"},{"line_number":20,"context_line":"because for fleet api, if it is 0, means it is not lauched yet, and"},{"line_number":21,"context_line":"it\u0027s correct to return the empty qi. For others, it is not possible"},{"line_number":22,"context_line":"for it to be 0."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ibe3795be3082cac358ca68fba6b8bdb52af3d7dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2a59d357_c8e6b2b2","line":22,"in_reply_to":"77785eb3_3ad23867","updated":"2024-07-30 13:55:13.000000000","message":"I mentioned the fleet api is to try to explain why we do not need to check `cores` here. What I really want to explain is as long as the node.resources is not None, it should be a valid value to return, no matter it is fleet API or not. \nAdding a `cores` check do no harm but seems not necessary?","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28088,"name":"Benedikt Löffler","email":"benedikt.loeffler@bmw.de","username":"bloeffler"},"change_message_id":"b8af3ccea1ac7595fc754a9a107229f18df6de31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"280e9091_70cb0fb6","updated":"2024-07-31 08:30:07.000000000","message":"recheck","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"},{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"2807a17b5acdd5c6a34425ce341e46be4bfa0125","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9de49fc3_bf7c3236","updated":"2024-07-29 10:51:43.000000000","message":"recheck","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"},{"author":{"_account_id":33134,"name":"Dong Zhang","email":"dong.zhang@bmw.de","username":"dongzhang"},"change_message_id":"abf7a7d1abda62ba8be4cd8fe6499ae7b43b05e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1879b30_8695928e","updated":"2024-07-29 14:06:29.000000000","message":"recheck","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"},{"author":{"_account_id":28088,"name":"Benedikt Löffler","email":"benedikt.loeffler@bmw.de","username":"bloeffler"},"change_message_id":"d0885a0948c1c9787cb9c2a5272293f4e3b0e303","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8265ea01_3184e8e2","updated":"2024-07-31 08:08:31.000000000","message":"regate","commit_id":"6101d2e724ccef5acf7d4d4662436d9ad6a59567"}]}