)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f63c0d3a08027ba33e7f19452cbec30d15e567ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50802e3c_ba188745","updated":"2024-12-18 16:08:02.000000000","message":"I like the idea, but I have some questions inline","commit_id":"8724f15e9d98c4d97b37de7255c64d541d9560e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"26a7df766f5f3765e0dfb9d1f8e8261c30522de4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67c56d5e_cc8d01fa","updated":"2024-09-23 16:08:42.000000000","message":"recheck not sure how the failure is related, maybe only unstable?","commit_id":"8724f15e9d98c4d97b37de7255c64d541d9560e5"}],"nodepool/driver/openstack/adapter.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f63c0d3a08027ba33e7f19452cbec30d15e567ae","unresolved":true,"context_lines":[{"line_number":633,"context_line":"                    volume \u003d self._client.block_storage.create_volume("},{"line_number":634,"context_line":"                        size\u003dvolume_size,"},{"line_number":635,"context_line":"                        volume_type\u003dvolume_type,"},{"line_number":636,"context_line":"                    )"},{"line_number":637,"context_line":"                create_args[\u0027boot_volume\u0027] \u003d volume.id"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            # NOTE(pabelanger): Always cleanup volumes when we delete a server."}],"source_content_type":"text/x-python","patch_set":1,"id":"e1bd8dbc_de7a9138","line":636,"updated":"2024-12-18 16:08:02.000000000","message":"I think we\u0027d need to make sure that the volume creation was successful and fail properly when it doesn\u0027t?","commit_id":"8724f15e9d98c4d97b37de7255c64d541d9560e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f63c0d3a08027ba33e7f19452cbec30d15e567ae","unresolved":true,"context_lines":[{"line_number":666,"context_line":"            # next time we get new caches."},{"line_number":667,"context_line":"            self.log.info("},{"line_number":668,"context_line":"                \"Clearing az, flavor and image caches due to 400 error \""},{"line_number":669,"context_line":"                \"from nova\")"},{"line_number":670,"context_line":"            self._findImage.cache_clear()"},{"line_number":671,"context_line":"            self._listFlavors.cache_clear()"},{"line_number":672,"context_line":"            self._findNetwork.cache_clear()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3bda9ca9_7c58f83b","line":669,"updated":"2024-12-18 16:08:02.000000000","message":"we\u0027d also need to delete the volume here if we created one? I don\u0027t think we can rely on the \"terminate_volume\" flag being in effect if the create_server call fails?","commit_id":"8724f15e9d98c4d97b37de7255c64d541d9560e5"}]}
