)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36342,"name":"Damian Fajfer","display_name":"fajfer","email":"damian@fajfer.org","username":"fajfer"},"change_message_id":"9622c0a628fa578a711b5e39a08abad9bdcc293f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc4518eb_55e73101","updated":"2025-04-29 10:03:22.000000000","message":"Tested it out, works for me without problems. Thanks Cyril","commit_id":"a8ab6e9c5f0936efa5045dddf68eb74da7723862"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"75af6f8ba6293a19a2cbc777777f7f3def3f1c66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"050d4f59_abcc072a","updated":"2025-04-15 05:54:40.000000000","message":"recheck","commit_id":"a8ab6e9c5f0936efa5045dddf68eb74da7723862"},{"author":{"_account_id":36342,"name":"Damian Fajfer","display_name":"fajfer","email":"damian@fajfer.org","username":"fajfer"},"change_message_id":"529ace08d39b7fb66262d2218c768335506ef66e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"94dfa172_cea5f97e","updated":"2025-04-29 10:05:43.000000000","message":"recheck","commit_id":"a8ab6e9c5f0936efa5045dddf68eb74da7723862"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"7d3b9cb02fe9ef3e45f5030a0c55e72f8adc8828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e4a7cc88_ef02c181","updated":"2025-04-29 11:47:36.000000000","message":"recheck","commit_id":"206e6153db08c3960cd7308389153f17c27a6ea9"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"1e2acfc8c5add92962ba305e3e12ed24cec8fff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79ed7997_a567ab68","updated":"2025-05-21 15:27:15.000000000","message":"I\u0027m not sure what level of unittesting we expect to do for the azure driver within nodepool. Others may ask for updated unittests.\n\nAlso this should probably be stacked with 933545.","commit_id":"92ceedbafe32678980bee9ce0dc3728a5efa188b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"26c95ab2a4df0ec680887cbfa074228c07dd1230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5ad352f8_bb6d2978","updated":"2025-05-21 16:22:48.000000000","message":"Sounds like the nodepool azure driver is considered mature and updates to it need to come with test updates. I\u0027m updating my review to reflect that.","commit_id":"92ceedbafe32678980bee9ce0dc3728a5efa188b"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"8950ad827a04c624232f26629011fec7be84721e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e99c789c_b5b52f7c","updated":"2025-05-16 21:20:17.000000000","message":"recheck","commit_id":"92ceedbafe32678980bee9ce0dc3728a5efa188b"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"93f233d591eb48b24c33296c56a2aefbd576baeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1b2dfcb9_0893d030","in_reply_to":"5ad352f8_bb6d2978","updated":"2025-05-29 10:10:56.000000000","message":"\u003e Sounds like the nodepool azure driver is considered mature and updates to it need to come with test updates. I\u0027m updating my review to reflect that.\n\nThank you for your review Clark!","commit_id":"92ceedbafe32678980bee9ce0dc3728a5efa188b"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"93f233d591eb48b24c33296c56a2aefbd576baeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1364e35c_da60f652","in_reply_to":"79ed7997_a567ab68","updated":"2025-05-29 10:10:56.000000000","message":"\u003e I\u0027m not sure what level of unittesting we expect to do for the azure driver within nodepool. Others may ask for updated unittests.\n\u003e \n\u003e Also this should probably be stacked with 933545.\n\nThank you for your review Clark! \n\nI extend Azure unit tests to check if the spot instance property is set in the VM request. I guess should be enough?\n\nFor 933545 I decided to split it because I adding new functionality .","commit_id":"92ceedbafe32678980bee9ce0dc3728a5efa188b"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"93f233d591eb48b24c33296c56a2aefbd576baeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9dcccf3_280a67ab","updated":"2025-05-29 10:10:56.000000000","message":"recheck","commit_id":"2ac84abd74309dbb2f32f08e014d5b071046d46a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d7112b7c6c919036abe8183ad09f6432155c1a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b13930ee_6cda634a","updated":"2025-10-10 16:31:21.000000000","message":"I\u0027m not going to claim to be an azure spot instance details expert but it does look like the test case that was added is checking the two major properties of a spot instances that I would expect.","commit_id":"d2c596a32fae5aba8d766568f7257959cb011e22"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"19ad98195853c28971d1e211f4c9eedf884cf885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"803cac70_8f079428","updated":"2025-12-06 01:16:43.000000000","message":"recheck this failed in what I think is an unrelated unittest.","commit_id":"7bb9e4a8fe33f1eb9ab59d1bfe8aa9cf417b3c0b"}]}
