)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"38e3f92d1144f8541e95afddeee69ba47d2cc32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27a46b07_dbe1fb34","updated":"2024-10-28 06:25:18.000000000","message":"recheck","commit_id":"8399c57459839409894a6b9dceadef49a82e760a"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"5d57c5cabba3ae26b4232977f3b3c46bd8f218bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6328f189_732e2baa","updated":"2024-10-29 15:42:20.000000000","message":"recheck","commit_id":"8399c57459839409894a6b9dceadef49a82e760a"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"c4f78a641a8d5a1179bb337f8b6a500ab472c60b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df653ea9_0d089367","updated":"2025-04-29 11:48:37.000000000","message":"recheck","commit_id":"ffddc94b9209139449f7dc37c7a36e16c544d14f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ec19fe79311b8e4ae3a0f486b3b47646729e9994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aba8b16_f6e04782","updated":"2025-05-21 15:27:29.000000000","message":"I\u0027m not sure what level of unittesting we expect to do for the azure driver within nodepool. Others may ask for updated unittests.\n\nAlso this should probably be stacked with 933030.","commit_id":"59a0b6b1f54a21db9e65bea8c8cc95b603d67822"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"28bd87d348e193dfa899f734fed12110e61d1b54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3d817ba_da8ee48c","updated":"2025-05-21 16:23:00.000000000","message":"Sounds like the nodepool azure driver is considered mature and updates to it need to come with test updates. I\u0027m updating my review to reflect that.","commit_id":"59a0b6b1f54a21db9e65bea8c8cc95b603d67822"},{"author":{"_account_id":36342,"name":"Damian Fajfer","display_name":"fajfer","email":"damian@fajfer.org","username":"fajfer"},"change_message_id":"c525f3e3972e6831b45754f34bf7ad0a096f7378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d37de242_0cafd87a","updated":"2025-05-21 10:49:32.000000000","message":"Works for me","commit_id":"59a0b6b1f54a21db9e65bea8c8cc95b603d67822"},{"author":{"_account_id":37403,"name":"Kiril Valchev","display_name":"Kiril V. Valchev","email":"kiril.v.valchev@gmail.com","username":"yodakv"},"change_message_id":"3cb1a933baa19536747918b4b06a017d6a03743a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19b39883_98f99876","updated":"2025-05-16 21:20:51.000000000","message":"recheck","commit_id":"59a0b6b1f54a21db9e65bea8c8cc95b603d67822"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"43d2de54baf9d752bbe72461eae806990df15d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"71096279_e7470f6a","updated":"2025-12-06 01:28:47.000000000","message":"recheck the image build failed on docker hub rate limits for the opendev base python images","commit_id":"74a885bd4507f1196b822bf7a0a1653c4be45c9b"}],"nodepool/tests/unit/test_driver_azure.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"43d2de54baf9d752bbe72461eae806990df15d4a","unresolved":true,"context_lines":[{"line_number":564,"context_line":"        self.assertEqual(osDisk[\u0027diffDiskSettings\u0027][\u0027option\u0027], \u0027Local\u0027)"},{"line_number":565,"context_line":"        self.assertIn(\u0027placement\u0027, osDisk[\u0027diffDiskSettings\u0027])"},{"line_number":566,"context_line":"        self.assertEqual(osDisk[\u0027diffDiskSettings\u0027][\u0027placement\u0027],"},{"line_number":567,"context_line":"                         \u0027ResourceDisk\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7774b756_2eb00f4d","line":567,"updated":"2025-12-06 01:28:47.000000000","message":"I guess we aren\u0027t tracking quotas for disk usage in nodepool? I ask because if we are do we need to add quota handling for this new disk type similarly to how the different cpu cores are tracked in the previous change?","commit_id":"74a885bd4507f1196b822bf7a0a1653c4be45c9b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"73f1c1b4b392fd3f7883441d0534c95f3551f4e4","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.assertEqual(osDisk[\u0027diffDiskSettings\u0027][\u0027option\u0027], \u0027Local\u0027)"},{"line_number":565,"context_line":"        self.assertIn(\u0027placement\u0027, osDisk[\u0027diffDiskSettings\u0027])"},{"line_number":566,"context_line":"        self.assertEqual(osDisk[\u0027diffDiskSettings\u0027][\u0027placement\u0027],"},{"line_number":567,"context_line":"                         \u0027ResourceDisk\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"896517c6_e4dcf606","line":567,"in_reply_to":"7774b756_2eb00f4d","updated":"2026-02-05 18:10:38.000000000","message":"At least the azure driver doesn\u0027t have any disk quota support yet.  We might want to add it in general, but I don\u0027t think adding this new type needs to be contingent on it.","commit_id":"74a885bd4507f1196b822bf7a0a1653c4be45c9b"}]}