)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"eadbd8ce27cf34cd57d1ddfbc7ab6b39cbac2ab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b9f5ebb5_caa70578","updated":"2024-11-25 11:47:17.000000000","message":"Thank you Matthieu. Please let me know if my suggestion is correct, otherwise I\u0027m +2 on this.","commit_id":"88901628f3e3c0a4fcf8377aad486f4f8220ef98"}],"nodepool/cmd/config_validator.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"eadbd8ce27cf34cd57d1ddfbc7ab6b39cbac2ab6","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        labels \u003d [x[\u0027name\u0027] for x in config.get(\u0027labels\u0027, [])]"},{"line_number":150,"context_line":"        for provider in config.get(\u0027providers\u0027, []):"},{"line_number":151,"context_line":"            if provider.get(\u0027driver\u0027) \u003d\u003d \u0027openshift\u0027:"},{"line_number":152,"context_line":"                errors \u003d openshift_extra_validator(provider)"},{"line_number":153,"context_line":"            if provider.get(\u0027driver\u0027) \u003d\u003d \u0027openshiftpods\u0027:"},{"line_number":154,"context_line":"                errors \u003d openshiftpods_extra_validator(provider)"},{"line_number":155,"context_line":"            if provider.get(\u0027driver\u0027, \u0027openstack\u0027) !\u003d \u0027openstack\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"a945c9eb_3423af75","line":152,"updated":"2024-11-25 11:47:17.000000000","message":"It looks like this may reset the errors value from the other provider, shouldn\u0027t this be using instead:\n\n```\nif openshift_extra_validator(provider):\n  errors \u003d True\n```\n\nPerhaps the method could be renamed for clarity.","commit_id":"88901628f3e3c0a4fcf8377aad486f4f8220ef98"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"73504dd8732dfde1856b0d0dfa89d9625c9e98a8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        labels \u003d [x[\u0027name\u0027] for x in config.get(\u0027labels\u0027, [])]"},{"line_number":150,"context_line":"        for provider in config.get(\u0027providers\u0027, []):"},{"line_number":151,"context_line":"            if provider.get(\u0027driver\u0027) \u003d\u003d \u0027openshift\u0027:"},{"line_number":152,"context_line":"                errors \u003d openshift_extra_validator(provider)"},{"line_number":153,"context_line":"            if provider.get(\u0027driver\u0027) \u003d\u003d \u0027openshiftpods\u0027:"},{"line_number":154,"context_line":"                errors \u003d openshiftpods_extra_validator(provider)"},{"line_number":155,"context_line":"            if provider.get(\u0027driver\u0027, \u0027openstack\u0027) !\u003d \u0027openstack\u0027:"}],"source_content_type":"text/x-python","patch_set":20,"id":"47e2d760_d939b8b0","line":152,"in_reply_to":"a945c9eb_3423af75","updated":"2024-11-25 13:38:07.000000000","message":"Done, next PS should fix the issue.","commit_id":"88901628f3e3c0a4fcf8377aad486f4f8220ef98"}],"nodepool/driver/__init__.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"23e499b425369c52968226371ca35d504fbb811f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        if error:"},{"line_number":55,"context_line":"            Drivers.log.error(\"%s: %s\", path, error)"},{"line_number":56,"context_line":"            return False"},{"line_number":57,"context_line":"        Drivers.log.debug(\"driver %s class found: %r\", driver_name, obj)"},{"line_number":58,"context_line":"        return obj[0][1]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":21,"id":"0ba8054e_0ef27e57","line":57,"updated":"2024-11-25 16:24:06.000000000","message":"Extra debug?","commit_id":"74be49aab83c4d78fa4eb59497698c285fc7dc05"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"23e499b425369c52968226371ca35d504fbb811f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                        \"%s: skipping incorrect driver from __init__.py\","},{"line_number":83,"context_line":"                        driver_path)"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":"                Drivers.log.debug(\"driver %s@%s loaded\", driver, driver_path)"},{"line_number":86,"context_line":"                Drivers.drivers[driver] \u003d driver_obj()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        Drivers.drivers_paths \u003d drivers_paths"}],"source_content_type":"text/x-python","patch_set":21,"id":"d31742b3_41bdd6e5","line":85,"updated":"2024-11-25 16:24:06.000000000","message":"Extra debug?","commit_id":"74be49aab83c4d78fa4eb59497698c285fc7dc05"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"23e499b425369c52968226371ca35d504fbb811f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if not Drivers.drivers:"},{"line_number":93,"context_line":"            Drivers.load()"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            Drivers.log.debug(\"get \u0027%s\u0027 driver\", name)"},{"line_number":96,"context_line":"            return Drivers.drivers[name]"},{"line_number":97,"context_line":"        except KeyError:"},{"line_number":98,"context_line":"            raise RuntimeError(\"%s: unknown driver\" % name)"}],"source_content_type":"text/x-python","patch_set":21,"id":"85f32ec9_73106d6e","line":95,"updated":"2024-11-25 16:24:06.000000000","message":"Extra debug?","commit_id":"74be49aab83c4d78fa4eb59497698c285fc7dc05"}]}