)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b0ca7c9dc0ccfb0c0c98031090b32cda0e7b47c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Benjamin Schanzel \u003cbenjamin.schanzel@bmw.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-10 11:10:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix unused/unassined nonlocal vars (F842)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"flake8 v7.2.0 includes F842 which requires global/nonlocal vars to be"},{"line_number":10,"context_line":"assined in their scope. Fix this by removing unassined nonlocal vars."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de00edcf_0158ded0","line":7,"updated":"2025-04-10 14:37:45.000000000","message":"It\u0027s actually 824.","commit_id":"f6accd8a640c3a74870faba74afab96df62ca703"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"443e0d4819e14ec27d73594155fc8052ef53f0bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1beb0788_202e287c","updated":"2025-04-10 14:58:57.000000000","message":"I have a slight preference to ignore this rule as I think communicating the nonlocal scope of variables to the programmer is useful even if we are not assigning the variable. It is informative and defensive.","commit_id":"7813a1839fd09337c19c4da23719b277ee0dbe83"}],"nodepool/tests/unit/test_driver_metastatic.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"621afc0a73a7407caad65e7aeed0f4f6dba37e96","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        orig_advance \u003d nodepool.driver.statemachine.NodescanRequest.advance"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        def handler(*args, **kw):"},{"line_number":245,"context_line":"            nonlocal counter, fail"},{"line_number":246,"context_line":"            counter +\u003d 1"},{"line_number":247,"context_line":"            if counter \u003e\u003d len(fail):"},{"line_number":248,"context_line":"                return orig_advance(*args, **kw)"}],"source_content_type":"text/x-python","patch_set":1,"id":"23904c98_3ba70123","side":"PARENT","line":245,"updated":"2025-04-10 14:36:38.000000000","message":"I\u0027m ambivalent about this.  It\u0027s true that fail isn\u0027t assigned so the nonlocal isn\u0027t needed.  But this line does somewhat serve the purpose of documenting that the pair of variables (counter, fail) are used together and both reference the outer scope.\n\nNote that python will throw an exception if the variable can\u0027t be bound -- so if we did a typo like \"fial\" above, we would get a parse error -- so this isn\u0027t catching that kind of serious programming error.","commit_id":"fa75c998ae29d7d72cbb020b395b40eef48c80cc"}]}