)]}'
{"nodepool/driver/azure/adapter.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c40f857e86fb5893e88a3b055ff650c5a39861ea","unresolved":true,"context_lines":[{"line_number":202,"context_line":"                    if \u0027publicIPAddress\u0027 in ip_config[\u0027properties\u0027]:"},{"line_number":203,"context_line":"                        public_ip \u003d ip_config[\u0027properties\u0027][\u0027publicIPAddress\u0027]"},{"line_number":204,"context_line":"                        ip_version \u003d (ip_config[\u0027properties\u0027]"},{"line_number":205,"context_line":"                                      [\u0027privateIPAddressVersion\u0027])"},{"line_number":206,"context_line":"                        if ip_version \u003d\u003d \u0027IPv4\u0027:"},{"line_number":207,"context_line":"                            self.public_ipv4 \u003d public_ip"},{"line_number":208,"context_line":"                            self.public_ipv4[\u0027type\u0027] \u003d\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3b6dd894_a4841302","line":205,"range":{"start_line":205,"start_character":40,"end_line":205,"end_character":47},"updated":"2025-07-19 17:49:46.000000000","message":"In `make_ip_config()` below we set publicIpAddressVersion in addition to the preexisting privateIPAddressVersion value. Should this key here be publicIPAddressVersion to match? I worry that we may treat the public IP address as one version when it is another due to checking against the private IP here instead.\n\nThat said it isn\u0027t clear to me if this change is what was necessary or if it is the datastructure level change instead.","commit_id":"202e21181fb57fa7b64ae4cba9a3ba178cdf0da9"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f49f7a34ce93feab61a1e7d8a999670255ad2f2a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    if \u0027publicIPAddress\u0027 in ip_config[\u0027properties\u0027]:"},{"line_number":203,"context_line":"                        public_ip \u003d ip_config[\u0027properties\u0027][\u0027publicIPAddress\u0027]"},{"line_number":204,"context_line":"                        ip_version \u003d (ip_config[\u0027properties\u0027]"},{"line_number":205,"context_line":"                                      [\u0027privateIPAddressVersion\u0027])"},{"line_number":206,"context_line":"                        if ip_version \u003d\u003d \u0027IPv4\u0027:"},{"line_number":207,"context_line":"                            self.public_ipv4 \u003d public_ip"},{"line_number":208,"context_line":"                            self.public_ipv4[\u0027type\u0027] \u003d\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"f00db7c6_79293434","line":205,"range":{"start_line":205,"start_character":40,"end_line":205,"end_character":47},"in_reply_to":"3b6dd894_a4841302","updated":"2025-08-14 00:19:05.000000000","message":"Acknowledged","commit_id":"202e21181fb57fa7b64ae4cba9a3ba178cdf0da9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3d74073e1958006639936fca2a37d9f3a070665c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    if \u0027publicIPAddress\u0027 in ip_config[\u0027properties\u0027]:"},{"line_number":203,"context_line":"                        public_ip \u003d ip_config[\u0027properties\u0027][\u0027publicIPAddress\u0027]"},{"line_number":204,"context_line":"                        ip_version \u003d (ip_config[\u0027properties\u0027]"},{"line_number":205,"context_line":"                                      [\u0027privateIPAddressVersion\u0027])"},{"line_number":206,"context_line":"                        if ip_version \u003d\u003d \u0027IPv4\u0027:"},{"line_number":207,"context_line":"                            self.public_ipv4 \u003d public_ip"},{"line_number":208,"context_line":"                            self.public_ipv4[\u0027type\u0027] \u003d\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"510ed364_68221237","line":205,"in_reply_to":"3b6dd894_a4841302","updated":"2025-08-14 00:16:45.000000000","message":"I think one part of the change is that azure doesn\u0027t give us the publicIPAddressVersion on the nic object any more.  But it\u0027s the same as the private ip.  So we can use that to figure out if the ip address we\u0027re looking at is private or public.","commit_id":"202e21181fb57fa7b64ae4cba9a3ba178cdf0da9"}]}