)]}'
{"nodepool/driver/aws/config.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ea40f7b7eabcfbf790ab90ee2033d3242c8090de","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                            \"import method\")"},{"line_number":113,"context_line":"        self.iops \u003d image.get(\u0027iops\u0027, None)"},{"line_number":114,"context_line":"        self.throughput \u003d image.get(\u0027throughput\u0027, None)"},{"line_number":115,"context_line":"        self.kms_key_id \u003d image.get(\u0027kms-key-id\u0027, None)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def external_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"921f3d96_3c2ffad9","line":115,"updated":"2025-09-03 23:55:50.000000000","message":"The release notes indicate that this is useful when using externally managed images which is why I assume we\u0027d associate the value with the provider disk image (which is an image that just happens to live on the provider aiui). This is all fine except that all of the testing and documentation seem to apply this at the label level. If this is an image attribute shouldn\u0027t we apply it to the image alone and then all labels using that image will automatically work?\n\nI think applying it to labels instead is fine its just likely to be more verbose than necessary.\n\nMaybe we should drop this configuration option if we stick with the label based approach. That way we avoid confusion over where it should be set and the docs will be aligned.","commit_id":"9cc682e61825e0dc31c7ee2f0c355d943f8200fd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"fce80f8fe0a5ca0908d6dd5795b1222492cee0df","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                            \"import method\")"},{"line_number":113,"context_line":"        self.iops \u003d image.get(\u0027iops\u0027, None)"},{"line_number":114,"context_line":"        self.throughput \u003d image.get(\u0027throughput\u0027, None)"},{"line_number":115,"context_line":"        self.kms_key_id \u003d image.get(\u0027kms-key-id\u0027, None)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def external_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"f3f92b7d_7481fd39","line":115,"in_reply_to":"921f3d96_3c2ffad9","updated":"2025-09-04 00:00:33.000000000","message":"Yep, this is an oversight and should be removed.  Because of the conflicting documentation, we need a lot more testing before we can add it to images.","commit_id":"9cc682e61825e0dc31c7ee2f0c355d943f8200fd"}]}