)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ef6a02a0d2e3de6b99a9eada489a8b0f11e6034e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68487c17_9b1a8962","updated":"2025-12-06 01:25:17.000000000","message":"A couple of inline comments for clarification of azure behavior mostly. I think the code should work if my assumptions are correct so I +2\u0027d it as is. But let me know if my assumptions are wrong.","commit_id":"9b5d22ffb9542a3ac0baf38479cf2780315c4afa"}],"nodepool/driver/azure/adapter.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ef6a02a0d2e3de6b99a9eada489a8b0f11e6034e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            if spot:"},{"line_number":46,"context_line":"                spot_cores \u003d int(cap[\u0027value\u0027])"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"                cores \u003d int(cap[\u0027value\u0027])"},{"line_number":49,"context_line":"        if cap[\u0027name\u0027] \u003d\u003d \u0027MemoryGB\u0027:"},{"line_number":50,"context_line":"            ram \u003d int(float(cap[\u0027value\u0027]) * 1024)"},{"line_number":51,"context_line":"    return QuotaInformation("}],"source_content_type":"text/x-python","patch_set":2,"id":"2eb77739_d85efb90","line":48,"updated":"2025-12-06 01:25:17.000000000","message":"Does the sku different for spot instances and non spot instances? If not aren\u0027t the spot_cores and cores values going to be the same? If that is the case should we go ahead and set both values or just use a single value?","commit_id":"9b5d22ffb9542a3ac0baf38479cf2780315c4afa"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4add832bcbf7952c54c328af0a0bfab81e9044f3","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            if spot:"},{"line_number":46,"context_line":"                spot_cores \u003d int(cap[\u0027value\u0027])"},{"line_number":47,"context_line":"            else:"},{"line_number":48,"context_line":"                cores \u003d int(cap[\u0027value\u0027])"},{"line_number":49,"context_line":"        if cap[\u0027name\u0027] \u003d\u003d \u0027MemoryGB\u0027:"},{"line_number":50,"context_line":"            ram \u003d int(float(cap[\u0027value\u0027]) * 1024)"},{"line_number":51,"context_line":"    return QuotaInformation("}],"source_content_type":"text/x-python","patch_set":2,"id":"01cfbc5a_95a9b018","line":48,"in_reply_to":"2eb77739_d85efb90","updated":"2025-12-08 18:48:03.000000000","message":"The sku (\u003d\u003dflavor) is the same, so we need to know whether we\u0027re using the sku for a spot or regular instance.  That\u0027s what the spot arg is for.  The QuotaInformation we return keeps them separate, and we compare it to the limits we query, which also keeps them separate.\n\nThe name of this method isn\u0027t great since it\u0027s now \"quota information from sku and intended usage\", but I don\u0027t think it\u0027s so bad we need to change it.","commit_id":"9b5d22ffb9542a3ac0baf38479cf2780315c4afa"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ef6a02a0d2e3de6b99a9eada489a8b0f11e6034e","unresolved":true,"context_lines":[{"line_number":440,"context_line":"            if item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027cores\u0027:"},{"line_number":441,"context_line":"                cores \u003d item[\u0027limit\u0027]"},{"line_number":442,"context_line":"            if item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027lowPriorityCores\u0027:"},{"line_number":443,"context_line":"                spot_cores \u003d item[\u0027limit\u0027]"},{"line_number":444,"context_line":"            elif item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027virtualMachines\u0027:"},{"line_number":445,"context_line":"                instances \u003d item[\u0027limit\u0027]"},{"line_number":446,"context_line":"        return QuotaInformation(cores\u003dcores,"}],"source_content_type":"text/x-python","patch_set":2,"id":"64e6c83d_32ba7cbd","line":443,"updated":"2025-12-06 01:25:17.000000000","message":"Re my question above it does look like we count cores differently for spot instances so having distinct values makes sense. I guess the main question is if the sku differs for spot instances (I guess it should since it behaves differently).","commit_id":"9b5d22ffb9542a3ac0baf38479cf2780315c4afa"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"4add832bcbf7952c54c328af0a0bfab81e9044f3","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027cores\u0027:"},{"line_number":441,"context_line":"                cores \u003d item[\u0027limit\u0027]"},{"line_number":442,"context_line":"            if item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027lowPriorityCores\u0027:"},{"line_number":443,"context_line":"                spot_cores \u003d item[\u0027limit\u0027]"},{"line_number":444,"context_line":"            elif item[\u0027name\u0027][\u0027value\u0027] \u003d\u003d \u0027virtualMachines\u0027:"},{"line_number":445,"context_line":"                instances \u003d item[\u0027limit\u0027]"},{"line_number":446,"context_line":"        return QuotaInformation(cores\u003dcores,"}],"source_content_type":"text/x-python","patch_set":2,"id":"868f466b_7af75721","line":443,"in_reply_to":"64e6c83d_32ba7cbd","updated":"2025-12-08 18:48:03.000000000","message":"Hopefully answered above; if not let\u0027s continue there.","commit_id":"9b5d22ffb9542a3ac0baf38479cf2780315c4afa"}]}