)]}'
{"releasenotes/notes/fix_initialization_issues-17943af42dd7343b.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f359811d2cc4c0fc740d43afea962526d5d6aea1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add various fixes related to the initial code move and refactor from zuul:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_f8f3b671","line":1,"updated":"2020-09-22 16:06:15.000000000","message":"This file doesn\u0027t seems to be rendered, could you please add such file to the doc index https://opendev.org/zuul/zuul/raw/branch/master/doc/source/reference/releasenotes.rst (and this requirements: https://opendev.org/zuul/zuul/src/branch/master/doc/requirements.txt#L7 )","commit_id":"78d9cb64dba2aae0391acae7a97bc5895d8de68b"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5ece9bd4ead2081e5784e9f1614a72f31531ddfe","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    * the default location config files for `App` objects is set in a class"},{"line_number":7,"context_line":"      attribute"},{"line_number":8,"context_line":"    * Add the missing zuulclient/__init__.py file"},{"line_number":9,"context_line":"    * Fix an misnamed argument used when calling the `promote` endpoint."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_c7fea104","line":9,"updated":"2020-09-24 15:26:37.000000000","message":"We use release notes to convey important information about changes to end users.  Keeping the signal to noise ratio high means they are more likely to read the notes.  I don\u0027t think we have anything important to convey at this point.  I suspect you may have added this just to get the framework in place.  If so, I think it\u0027s fine to keep it, but let\u0027s just change it to \"Made initial release\" so we\u0027re not establishing a precedent that we\u0027re going to duplicate the git commit log in release notes.","commit_id":"799ca4841b25e8527e5020aa849cda63baadc3b3"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"4bce0405de460ab408955cb37eaa20e6774a2610","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    * the default location config files for `App` objects is set in a class"},{"line_number":7,"context_line":"      attribute"},{"line_number":8,"context_line":"    * Add the missing zuulclient/__init__.py file"},{"line_number":9,"context_line":"    * Fix an misnamed argument used when calling the `promote` endpoint."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_c26def2f","line":9,"in_reply_to":"9f560f44_c7fea104","updated":"2020-09-24 16:02:09.000000000","message":"Done","commit_id":"799ca4841b25e8527e5020aa849cda63baadc3b3"}],"tests/unit/test_api.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f78e456657fd218f1ef07c377da1e2ab6d4d52e6","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            \u0027https://fake.zuul/api/tenant/tenant1/promote\u0027,"},{"line_number":281,"context_line":"            json\u003d{\u0027changes\u0027: [\u00271,1\u0027, \u00272,1\u0027],"},{"line_number":282,"context_line":"                  \u0027pipeline\u0027: \u0027check\u0027}"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        self.assertEqual(True, prom)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0bee5bec","line":283,"updated":"2020-09-17 19:08:20.000000000","message":"It\u0027s worth noting that this bug is not exposed by this test, which is why we generally avoid unit tests with mocks.  The bug was only found with actual integration testing.\n\nYou may want to reduce reliance on unit tests here (just exercise basic functionality) and rely more on functional integration tests since that\u0027s what we really care about.  That way people don\u0027t have to write every test twice.","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"32c59830067b5678dffe5e3a23e50a86eda67fe8","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            \u0027https://fake.zuul/api/tenant/tenant1/promote\u0027,"},{"line_number":281,"context_line":"            json\u003d{\u0027changes\u0027: [\u00271,1\u0027, \u00272,1\u0027],"},{"line_number":282,"context_line":"                  \u0027pipeline\u0027: \u0027check\u0027}"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        self.assertEqual(True, prom)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_61426a3d","line":283,"in_reply_to":"9f560f44_0bee5bec","updated":"2020-09-21 19:26:31.000000000","message":"+1, perhaps as a follow-up?","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"f4956ac59f9481b6d260fa2643cc168c67d3b88f","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            \u0027https://fake.zuul/api/tenant/tenant1/promote\u0027,"},{"line_number":281,"context_line":"            json\u003d{\u0027changes\u0027: [\u00271,1\u0027, \u00272,1\u0027],"},{"line_number":282,"context_line":"                  \u0027pipeline\u0027: \u0027check\u0027}"},{"line_number":283,"context_line":"        )"},{"line_number":284,"context_line":"        self.assertEqual(True, prom)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3c79ab81","line":283,"in_reply_to":"9f560f44_61426a3d","updated":"2020-09-22 09:25:43.000000000","message":"handled here: https://review.opendev.org/#/c/751264/","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"}],"zuulclient/__init__.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"32c59830067b5678dffe5e3a23e50a86eda67fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_81305eeb","line":14,"updated":"2020-09-21 19:26:31.000000000","message":"Do we need a license header for an empty file?","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"f4956ac59f9481b6d260fa2643cc168c67d3b88f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_9c89d770","line":14,"in_reply_to":"9f560f44_81305eeb","updated":"2020-09-22 09:25:43.000000000","message":"I put it in every file, even empty ones, for consistency","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"}],"zuulclient/cmd/__init__.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"32c59830067b5678dffe5e3a23e50a86eda67fe8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    app_name \u003d \u0027zuul-client\u0027"},{"line_number":25,"context_line":"    app_description \u003d \u0027Zuul User CLI\u0027"},{"line_number":26,"context_line":"    log \u003d logging.getLogger(\"zuul-client\")"},{"line_number":27,"context_line":"    default_config_locations \u003d [\u0027~/.zuul.conf\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def createParser(self):"},{"line_number":30,"context_line":"        parser \u003d super(ZuulClient, self).createParser()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_213cf2bd","line":27,"updated":"2020-09-21 19:26:31.000000000","message":"Why is the config locations defined here too?","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"f4956ac59f9481b6d260fa2643cc168c67d3b88f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    app_name \u003d \u0027zuul-client\u0027"},{"line_number":25,"context_line":"    app_description \u003d \u0027Zuul User CLI\u0027"},{"line_number":26,"context_line":"    log \u003d logging.getLogger(\"zuul-client\")"},{"line_number":27,"context_line":"    default_config_locations \u003d [\u0027~/.zuul.conf\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def createParser(self):"},{"line_number":30,"context_line":"        parser \u003d super(ZuulClient, self).createParser()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_dc9eafb6","line":27,"in_reply_to":"9f560f44_213cf2bd","updated":"2020-09-22 09:25:43.000000000","message":"This is due to the code refactor, which is removed in a subsequent patch","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"}],"zuulclient/common/client.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"32c59830067b5678dffe5e3a23e50a86eda67fe8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    app_name \u003d None  # type: str"},{"line_number":31,"context_line":"    app_description \u003d None  # type: str"},{"line_number":32,"context_line":"    default_config_locations \u003d [\u0027/etc/zuul/zuul.conf\u0027,"},{"line_number":33,"context_line":"                                \u0027~/zuul.conf\u0027,"},{"line_number":34,"context_line":"                                \u0027~/.zuul.conf\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_c14b765c","line":33,"updated":"2020-09-21 19:26:31.000000000","message":"Is `~/zuul.conf` relevant?","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"066abac907ce9c26f529a5f7eb644dda42d5f836","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    app_name \u003d None  # type: str"},{"line_number":31,"context_line":"    app_description \u003d None  # type: str"},{"line_number":32,"context_line":"    default_config_locations \u003d [\u0027/etc/zuul/zuul.conf\u0027,"},{"line_number":33,"context_line":"                                \u0027~/zuul.conf\u0027,"},{"line_number":34,"context_line":"                                \u0027~/.zuul.conf\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4172c67d","line":33,"in_reply_to":"9f560f44_c14b765c","updated":"2020-09-21 19:34:26.000000000","message":"Nevermind, a followup change remove that file.","commit_id":"774465eb692c13947dad34c3aa2a34a1999bdff4"}]}