)]}'
{".zuul.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"eabef7d4509a4aef333a266dac08f4246e53b23a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: zuul-operator-functional-k8s"},{"line_number":5,"context_line":"    pre-run: playbooks/zuul-operator-functional-k8s/pre.yaml"},{"line_number":6,"context_line":"    run: playbooks/zuul-operator-functional-k8s/run.yaml"},{"line_number":7,"context_line":"    post-run: playbooks/zuul-operator-functional-k8s/run.yaml"},{"line_number":8,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - zuul/zuul-operator"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_d3b5457f","line":7,"updated":"2019-06-28 21:35:48.000000000","message":"I think you may have meant to set this to \u0027post.yaml\u0027.  But if you fix that, you\u0027ll probably find that Ansible doesn\u0027t like empty playbook files, so the best thing to do may be to remove this line and delete the file for now, until we need it.","commit_id":"e60138f3aa998b344980bcb65bf5a7cab7c360c8"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: zuul-operator-functional-k8s"},{"line_number":5,"context_line":"    pre-run: playbooks/zuul-operator-functional-k8s/pre.yaml"},{"line_number":6,"context_line":"    run: playbooks/zuul-operator-functional-k8s/run.yaml"},{"line_number":7,"context_line":"    post-run: playbooks/zuul-operator-functional-k8s/run.yaml"},{"line_number":8,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - zuul/zuul-operator"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_0a385bec","line":7,"in_reply_to":"9fb8cfa7_d3b5457f","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"e60138f3aa998b344980bcb65bf5a7cab7c360c8"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9c58d102be5df644b0fd9c51e25c01b91e00cc87","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        - zuul-operator-functional-k8s"},{"line_number":16,"context_line":"    gate:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - noop"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_1681ef8f","line":18,"updated":"2019-07-11 18:11:00.000000000","message":"Go ahead and add it to gate, then we won\u0027t be able to break this.  :)","commit_id":"4e8f21158a8a8384933219c7296396db981f8255"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"a72721004a82c52086cde31b7b54e560b19d0aa6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    description: |"},{"line_number":3,"context_line":"      Test that zuul-operator works in Kubernetes (currently debugging use)"},{"line_number":4,"context_line":"    name: zuul-operator-functional-k8s"},{"line_number":5,"context_line":"    pre-run: playbooks/zuul-operator-functional-k8s/pre.yaml"},{"line_number":6,"context_line":"    run: playbooks/zuul-operator-functional-k8s/run.yaml"},{"line_number":7,"context_line":"    post-run: playbooks/zuul-operator-functional-k8s/post.yaml"},{"line_number":8,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - zuul/zuul-operator"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- project:"},{"line_number":13,"context_line":"    check:"},{"line_number":14,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_91dde943","line":11,"range":{"start_line":1,"start_character":2,"end_line":11,"end_character":0},"updated":"2019-07-11 18:48:40.000000000","message":"The nodeset \"ubuntu-xenial\" was not found.","commit_id":"3fd7d1f550872563ff172317cf3634909d6d9f29"}],"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9c58d102be5df644b0fd9c51e25c01b91e00cc87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeff Liu \u003cjeliu@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-11 11:49:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create tasks that spin up kubernetes and run the operator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idf677621cf178b3af9975bbd22fbfe0d30df7ee5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7faddb67_7672a3e5","line":7,"updated":"2019-07-11 18:11:00.000000000","message":"Maybe add a paragraph about what this job does so far.","commit_id":"4e8f21158a8a8384933219c7296396db981f8255"}],"playbooks/zuul-operator-functional-k8s/post.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9c58d102be5df644b0fd9c51e25c01b91e00cc87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  -tasks: "},{"line_number":5,"context_line":"    - name: Get pods  "},{"line_number":6,"context_line":"      command: kubectl get pods"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_367c2bb4","line":4,"updated":"2019-07-11 18:11:00.000000000","message":"Typo here:\n  tasks:","commit_id":"4e8f21158a8a8384933219c7296396db981f8255"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"73f1bf0eeb6d5e47cb101a8719e369865b5b08a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  -tasks: "},{"line_number":5,"context_line":"    - name: Get pods  "},{"line_number":6,"context_line":"      command: kubectl get pods"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_76686320","line":4,"updated":"2019-07-11 18:03:20.000000000","message":"Typo here:\n  tasks:","commit_id":"4e8f21158a8a8384933219c7296396db981f8255"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e0b10eaa04d5b5dd614e6f5614fa37df74df905","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  tasks: "},{"line_number":5,"context_line":"    - name: Get pods  "},{"line_number":6,"context_line":"      command: kubectl get pods"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_99af4f7c","line":5,"updated":"2019-07-11 22:29:38.000000000","message":"It\u0027s not a big deal, but if you end up making another patch, you might as well remove the trailing whitespace on these 2 lines.","commit_id":"3fd7d1f550872563ff172317cf3634909d6d9f29"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"edd8cb0162a8e1815eed63ef0131e7456317a9c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_c46b8c1b","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":53},"updated":"2019-07-12 17:25:39.000000000","message":"This appears to be a copy paste mistake. SHould probably say \"get all k8s pods\" or similar. Not worth a -1 can be cleaned up in a followup.","commit_id":"aafaeab6609e3eea09a399308ef3fc658eba7509"}],"playbooks/zuul-operator-functional-k8s/pre.yaml":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  "},{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - role: bindep"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_f3b92e15","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":13},"updated":"2019-07-03 14:36:25.000000000","message":"Rather then making this global to all tasks, we should add it to the specific tasks that need sudo permissions.","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  "},{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - role: bindep"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_46309208","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":13},"in_reply_to":"9fb8cfa7_f3b92e15","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  "},{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - role: bindep"},{"line_number":7,"context_line":"    - role: install-kubernetes"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b33976a4","line":4,"updated":"2019-07-03 14:36:25.000000000","message":"red blob","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: start kubernetes and install all dependencies"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  "},{"line_number":5,"context_line":"  roles:"},{"line_number":6,"context_line":"    - role: bindep"},{"line_number":7,"context_line":"    - role: install-kubernetes"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_66358ef7","line":4,"in_reply_to":"9fb8cfa7_b33976a4","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      args:"},{"line_number":14,"context_line":"        chdir: $GOPATH/src/"},{"line_number":15,"context_line":"        creates: $GOPATH/src/github.com/operator-framework/operator-sdk/"},{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_d3518adb","line":16,"updated":"2019-07-03 14:36:25.000000000","message":"Do you mind adding name here, to explain the task. It is helpful when looking at playbooks to understand what the task is doing.","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      args:"},{"line_number":14,"context_line":"        chdir: $GOPATH/src/"},{"line_number":15,"context_line":"        creates: $GOPATH/src/github.com/operator-framework/operator-sdk/"},{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_263f96d7","line":16,"in_reply_to":"9fb8cfa7_d3518adb","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        chdir: $GOPATH/src/"},{"line_number":15,"context_line":"        creates: $GOPATH/src/github.com/operator-framework/operator-sdk/"},{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"},{"line_number":20,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_935d52ee","line":17,"updated":"2019-07-03 14:36:25.000000000","message":"same","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        chdir: $GOPATH/src/"},{"line_number":15,"context_line":"        creates: $GOPATH/src/github.com/operator-framework/operator-sdk/"},{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"},{"line_number":20,"context_line":"      unarchive:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_c62322be","line":17,"in_reply_to":"9fb8cfa7_935d52ee","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"87b5c02e43a31a6b3a30bfb5d677ffda3cd2795d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"},{"line_number":20,"context_line":"      unarchive:"},{"line_number":21,"context_line":"        src: \"https://github.com/openshift/origin/releases/download/v3.11.0/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit.tar.gz\" # hard coded version change later"},{"line_number":22,"context_line":"        dest: \"~/Downloads\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_d3a98a7c","line":19,"updated":"2019-07-03 14:42:58.000000000","message":"I know Tristan was using openshift, but I think we want to test this with plain k8s to start with (we\u0027ll probably add a second job to test openshift later).  I think you should be able to omit this, and I assume that the install-kubernetes role will have installed a kubectl that we can use.  The \"oc\" commands in the README should have equivalent \"kubectl\" commands.\n\nAlso, there\u0027s a trick I do sometimes when I\u0027m developing a pre-playbook like this -- while I\u0027m working on it, I tell Zuul it\u0027s the \"run\" playbook.  That\u0027s because Zuul will retry the job 3 times if the pre-playbook fails.  So I do my work in the run playbook until I\u0027m sure it\u0027s working right, that way if there\u0027s an error, Zuul won\u0027t keep retrying it.  Then once it\u0027s good, I move it to pre-run.","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - command: make dep"},{"line_number":17,"context_line":"    - command: make install"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Download and unpack Openshift Client Tools directly from HTTP source"},{"line_number":20,"context_line":"      unarchive:"},{"line_number":21,"context_line":"        src: \"https://github.com/openshift/origin/releases/download/v3.11.0/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit.tar.gz\" # hard coded version change later"},{"line_number":22,"context_line":"        dest: \"~/Downloads\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_ee4e2537","line":19,"in_reply_to":"9fb8cfa7_d3a98a7c","updated":"2019-07-11 18:14:56.000000000","message":"Thanks I\u0027ll try it out","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        dest: \"~/Downloads\""},{"line_number":23,"context_line":"        copy: no"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_930232ba","line":25,"updated":"2019-07-03 14:36:25.000000000","message":"quotes shouldn\u0027t be needed","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        dest: \"~/Downloads\""},{"line_number":23,"context_line":"        copy: no"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_862d2aaa","line":25,"in_reply_to":"9fb8cfa7_930232ba","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        copy: no"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_336ee696","line":26,"updated":"2019-07-03 14:36:25.000000000","message":"We should line break these task attributes for readability.","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        copy: no"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_46197286","line":26,"in_reply_to":"9fb8cfa7_336ee696","updated":"2019-07-11 18:14:56.000000000","message":"Done","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b30736ca","line":27,"updated":"2019-07-03 14:36:25.000000000","message":"same","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - name: Changing perm of \"kubectl\", adding \"+x\""},{"line_number":26,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/kubectl\" mode\u003da+x"},{"line_number":27,"context_line":"    - name: Changing perm of \"oc\", adding \"+x\""},{"line_number":28,"context_line":"      file: dest\u003d~/Downloads/openshift-origin-client-tools-v3.11.0-0cbc58b-linux-64bit/oc\" mode\u003da+x"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_d36aea7f","line":28,"updated":"2019-07-03 14:36:25.000000000","message":"same","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"}],"playbooks/zuul-operator-functional-k8s/run.yaml":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: install and start zuul operator"},{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  tasks:     "},{"line_number":6,"context_line":"  - debug:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_b33096a0","line":3,"updated":"2019-07-03 14:36:25.000000000","message":"lets remove, shouldn\u0027t be needed","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  hosts: all"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  tasks:     "},{"line_number":6,"context_line":"  - debug:"},{"line_number":7,"context_line":"    msg: Hello world!"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_732a1e2d","line":5,"updated":"2019-07-03 14:36:25.000000000","message":"blob","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"640c871cb7f930e3cee7f6663ce913006a852e96","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  tasks:     "},{"line_number":6,"context_line":"  - debug:"},{"line_number":7,"context_line":"    msg: Hello world!"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fb8cfa7_331ca612","line":7,"updated":"2019-07-03 14:36:25.000000000","message":"this needs indentation","commit_id":"5897711a2dc41f18634e490ad661948e8e9db3a0"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0ea73c4297588b36a4060bf54d204fd4f9aaaefe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Download Operator SDK Binary Release"},{"line_number":6,"context_line":"      environment:"},{"line_number":7,"context_line":"        RELEASE_VERSION: v0.8.1"},{"line_number":8,"context_line":"      get_url:"},{"line_number":9,"context_line":"        url: https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu"},{"line_number":10,"context_line":"        dest: ~/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_757d32e6","line":7,"updated":"2019-07-03 21:55:28.000000000","message":"This release version will only be expanded into your strings below if those strings are interpolated by a shell. The get_url and command tasks don\u0027t spawn a shell first which is why this is failing.\n\nInstead what you can do is declare a fact using set_fact at the beginning of this playbook then have ansible interpolate that value in to the strings below.\n\nRoughly:\n\n  tasks:\n    - name: Set Operator SDK version fact\n      set_fact:\n        operator_sdk_version: v0.8.1\n\n    - name Download...\n      get_url:\n        url: https://github.com/operator-framework/operator-sdk/releases/download/{{ operator_sdk_version }}/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu\n\nAnsible will interpolate strings within {{ }} via jinja2 template expansion.","commit_id":"8ed42d4b86b70b97cc5ae2ef729abd1fabff8029"},{"author":{"_account_id":30610,"name":"Jeff Liu","email":"jeliu@redhat.com","username":"jeffliu"},"change_message_id":"fec011466a0dff9aa37d99f3ff8aefc96b14bff4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Download Operator SDK Binary Release"},{"line_number":6,"context_line":"      environment:"},{"line_number":7,"context_line":"        RELEASE_VERSION: v0.8.1"},{"line_number":8,"context_line":"      get_url:"},{"line_number":9,"context_line":"        url: https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu"},{"line_number":10,"context_line":"        dest: ~/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_44bfedfa","line":7,"in_reply_to":"7faddb67_757d32e6","updated":"2019-07-11 18:14:56.000000000","message":"Thanks! I\u0027ll try that out","commit_id":"8ed42d4b86b70b97cc5ae2ef729abd1fabff8029"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e0afd40072490f2c59b981d749fbc97b63ed5bb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        var: dir_out"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - debug:"},{"line_number":25,"context_line":"      var: dir_out_2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    - name: Copy release binary to path"},{"line_number":28,"context_line":"      command: cp /home/zuul/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu /usr/local/bin/operator-sdk"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_6e03e774","line":25,"updated":"2019-07-08 20:29:55.000000000","message":"This needs to be indented (otherwise in yaml, var doesn\u0027t end up being a key under debug)","commit_id":"5930e44cab9c5f680af5c70c4624410925f44dd9"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"2cb45d7309eaa786c0a47260dc838531901d1578","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      set_fact:"},{"line_number":7,"context_line":"        RELEASE_VERSION: v0.8.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - name: Download Operator SDK Binary Release"},{"line_number":10,"context_line":"      get_url:"},{"line_number":11,"context_line":"        url: https://github.com/operator-framework/operator-sdk/releases/download/{{ RELEASE_VERSION }}/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu"},{"line_number":12,"context_line":"        dest: ~/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu"},{"line_number":13,"context_line":"        mode: a+x"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    - name: Copy release binary to path"},{"line_number":16,"context_line":"      command: cp /home/zuul/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu /usr/local/bin/operator-sdk"},{"line_number":17,"context_line":"      become: yes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Remove original"},{"line_number":20,"context_line":"      command: rm ~/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Find All directories in the home directory"},{"line_number":23,"context_line":"      find:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_483b549b","line":20,"range":{"start_line":9,"start_character":0,"end_line":20,"end_character":71},"updated":"2019-07-10 21:29:37.000000000","message":"this could be simplified of you get_url directly to final destination on line 12.","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5b3b2e940ff2945d9e9df67b9b6a8f5a5fbc3276","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        recurse: yes"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Build operator"},{"line_number":29,"context_line":"      command: operator-sdk build quay.io/operator-framework/ansible-operator:v0.6.0"},{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_ea9b0ac6","line":29,"updated":"2019-07-11 14:30:03.000000000","message":"I think here you\u0027re giving operator-sdk the name of the image that we want to build.  I think for this we just want to call it \"zuul/zuul-operator\".","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"04c330761ce5f13caf5a71dbb55e3b7351a4b81a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - name: Build operator"},{"line_number":29,"context_line":"      command: operator-sdk build quay.io/operator-framework/ansible-operator:v0.6.0"},{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Push"},{"line_number":34,"context_line":"      command: docker push 172.30.1.1:5000/myproject/zuul-operator:latest"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_fd3196a3","line":31,"updated":"2019-07-11 15:19:47.000000000","message":"That\u0027s true, but thinking ahead, we may want to run this job on changes to other repos, so we probably don\u0027t want to use zuul.project.src_dir.  We could do \"{{ zuul.projects[\u0027opendev.org/zuul/zuul-operator\u0027].src_dir }}\" however.","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"2cb45d7309eaa786c0a47260dc838531901d1578","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - name: Build operator"},{"line_number":29,"context_line":"      command: operator-sdk build quay.io/operator-framework/ansible-operator:v0.6.0"},{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Push"},{"line_number":34,"context_line":"      command: docker push 172.30.1.1:5000/myproject/zuul-operator:latest"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_88fe2cac","line":31,"updated":"2019-07-10 21:29:37.000000000","message":"you can remove hardcoded /home/zuul and use ansible_user_dir. EG:\n\n  chdir: {{ ansible_user_dir }}/src/opendev.org/zuul/zuul-operator\n\nHowever, it is likely better to just use:\n\n  chdir: {{ zuul.project.src_dir }}\n\nas that will be src/opendev.org/zuul/zuul-operator, run from the ~ dir, in this case /home/zuul.","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5b3b2e940ff2945d9e9df67b9b6a8f5a5fbc3276","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      args:"},{"line_number":31,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - name: Push"},{"line_number":34,"context_line":"      command: docker push 172.30.1.1:5000/myproject/zuul-operator:latest"},{"line_number":35,"context_line":"      args:"},{"line_number":36,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_0a9f86b4","line":33,"updated":"2019-07-11 14:30:03.000000000","message":"I think we can try skipping this step.  Since we\u0027re building this on the same VM that\u0027s running k8s, we shouldn\u0027t have to push it anywhere.  I think k8s will just use it from the local image cache.","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5b3b2e940ff2945d9e9df67b9b6a8f5a5fbc3276","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    - name: Setup Operator"},{"line_number":49,"context_line":"      command: kubectl create -f deploy/operator.yaml"},{"line_number":50,"context_line":"      args:"},{"line_number":51,"context_line":"        chdir: /home/zuul/src/opendev.org/zuul/zuul-operator/"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_aaa51206","line":49,"updated":"2019-07-11 14:30:03.000000000","message":"You\u0027re going to need to edit this file.  On these lines:\n\nhttps://opendev.org/zuul/zuul-operator/src/branch/master/deploy/operator.yaml#L24\nhttps://opendev.org/zuul/zuul-operator/src/branch/master/deploy/operator.yaml#L31\n\nyou\u0027ll need to change the image location to just \"zuul/zuul-operator\".","commit_id":"890e54aaca6c4431de768f6b20cbd2c8a1ebb4a9"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e0b10eaa04d5b5dd614e6f5614fa37df74df905","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      get_url:"},{"line_number":12,"context_line":"        url: https://github.com/operator-framework/operator-sdk/releases/download/{{ RELEASE_VERSION }}/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu"},{"line_number":13,"context_line":"        dest: /usr/local/bin/operator-sdk"},{"line_number":14,"context_line":"        mode: a+x"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: Find All directories in the home directory"},{"line_number":17,"context_line":"      find:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_b9b48bd2","line":14,"updated":"2019-07-11 22:29:38.000000000","message":"This is fine for now, but I\u0027d like to see if there are alternatives.\n\nLooking into the sdk, I don\u0027t think we\u0027re actually getting much out of it.  I think we may actually be able to skip this and just run:\n\n  docker build -f build/Dockerfile -t zuul/zuul-operator\n\nLet\u0027s go ahead and merge this as-is, and try ^ that out in a followup patch.","commit_id":"3fd7d1f550872563ff172317cf3634909d6d9f29"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e0b10eaa04d5b5dd614e6f5614fa37df74df905","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      find:"},{"line_number":18,"context_line":"        paths: /home/zuul/"},{"line_number":19,"context_line":"        file_type: directory"},{"line_number":20,"context_line":"        recurse: yes"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: Build operator"},{"line_number":23,"context_line":"      command: operator-sdk build zuul/zuul-operator"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_59cd5764","line":20,"updated":"2019-07-11 22:29:38.000000000","message":"This may have been for debugging; we can probably drop it now?","commit_id":"3fd7d1f550872563ff172317cf3634909d6d9f29"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"7dd6ce76234e10a91d8b2d546f6c937d2b7fc73f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      get_url:"},{"line_number":12,"context_line":"        url: https://github.com/operator-framework/operator-sdk/releases/download/{{ RELEASE_VERSION }}/operator-sdk-{{ RELEASE_VERSION }}-x86_64-linux-gnu"},{"line_number":13,"context_line":"        dest: /usr/local/bin/operator-sdk"},{"line_number":14,"context_line":"        mode: a+x"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    - name: Build operator"},{"line_number":17,"context_line":"      command: operator-sdk build zuul/zuul-operator"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_2cce0c2e","line":14,"updated":"2019-07-12 14:59:21.000000000","message":"I left a comment on the previous PS about this -- I think this is fine for now and we should merge it, but we also have some ideas about how to improve this so we don\u0027t end up downloading from github everytime we run this job.","commit_id":"aafaeab6609e3eea09a399308ef3fc658eba7509"}],"playbooks/zuul-operator-functional-k8s/run_archive.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e065e1063f171d407f8e4dd562043d170760400b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7faddb67_809355a3","updated":"2019-07-11 15:58:14.000000000","message":"you don\u0027t need to add files like this to the commit -- gerrit lets you easily see and fetch earlier versions of commits, so you can see the old version at https://review.opendev.org/#/c/668029/15 (see the \"Patch Sets\" drop down in the top right).","commit_id":"4e8f21158a8a8384933219c7296396db981f8255"}]}