)]}'
{"roles/zuul-restart-when-zuul-conf-changed/library/dump_zuul_changes.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"09f03edf445be8674bc177cae2b479a59d7e7849","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for tenant in gearlib.run(client, \"zuul:tenant_list\"):"},{"line_number":24,"context_line":"        name \u003d tenant[\u0027name\u0027]"},{"line_number":25,"context_line":"        queues[name] \u003d gearlib.run(client, \"zuul:status_get\", {\"tenant\": name})"},{"line_number":26,"context_line":"    return queues"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ansible_main():"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_4935d3a6","line":26,"updated":"2020-02-03 17:41:48.000000000","message":"Do we use gearman for this rather than http because the load side needs to use gearman?\n\nSeparately, I wonder if we need to tag pipelines as reloadable. Some jobs are not safe to reload due to side effects and because this queue dump and load will restart even finished jobs that gets tricky.","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"9a38e6f72716936654028c08247a9f234152b56e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for tenant in gearlib.run(client, \"zuul:tenant_list\"):"},{"line_number":24,"context_line":"        name \u003d tenant[\u0027name\u0027]"},{"line_number":25,"context_line":"        queues[name] \u003d gearlib.run(client, \"zuul:status_get\", {\"tenant\": name})"},{"line_number":26,"context_line":"    return queues"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ansible_main():"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_c91a237f","line":26,"in_reply_to":"3fa7e38b_4935d3a6","updated":"2020-02-03 18:11:44.000000000","message":"It\u0027s also faster to list tenant and dump the status using one gearman connection rather than requesting multiple http url.\n\nI agree the status dump/reload is broken for some queue, not sure that is something we can fix in the zuul-operator.","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"}],"roles/zuul-restart-when-zuul-conf-changed/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"09f03edf445be8674bc177cae2b479a59d7e7849","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    services:"},{"line_number":14,"context_line":"        - kind: StatefulSet"},{"line_number":15,"context_line":"          name: \"{{ zuul_name }}-scheduler\""},{"line_number":16,"context_line":"        - kind: StatefulSet"},{"line_number":17,"context_line":"          name: \"{{ zuul_name }}-executor\""},{"line_number":18,"context_line":"        - kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_c940e307","line":15,"updated":"2020-02-03 17:41:48.000000000","message":"Is the scheduler a stateful service? I thought all of the state not managed in memory was contained in zk and git repos in the mergers and executors?","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"046de2fefe4fe8a33644fbad4bbb61fd064628bc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    services:"},{"line_number":14,"context_line":"        - kind: StatefulSet"},{"line_number":15,"context_line":"          name: \"{{ zuul_name }}-scheduler\""},{"line_number":16,"context_line":"        - kind: StatefulSet"},{"line_number":17,"context_line":"          name: \"{{ zuul_name }}-executor\""},{"line_number":18,"context_line":"        - kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_f46812bd","line":15,"in_reply_to":"3fa7e38b_69276fca","updated":"2020-02-03 18:16:46.000000000","message":"Good point. I guess that could be managed as a secret since the data is fairly static? Might also help with rolling keys out, but probably best to handle that as a v2 operator feature rather than in the first pass.","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"9a38e6f72716936654028c08247a9f234152b56e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    services:"},{"line_number":14,"context_line":"        - kind: StatefulSet"},{"line_number":15,"context_line":"          name: \"{{ zuul_name }}-scheduler\""},{"line_number":16,"context_line":"        - kind: StatefulSet"},{"line_number":17,"context_line":"          name: \"{{ zuul_name }}-executor\""},{"line_number":18,"context_line":"        - kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_69276fca","line":15,"in_reply_to":"3fa7e38b_c940e307","updated":"2020-02-03 18:11:44.000000000","message":"the /var/lib/zuul/keys need to persist iiuc.","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"d74e88c60d6badffefa6d9a50f4f81e7f8e886f3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    services:"},{"line_number":14,"context_line":"        - kind: StatefulSet"},{"line_number":15,"context_line":"          name: \"{{ zuul_name }}-scheduler\""},{"line_number":16,"context_line":"        - kind: StatefulSet"},{"line_number":17,"context_line":"          name: \"{{ zuul_name }}-executor\""},{"line_number":18,"context_line":"        - kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_349a2a75","line":15,"in_reply_to":"3fa7e38b_f46812bd","updated":"2020-02-03 18:39:01.000000000","message":"Yes, a follow-up should add a role to backup the scheduler key in a secret. That could be performed each time the tenant configuration changes, and when adding a \u0027ZuulBackup\u0027 crd to let admin backup the service.","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"}],"roles/zuul/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"09f03edf445be8674bc177cae2b479a59d7e7849","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- include_role:"},{"line_number":37,"context_line":"    name: zuul-restart-when-zuul-conf-changed"},{"line_number":38,"context_line":"  when: zuul_conf_secret.data is defined"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_69144feb","line":38,"updated":"2020-02-03 17:41:48.000000000","message":"Will this start zuul twice on initial creation? The apply objects above will start services, then we\u0027ll restart them here?","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"9a38e6f72716936654028c08247a9f234152b56e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- include_role:"},{"line_number":37,"context_line":"    name: zuul-restart-when-zuul-conf-changed"},{"line_number":38,"context_line":"  when: zuul_conf_secret.data is defined"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_c9030311","line":38,"in_reply_to":"3fa7e38b_69144feb","updated":"2020-02-03 18:11:44.000000000","message":"That shouldn\u0027t happen on initial creation because the zuul_conf_secret.data shouldn\u0027t be defined (it\u0027s lookup L4, and created L29)","commit_id":"96ac18c60d0da8c54958fffec988bec3a7ac329e"}]}