)]}'
{"build/Dockerfile":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"914cb0c4db00eee1e81cccea420664f3c2d9ed2a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# unarchive: bzip2 and tar"},{"line_number":11,"context_line":"# generate zuul ssh-keys or certificate: openssh and openssl"},{"line_number":12,"context_line":"# manage configuration: git"},{"line_number":13,"context_line":"# fix for https://github.com/operator-framework/operator-sdk/issues/2204 : kubectl"},{"line_number":14,"context_line":"RUN dnf install -y bzip2 tar openssh openssl git http://mirror.centos.org/centos/7/os/x86_64/Packages/bash-completion-2.1-6.el7.noarch.rpm http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin/origin-clients-3.11.0-1.el7.git.0.62803d0.x86_64.rpm"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Install dhall-to-json"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3fa7e38b_15407304","line":13,"updated":"2020-01-30 17:30:32.000000000","message":"Wow that rabbit hole goes deep.  Anyway, it looks like there\u0027s good progress on this and hopefully we won\u0027t have to carry this module too much longer.  Thanks for that.","commit_id":"2f7b1c64fff14f415660b2876acf3ec62d2a195e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9652fb49453c31238d6b32444a8d2f82a03cf1f5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# unarchive: bzip2 and tar"},{"line_number":11,"context_line":"# generate zuul ssh-keys or certificate: openssh and openssl"},{"line_number":12,"context_line":"# manage configuration: git"},{"line_number":13,"context_line":"# fix for https://github.com/operator-framework/operator-sdk/issues/2204 : kubectl"},{"line_number":14,"context_line":"RUN dnf install -y bzip2 tar openssh openssl git http://mirror.centos.org/centos/7/os/x86_64/Packages/bash-completion-2.1-6.el7.noarch.rpm http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin/origin-clients-3.11.0-1.el7.git.0.62803d0.x86_64.rpm"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Install dhall-to-json"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3fa7e38b_0997db3b","line":13,"updated":"2020-02-03 17:47:43.000000000","message":"Reading this bug, using kubectl exec in a command task is supposed to work fine. Wouldn\u0027t that be a preferable workaround? I\u0027m not sure how magic package installs from old centos help us.","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"01fa289723c281c1cbafa16bea04a0f56a058370","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# unarchive: bzip2 and tar"},{"line_number":11,"context_line":"# generate zuul ssh-keys or certificate: openssh and openssl"},{"line_number":12,"context_line":"# manage configuration: git"},{"line_number":13,"context_line":"# fix for https://github.com/operator-framework/operator-sdk/issues/2204 : kubectl"},{"line_number":14,"context_line":"RUN dnf install -y bzip2 tar openssh openssl git http://mirror.centos.org/centos/7/os/x86_64/Packages/bash-completion-2.1-6.el7.noarch.rpm http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin/origin-clients-3.11.0-1.el7.git.0.62803d0.x86_64.rpm"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Install dhall-to-json"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3fa7e38b_9412fe54","line":13,"in_reply_to":"3fa7e38b_0997db3b","updated":"2020-02-03 18:16:18.000000000","message":"This is using the rpm file as it is easier to install like this, we could also do the `curl \u0026\u0026 sha256sum -c \u0026\u0026 tar \u0026\u0026 rm` of the kubernetes client release tarball.","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"}],"roles/zuul-reconfigure-tenant-when-conf-changed/library/k8s_exec.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9652fb49453c31238d6b32444a8d2f82a03cf1f5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Import from https://github.com/ansible/ansible/pull/55029"},{"line_number":3,"context_line":"# Copyright 2019 Red Hat | Ansible"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This file is part of Ansible"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Ansible is free software: you can redistribute it and/or modify"},{"line_number":8,"context_line":"# it under the terms of the GNU General Public License as published by"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a9f2479b","line":5,"updated":"2020-02-03 17:47:43.000000000","message":"Why do we need to vendor this file if it comes from Ansible?","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"fea06a4c57affcdb5306cd3f6febb4392c2e6608","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Import from https://github.com/ansible/ansible/pull/55029"},{"line_number":3,"context_line":"# Copyright 2019 Red Hat | Ansible"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This file is part of Ansible"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Ansible is free software: you can redistribute it and/or modify"},{"line_number":8,"context_line":"# it under the terms of the GNU General Public License as published by"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_74df4267","line":5,"in_reply_to":"3fa7e38b_14204e9a","updated":"2020-02-03 18:25:38.000000000","message":"Can we add a note that this file should be deleted once ansible in the operator images is updated to include this file?","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"ee61aa977c717f80089a7713be5f0eb5c37c5bfa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Import from https://github.com/ansible/ansible/pull/55029"},{"line_number":3,"context_line":"# Copyright 2019 Red Hat | Ansible"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This file is part of Ansible"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Ansible is free software: you can redistribute it and/or modify"},{"line_number":8,"context_line":"# it under the terms of the GNU General Public License as published by"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0f559bf9","line":5,"in_reply_to":"3fa7e38b_74df4267","updated":"2020-02-03 19:15:23.000000000","message":"Actually next PS drop the file until the operator proxy is fixed and/or the k8s_exec is merged in ansible.","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"01fa289723c281c1cbafa16bea04a0f56a058370","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Import from https://github.com/ansible/ansible/pull/55029"},{"line_number":3,"context_line":"# Copyright 2019 Red Hat | Ansible"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This file is part of Ansible"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# Ansible is free software: you can redistribute it and/or modify"},{"line_number":8,"context_line":"# it under the terms of the GNU General Public License as published by"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_14204e9a","line":5,"in_reply_to":"3fa7e38b_a9f2479b","updated":"2020-02-03 18:16:18.000000000","message":"Because it is not merged yet, see: https://github.com/ansible/ansible/pull/55029","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"}],"roles/zuul-reconfigure-tenant-when-conf-changed/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9652fb49453c31238d6b32444a8d2f82a03cf1f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: new_zuul_tenants_secret.data[\u0027main.yaml\u0027] !\u003d zuul_tenants_secret.data[\u0027main.yaml\u0027]"},{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_69be8fb0","line":9,"updated":"2020-02-03 17:47:43.000000000","message":"Here I see we are using kubectl exec, so why are we install openshift and bash completion packages? Can\u0027t we just install kubectl?","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"01fa289723c281c1cbafa16bea04a0f56a058370","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: new_zuul_tenants_secret.data[\u0027main.yaml\u0027] !\u003d zuul_tenants_secret.data[\u0027main.yaml\u0027]"},{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_942bde7a","line":9,"in_reply_to":"3fa7e38b_69be8fb0","updated":"2020-02-03 18:16:18.000000000","message":"bash completion was needed to install the cli, we could install kubectl using another release too. We just need the kubectl command.","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"2b382b3415e95e8dc90335300147b9912e74c2c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: new_zuul_tenants_secret.data[\u0027main.yaml\u0027] !\u003d zuul_tenants_secret.data[\u0027main.yaml\u0027]"},{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_af06c721","line":9,"range":{"start_line":9,"start_character":87,"end_line":9,"end_character":103},"updated":"2020-02-03 20:05:30.000000000","message":"smart-reconfigure is more suitable for reconfigurations after updated tenant configs. Nowadays I\u0027d consider full-reconfigure as a repair tool which should be run manually if something went out of sync unexpectedly.","commit_id":"924d7228a62d51e26f5437295f5adbe5359148ba"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"9b884f5526b82a5c46da539c03609a52d8d0767d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  when: new_zuul_tenants_secret.data[\u0027main.yaml\u0027] !\u003d zuul_tenants_secret.data[\u0027main.yaml\u0027]"},{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_175ccd56","line":9,"range":{"start_line":9,"start_character":87,"end_line":9,"end_character":103},"in_reply_to":"3fa7e38b_af06c721","updated":"2020-02-04 02:07:58.000000000","message":"Done","commit_id":"924d7228a62d51e26f5437295f5adbe5359148ba"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"2b382b3415e95e8dc90335300147b9912e74c2c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""},{"line_number":13,"context_line":"#    command: \"zuul-scheduler full-reconfigure\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e1013305","line":13,"range":{"start_line":10,"start_character":0,"end_line":13,"end_character":47},"updated":"2020-02-03 20:05:30.000000000","message":"Is that a debug leftover?","commit_id":"924d7228a62d51e26f5437295f5adbe5359148ba"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"9b884f5526b82a5c46da539c03609a52d8d0767d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Use kubectl instead of k8s_exec because of https://github.com/operator-framework/operator-sdk/issues/2204"},{"line_number":8,"context_line":"  command: \u003e-"},{"line_number":9,"context_line":"    kubectl exec -n {{ meta.namespace }} {{ zuul_name }}-scheduler-0 -- zuul-scheduler full-reconfigure"},{"line_number":10,"context_line":"#  k8s_exec:"},{"line_number":11,"context_line":"#    namespace: \"{{ namespace }}\""},{"line_number":12,"context_line":"#    pod: \"{{ zuul_name }}-scheduler-0\""},{"line_number":13,"context_line":"#    command: \"zuul-scheduler full-reconfigure\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_77a1813a","line":13,"range":{"start_line":10,"start_character":0,"end_line":13,"end_character":47},"in_reply_to":"3fa7e38b_e1013305","updated":"2020-02-04 02:07:58.000000000","message":"yes, that can be dropped too.","commit_id":"924d7228a62d51e26f5437295f5adbe5359148ba"}],"roles/zuul/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9652fb49453c31238d6b32444a8d2f82a03cf1f5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include_role:"},{"line_number":41,"context_line":"    name: zuul-reconfigure-tenant-when-conf-changed"},{"line_number":42,"context_line":"  when: zuul_tenants_secret.data is defined"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_4904f37d","line":42,"updated":"2020-02-03 17:47:43.000000000","message":"Similar to my comment on the previous change, won\u0027t this reload tenant config twice on initial apply?","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"01fa289723c281c1cbafa16bea04a0f56a058370","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- include_role:"},{"line_number":41,"context_line":"    name: zuul-reconfigure-tenant-when-conf-changed"},{"line_number":42,"context_line":"  when: zuul_tenants_secret.data is defined"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_f44fb266","line":42,"in_reply_to":"3fa7e38b_4904f37d","updated":"2020-02-03 18:16:18.000000000","message":"In the first pass, the secret.data is not defined and this task is skipped:  https://zuul.opendev.org/t/zuul/build/cd7e83e09c9b4c24a6105bc04f5515c5/log/docker/k8s_ansible_zuul-operator-5d8c859999-rllsj_default_8e819d92-4b45-48e2-9577-e0f86d8b0e0f_0.txt#81-87","commit_id":"d268b97a28f28cd61cbf86813f355bab5f6ac924"}]}