)]}'
{"playbooks/zuul-operator-functional/tasks/create_config.yaml":[{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"7da03f854d04aeb1d85c2903e6164a1fcf696eba","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    cd {{ git_root.path }}"},{"line_number":6,"context_line":"    git clone git://{{ cluster_ip }}:{{ git_server_port }}/config"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: copy config content"},{"line_number":9,"context_line":"  copy:"},{"line_number":10,"context_line":"    dest: \"{{ git_root.path }}/config/{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"584b6aa1_d0db5cdf","line":7,"updated":"2021-04-10 20:11:59.000000000","message":"Could be a good idea to change this to a command task and set the directory on the task level instead to avoid using the shell. Unless you really want the `set -x` part even though the task invocation would be recorded by ansible.\n\n```\n- name: create config directory\n  command: \"git clone git://{{ cluster_ip }}:{{ git_server_port }}/config\"\n  args:\n    chdir: \"{{ git_root_path }}\"\n```","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d83abc6558d5ff4cf0d40ccf6061db235f1243aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    cd {{ git_root.path }}"},{"line_number":6,"context_line":"    git clone git://{{ cluster_ip }}:{{ git_server_port }}/config"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: copy config content"},{"line_number":9,"context_line":"  copy:"},{"line_number":10,"context_line":"    dest: \"{{ git_root.path }}/config/{{ item.name }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5e0e8dde_42c4c75b","line":7,"updated":"2021-04-11 01:36:46.000000000","message":"Done, and other similars.","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"},{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"7da03f854d04aeb1d85c2903e6164a1fcf696eba","unresolved":true,"context_lines":[{"line_number":57,"context_line":"  shell: |"},{"line_number":58,"context_line":"    set -x"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    cd {{ git_root.path }}/config"},{"line_number":61,"context_line":"    git add *.yaml"},{"line_number":62,"context_line":"    git commit -m \u0027Setup config project\u0027 || true"},{"line_number":63,"context_line":"    git push --set-upstream git://{{ cluster_ip }}:{{ git_server_port }}/config master"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"526da4d0_91a79740","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":2},"updated":"2021-04-10 20:11:59.000000000","message":"same as above, this could be moved to `args: {chdir: ...}`","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"}],"playbooks/zuul-operator-functional/tasks/create_test_secrets.yaml":[{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"7da03f854d04aeb1d85c2903e6164a1fcf696eba","unresolved":true,"context_lines":[{"line_number":13,"context_line":"  register: _kube_config"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Read generated kubectl configuration"},{"line_number":16,"context_line":"  command: bash -c \"kubectl config view --flatten | sed -e \u0027s#{{ _kube_config.stdout }}#https://kubernetes/#g\u0027\""},{"line_number":17,"context_line":"  register: _kube_config"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Read current context name"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"db376050_fcda0dc8","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":18},"updated":"2021-04-10 20:11:59.000000000","message":"This looks like it could be a shell task instead.","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"}],"playbooks/zuul-operator-functional/tasks/git_setup.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"eb4ca90601a22a00c83146e7e06807af75387cbd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"              emptyDir: {}"},{"line_number":28,"context_line":"            containers:"},{"line_number":29,"context_line":"            - name: git-server"},{"line_number":30,"context_line":"              image: sdelrio/git-daemon:latest"},{"line_number":31,"context_line":"              ports:"},{"line_number":32,"context_line":"              - containerPort: 9418"},{"line_number":33,"context_line":"              volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a5497474_05d73583","line":30,"updated":"2021-07-20 20:19:38.000000000","message":"Good idea; fixed.","commit_id":"a1d13b1ad70f1f48d0f0ff667a0a1acfdec67806"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3817310fd4a2bdf063f7afd1066559728a3ea267","unresolved":true,"context_lines":[{"line_number":27,"context_line":"              emptyDir: {}"},{"line_number":28,"context_line":"            containers:"},{"line_number":29,"context_line":"            - name: git-server"},{"line_number":30,"context_line":"              image: sdelrio/git-daemon:latest"},{"line_number":31,"context_line":"              ports:"},{"line_number":32,"context_line":"              - containerPort: 9418"},{"line_number":33,"context_line":"              volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1cc28537_78d6dc04","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":46},"updated":"2021-07-14 20:49:46.000000000","message":"nit: should we use fully-qualified image name to avoid issue with local registries configuration?","commit_id":"a1d13b1ad70f1f48d0f0ff667a0a1acfdec67806"}],"playbooks/zuul-operator-functional/tasks/zuul_web_check.yaml":[{"author":{"_account_id":29671,"name":"Albin Vass","email":"opendev@albinvass.com","username":"albin_vass"},"change_message_id":"7da03f854d04aeb1d85c2903e6164a1fcf696eba","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  uri:"},{"line_number":3,"context_line":"    url: \"{{ zuul_web_url }}{{ endpoint }}\""},{"line_number":4,"context_line":"  register: result"},{"line_number":5,"context_line":"  until: \"result.json is defined and result.json and (expected is not defined or result.json \u003d\u003d expected)\""},{"line_number":6,"context_line":"  retries: 600"},{"line_number":7,"context_line":"  delay: 1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f3ba00b_7f63ba3b","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":53},"updated":"2021-04-10 20:11:59.000000000","message":"This would technically fail if we expect an empty dict/list/other falsy values.\nShouldn\u0027t it be enough to check if expected \u003d\u003d result.json?","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d83abc6558d5ff4cf0d40ccf6061db235f1243aa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  uri:"},{"line_number":3,"context_line":"    url: \"{{ zuul_web_url }}{{ endpoint }}\""},{"line_number":4,"context_line":"  register: result"},{"line_number":5,"context_line":"  until: \"result.json is defined and result.json and (expected is not defined or result.json \u003d\u003d expected)\""},{"line_number":6,"context_line":"  retries: 600"},{"line_number":7,"context_line":"  delay: 1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f6f4f8bb_e7c1842f","line":5,"updated":"2021-04-11 01:36:46.000000000","message":"We need the defined checks, and the ability to call this without expected implies that the result.json value should be positive in order for this to be useful.\n\nIf we never call this without expected, we could drop \"and result.json\" along with the defined check for expected.  But if we allow calls without expected, then we need to keep \"and result.json\" since this becomes a test of \"did it return something\".\n\nAnyway, this works and serves its current uses; I\u0027m just correcting the template error that was here before.","commit_id":"354e0b02473cf01edba28fc1467b63f52cd37287"}],"zuul_operator/templates/zuul.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3817310fd4a2bdf063f7afd1066559728a3ea267","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    app.kubernetes.io/part-of: zuul"},{"line_number":77,"context_line":"    app.kubernetes.io/component: zuul-web"},{"line_number":78,"context_line":"spec:"},{"line_number":79,"context_line":"  type: NodePort"},{"line_number":80,"context_line":"  ports:"},{"line_number":81,"context_line":"  - name: zuul-web"},{"line_number":82,"context_line":"    port: 9000"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a6f408e2_537cac57","line":79,"updated":"2021-07-14 20:49:46.000000000","message":"Is this related to this change?","commit_id":"a1d13b1ad70f1f48d0f0ff667a0a1acfdec67806"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"eb4ca90601a22a00c83146e7e06807af75387cbd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    app.kubernetes.io/part-of: zuul"},{"line_number":77,"context_line":"    app.kubernetes.io/component: zuul-web"},{"line_number":78,"context_line":"spec:"},{"line_number":79,"context_line":"  type: NodePort"},{"line_number":80,"context_line":"  ports:"},{"line_number":81,"context_line":"  - name: zuul-web"},{"line_number":82,"context_line":"    port: 9000"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dd4dc46a_31e20f6b","line":79,"updated":"2021-07-20 20:19:38.000000000","message":"Probably not, sorry.  But at this point it\u0027s probably not worth finding out where in the stack we should put it.  :(","commit_id":"a1d13b1ad70f1f48d0f0ff667a0a1acfdec67806"}]}