)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"1b06c9a37187360a7a48febb37a8dc4156e94f2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef021689_c1ec361a","updated":"2022-08-18 19:41:22.000000000","message":"What is the benefit to use a single namespace for multiple zuul? I find it complicate the resource names, what\u0027s the issue with creating a namespace per zuul deployment?","commit_id":"772bec29392ff2f7e1fb606d5cca3ab62107b512"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"e9bc4f7027fb6807a79b4ad317d6e9b647cc28ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8404fe9_a48b6fbb","in_reply_to":"84e2058e_df5f7998","updated":"2022-11-02 16:18:06.000000000","message":"Ack","commit_id":"772bec29392ff2f7e1fb606d5cca3ab62107b512"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"c6889c52e73f4738f974e4b42ed89fd14b2659c8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84e2058e_df5f7998","in_reply_to":"ef021689_c1ec361a","updated":"2022-10-14 04:16:07.000000000","message":"It shouldn\u0027t actually matter if it\u0027s one namespace or not - it should work either way.  This isn\u0027t good behaviour for an operator in Kubernetes... as it stands right now if you create multiple Zuul resources in the same namespace, it\u0027s just broken.","commit_id":"772bec29392ff2f7e1fb606d5cca3ab62107b512"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"6f7b6c78b002dfde16c68e58c91a2d130f8bc11a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"511a27d7_4ed2321b","updated":"2022-08-19 02:45:25.000000000","message":"recheck","commit_id":"93dc3c07891e4c96cb4e9f40e2896a9c42f3f4c4"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"bcec11bbdfc7259ae4f08d80316d793b4f78c64a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d54ff003_e1693339","updated":"2022-08-19 15:54:44.000000000","message":"recheck","commit_id":"93dc3c07891e4c96cb4e9f40e2896a9c42f3f4c4"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"0e2a4ba0f70273ca9708cca2ae05c9440ff79bb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4afd3ad_44a5ebfa","updated":"2022-08-19 05:27:00.000000000","message":"recheck","commit_id":"93dc3c07891e4c96cb4e9f40e2896a9c42f3f4c4"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"016c0f59cf70f64dcc69b8c0cf0d01b1ba483b9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c87254e7_a8354230","updated":"2022-08-19 20:30:45.000000000","message":"recheck","commit_id":"7996abf785d93c13c9f3e40b95feae419ec16321"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"be70e0cd498c712d15f8ced35ba9598d46f482c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e775f0c3_6dd09b26","updated":"2022-12-06 20:47:35.000000000","message":"An additional question to consider:\n\nWhen the operator is used in the mode where it provides ZK and DB services, what will happen?  I suspect those may also need to be made safe for multiple instances in the same namespace.","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"947554088cc34e0a995826de3b1c596d5a159eec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1aca8fd6_179e963c","updated":"2022-12-02 14:38:19.000000000","message":"What\u0027s the upgrade story?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"38967361312ffd2e2b8b382365ef2a3e14125868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"48972b2b_adae6226","updated":"2023-01-28 01:49:59.000000000","message":"recheck","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"f895059a1896d957b5d27f3778efe6eee8c7829b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d98e0a2e_c79f5b56","updated":"2023-02-25 04:28:44.000000000","message":"recheck","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"9c8199d5d63e952ef3fc38a7171d048ee110c05b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4a5bd125_3eda4089","in_reply_to":"1aca8fd6_179e963c","updated":"2022-12-02 16:28:56.000000000","message":"As in, what does it look like to upgrade from one Zuul version to the next with this?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"fc806e3df373b4cad67c8db4b914b133fee95ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0bbab638_d4cee00e","in_reply_to":"1aca8fd6_179e963c","updated":"2022-12-02 16:39:42.000000000","message":"No, I meant what does it look like for an existing user of the operator to upgrade to this commit?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"fc806e3df373b4cad67c8db4b914b133fee95ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4407c5c1_a5307fe1","in_reply_to":"1aca8fd6_179e963c","updated":"2022-12-02 16:39:42.000000000","message":"No, I meant what does it look like for an existing user of the operator to upgrade to this commit?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"fc806e3df373b4cad67c8db4b914b133fee95ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a210b19e_16fb318f","in_reply_to":"1aca8fd6_179e963c","updated":"2022-12-02 16:39:42.000000000","message":"No, I meant what does it look like for an existing user of the operator to upgrade to this commit?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"fc806e3df373b4cad67c8db4b914b133fee95ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ce3dfa2f_4a854d50","in_reply_to":"1aca8fd6_179e963c","updated":"2022-12-02 16:39:42.000000000","message":"No, I meant what does it look like for an existing user of the operator to upgrade to this commit?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"644e8854d3a1615cefa119d750f82c60f5c0bc41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ee7aeb1c_4c86d86b","in_reply_to":"40d38692_a13f116c","updated":"2022-12-16 07:40:21.000000000","message":"https://review.opendev.org/c/zuul/zuul-operator/+/867938","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"03244af9a855c0cd6ce0eb8e56c87dd7b93a006e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"bdb861c5_df738b10","in_reply_to":"9fc9dc59_aae3cab5","updated":"2022-12-16 06:36:30.000000000","message":"One wrinkle here is around PVCs - zuul-scheduler STS and the stateful sets associated with the database + zookeeper will also have to be bumped.  I\u0027m thinking that (3) might be the best option because it provides a natural breakover point. \n\nAdmittedly, I\u0027m not 100% certain of how to deal with ZooKeeper or MySQL here because this would implicitly require a data migration between ZK/MySQL instances and the actual internals of these things is opaque to the operator itself. Thoughts?","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"56117f418bdb18906ac41ccdc1cbed8b3b68ff9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d7ce49cd_1ad74a5c","in_reply_to":"cd08b8ad_4d218107","updated":"2022-12-02 17:28:47.000000000","message":"As far as I know, nothing would change with any underlying instance itself *until* one of the config pieces change.  The startup code doesn\u0027t appear to trigger any configuration updates in the underlying setup *as of this change*. \n\nGoing forward, users will likely want to re-name the underlying resources that are created such that they capture the extended name in lieu of the current non-distinct naming.","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e44a1226ed2d9ce3a6ac35fe161e35a3cff25302","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"cd08b8ad_4d218107","in_reply_to":"ce3dfa2f_4a854d50","updated":"2022-12-02 16:40:43.000000000","message":"Er, sorry for the dupes.","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"90b07398ac350df94ce5503d4632d8ce64531e92","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9fc9dc59_aae3cab5","in_reply_to":"d7ce49cd_1ad74a5c","updated":"2022-12-03 00:03:37.000000000","message":"I think those kinds of changes are expected often enough that a user could be pretty quickly surprised by suddenly having an extra Zuul.  So I think we need to account for that somehow.\n\nSome ideas (alternatives; in order of preference):\n\n1) Have the operator perform the migration itself.\n2) A release note with a migration script users can run, along with a major version number bump of the operator itself.\n3) A CRD API version bump (and naturally an operator major version bump as well).","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"03244af9a855c0cd6ce0eb8e56c87dd7b93a006e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"40d38692_a13f116c","in_reply_to":"e775f0c3_6dd09b26","updated":"2022-12-16 06:36:30.000000000","message":"Finally getting the cycles to come back to this.  I hadn\u0027t consider ZK and DB services as this is not the configuration that I\u0027m using.  Seems like we\u0027d want to do that in this case.  I had separated out the nodepool bits in a distinct change - I\u0027ll do the same with the dependent resources and inject it into the stack after the nodepool change.  I *think* we have to do this with the cert manager bits as well.","commit_id":"e20d1b5418b613be04d9b4761906ca60b017b0f2"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"d76ed87e56db791d16ab06f8dfe080ec07df05a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e95c37a1_8a2541b6","updated":"2023-02-25 05:48:22.000000000","message":"recheck","commit_id":"f8abf8f49c57c27b8abfa93d39aff37b69342c55"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"ba4b88ae3ab7b7694802058a8ba0debd8756ebee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"04e52c58_c5f45935","updated":"2023-05-19 16:04:55.000000000","message":"recheck","commit_id":"ddabcf073edb753efac99dbeafc26f480aa98a12"}],"playbooks/zuul-operator-functional/tasks/test_preview.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"44073bee1324fb10bfd4b41ee1d0194699fb8f24","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Get preview service ip"},{"line_number":2,"context_line":"  command: kubectl get svc zuul-zuul-preview -o jsonpath\u003d\u0027{.spec.ports[0].nodePort}\u0027"},{"line_number":3,"context_line":"  register: _preview_port"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Connect to the preview service"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"611f3395_a8d0e24c","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":44},"updated":"2022-12-01 21:10:13.000000000","message":"perhaps we could change the test name to `my`, so that the IDs look like `my-zuul-preview`","commit_id":"f345c3d7e8ba147c5d77e0e4fc4aed811f04c121"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"ed5b9e4cb4bbe4467b7d6299d9efd339727bb232","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Get preview service ip"},{"line_number":2,"context_line":"  command: kubectl get svc zuul-zuul-preview -o jsonpath\u003d\u0027{.spec.ports[0].nodePort}\u0027"},{"line_number":3,"context_line":"  register: _preview_port"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Connect to the preview service"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1d3e1545_c9ebfab8","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":44},"in_reply_to":"0e0276ba_021e1180","updated":"2022-12-01 21:45:50.000000000","message":"Done","commit_id":"f345c3d7e8ba147c5d77e0e4fc4aed811f04c121"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"342b7d47af7592aea43391ae15f6410140cf9fc3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Get preview service ip"},{"line_number":2,"context_line":"  command: kubectl get svc zuul-zuul-preview -o jsonpath\u003d\u0027{.spec.ports[0].nodePort}\u0027"},{"line_number":3,"context_line":"  register: _preview_port"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Connect to the preview service"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"0e0276ba_021e1180","line":2,"range":{"start_line":2,"start_character":27,"end_line":2,"end_character":44},"in_reply_to":"611f3395_a8d0e24c","updated":"2022-12-01 21:37:33.000000000","message":"Sure.  that\u0027s in line with the template generation I\u0027m doing as well.","commit_id":"f345c3d7e8ba147c5d77e0e4fc4aed811f04c121"}]}