)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f64e89ef526c4dadec56a9f24182faaf4857d835","unresolved":false,"context_lines":[{"line_number":10,"context_line":"make it easier to (un)install is from a given Kubernetes cluster.  The"},{"line_number":11,"context_line":"chart is a combination of the trimmed down output from \u0027helm create\u0027"},{"line_number":12,"context_line":"combined with some details from the existing Kubernetes templates in"},{"line_number":13,"context_line":"the repository."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Notable differences from the existing templates are as follows:"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"cf60daa7_9f02a2df","line":13,"updated":"2022-11-02 22:10:36.000000000","message":"Some general thoughts:\n\nI should note that it is an explicit goal to be able to install the operator with only a handful of kubectl apply commands.  For a nearby example of another operator that is similarly simple to install, we can look at the Percona operator: https://docs.percona.com/percona-operator-for-mysql/pxc/kubernetes.html\n\nThat\u0027s more or less what our static instructions should look like too.  And yes, they have a helm chart too.  :)\n\nI think adding a helm chart could be useful for the reasons you describe.  I just want to ensure that we continue to treat the static use case as first-class.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"6ae8d323eb8655c6f43a8b5e2d4557c9fa774572","unresolved":false,"context_lines":[{"line_number":10,"context_line":"make it easier to (un)install is from a given Kubernetes cluster.  The"},{"line_number":11,"context_line":"chart is a combination of the trimmed down output from \u0027helm create\u0027"},{"line_number":12,"context_line":"combined with some details from the existing Kubernetes templates in"},{"line_number":13,"context_line":"the repository."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Notable differences from the existing templates are as follows:"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"04eac20c_ffc48a8f","line":13,"in_reply_to":"cf60daa7_9f02a2df","updated":"2022-11-02 22:17:55.000000000","message":"Ack","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f64e89ef526c4dadec56a9f24182faaf4857d835","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Notable differences from the existing templates are as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- ClusterRole, ClusterRoleBinding, and ServiceAccount are all in"},{"line_number":18,"context_line":"  separate template files"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"6b9230b2_2e8eead6","line":18,"updated":"2022-11-02 22:10:36.000000000","message":"Would it be possible to generate the static files from helm in order to reduce duplication?\n\nA way I could imagine that working is that we continue to check both into git, but we have a script that performs the helm -\u003e static transform, and we have a zuul job that does the same thing to ensure that the contents in git are correct (we do similar things in the zuul-jobs repo for auto-genrated files).","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"6ae8d323eb8655c6f43a8b5e2d4557c9fa774572","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Notable differences from the existing templates are as follows:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- ClusterRole, ClusterRoleBinding, and ServiceAccount are all in"},{"line_number":18,"context_line":"  separate template files"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"03b4d096_87c2c50a","line":18,"in_reply_to":"6b9230b2_2e8eead6","updated":"2022-11-02 22:17:55.000000000","message":"Yes, this should be fairly easy to do using the `helm template` command.  I have a commit later in my stack to remove the static templates, but I can revise it to do this instead.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f64e89ef526c4dadec56a9f24182faaf4857d835","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"e50860c8_d9198263","line":22,"updated":"2022-11-02 22:10:36.000000000","message":"If this is so, then we should be able to change the static files too.\n\nThere are two versions of the static rbac configuration: one is a cluster-admin, and the other is not.  For users who don\u0027t want the built-in operator management, the second can be used.\n\nIf we\u0027re going to have a helm chart, it should operate in the same way and do the same thing as the static files.  I\u0027m especially concerned about ending up with even more variations of how rbac is configured.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"658743d9f127179590448afb86c1351f27ec762a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"947a2401_e5b569e5","line":22,"in_reply_to":"5a4da335_f7918ae8","updated":"2022-12-01 01:08:16.000000000","message":"Updated later commits in the stack","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"0da56b396ef71cab199023ce9f01b55f7f5c0ff3","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"b0ca7276_30a1e260","line":22,"in_reply_to":"5caddefd_5e198d16","updated":"2022-11-07 22:06:41.000000000","message":"Unless you plan to turn zuul-operator into something like RedHat\u0027s operator LCM that doesn\u0027t seem like it\u0027ll work out super well, especially as other users of the PXC operator in the cluster might be broken by such an approach.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"b40942e9e1872a82532ac95f3d70e29b3afa3826","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"13826f4b_d13d0060","line":22,"in_reply_to":"69cfa66f_a7606a8b","updated":"2022-11-17 22:47:38.000000000","message":"Sure: with one caveat - I think we should provide a mechanism to disable this auto-install functionality in the operator in case of user misconfig.  This can be a pain to clean up from if that\u0027s not what you actually desired.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"8fe3d08b634bdb9a7078889fe59bf229e18e0e86","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0bc1be40_a0a81824","line":22,"in_reply_to":"ccb3e11c_984001b2","updated":"2022-11-08 22:48:39.000000000","message":"If the user is assuming the PXC operator is installed then there\u0027s 3 avenues that can work:\n\n1. Generate the static templates from the Helm chart and add that to the list of things to kubectl apply -f \n2. Use the helm chart with the nested charts for PXC and cert-manager\n3. What we\u0027re doing right now\n\nBoth (1) and (2) provide an easy way for the user to transparently manage the upgrade and are trivial to provide\n\n(3) is pretty opaque and will require a non-trivial work to deal with (eg: what happens when the operator upgrade fails? how do you surface that to the end user? etc).  This also seems like an atypical way for an operator to function and is akin to what LCM provides\n\nAs to the non-admin RBAC - we can regenerate that from the helm chart.  As it stands right now, the actual roles granted by the non-admin are not sufficient for proper function.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"020a2534e760370ef88050ead91cf3ce095d6327","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5caddefd_5e198d16","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-04 00:37:40.000000000","message":"Another thing to consider: upgrades.\n\nIf the operator is used in batteries-included mode (i.e., it internally deploys the percona operator) then we would expect it to be able to upgrade the percona operator in the future.  We don\u0027t have any code to do that right now, but it is a possibility that was anticipated, and the current scheme supports it.\n\nIf we move the pxc operator into a pre-install step, how will the zuul operator handle pxc operator upgrades?","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"3478feb77af759af132c3f48b0b5f6048b64f88c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0432ac91_52ab606c","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-02 22:22:56.000000000","message":"I\u0027d have to look into whether we do anything with credentials or similar when configuring the other operators, but if not, I think we could consider moving those out.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"6ae8d323eb8655c6f43a8b5e2d4557c9fa774572","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"260e8cfd_dc095191","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-02 22:17:55.000000000","message":"In fact, both versions of the rbac.yaml bind to the cluster-admin role, not to the role that is created in the template.\n\nAs in the previous comment, we can generate the static files from the helm chart pretty easily which should ensure that these things match up.\n\nIt seems like the built in operator management would get triggered exactly once.  Is there a reason why it wouldn\u0027t just be better to have static templates for this as well?","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"226eea31be753071161c0efae1a0b41166d51361","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"69cfa66f_a7606a8b","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-17 21:12:45.000000000","message":"Okay, here\u0027s the way I think we should view this from a high level:\n\n* The helm chart should allow users to deploy the operator as written.  It should not drive change to the operator.\n\nIn particular, I think that affects things like the RBAC discussion.  If there\u0027s a problem with the rbac config, that should be addressed on its own.  The helm chart should install exactly the same manifests as the statically generated ones.\n\n* Installation via static manifests should continue to be first-class.  Helm should not be required for the operator, and as described above, should not do anything different.\n\n* The operator currently installs PXC if the user doesn\u0027t supply a database.  We should maintain that, and maintain the potential to upgrade the internal PXC in the future.  Anyone that doesn\u0027t want that functionality can supply a dburi (whether that\u0027s via a static manifest or as input to the helm chart).\n\nIn practice, I think those principals suggest the best course is to:\n\n1) Address any RBAC issues first on their own.\n2) Generate the static manifests from helm, along with a job to generate+verify output.\n3) Add helm charts, along with an additional functional test job to run the operator using helm.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"40d273552a0a44fc1ba01a429ca1c47485315802","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a4da335_f7918ae8","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-17 22:52:27.000000000","message":"That sounds reasonable.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"29cbf2589e0157e1c3e5b92b5059878a5a9109cd","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- we use the named role in the binding instead of using the"},{"line_number":21,"context_line":"  cluster-admin role, which provides greater access than an operator"},{"line_number":22,"context_line":"  should require"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- any references to namespaces are removed as they will be controlled"},{"line_number":25,"context_line":"  by \u0027helm install\u0027"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ccb3e11c_984001b2","line":22,"in_reply_to":"e50860c8_d9198263","updated":"2022-11-07 22:41:33.000000000","message":"The spec in the developer docs coveres this pretty well I think.  If the user is asking Zuul to deploy the PXC operator, there probably aren\u0027t any other users, and the zuul operator should manage it and upgrades.  That probably means that the PXC handling internal to the operator should remain, unless there\u0027s a good way to handle that otherwise.\n\nRegarding the rbac, if the non-admin rbac file is binding to the admin role, that\u0027s probably an error.","commit_id":"84e46b7655bc07d2f2f6ae2f5b1d5f488068cd1d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"a0a6c94834383124a63ec42ee40c3c446f9fc935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9b651d62_e56d80f1","updated":"2022-10-19 00:46:42.000000000","message":"recheck","commit_id":"76e31616a23735f88ab5efd376b273008c72de64"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"c13798e49f9e8c09a495c97f9dc23cf9690a9533","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2fffe631_f2b8c221","updated":"2022-10-19 02:40:16.000000000","message":"recheck","commit_id":"733dcbc18347245b1efe8a6fdf4bebea13a9839b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"19c7f1c906b20855fc217e7542a1597d883f4efc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"64ba9ff2_04f8770f","updated":"2022-10-19 03:25:42.000000000","message":"recheck","commit_id":"733dcbc18347245b1efe8a6fdf4bebea13a9839b"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"c8c6b8ee9b1de094730f45026f53d8d0a9deb543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e01637cf_16a5b1f5","updated":"2022-10-19 11:44:08.000000000","message":"I think this needs to be added to the deployment documentation.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"f890663b2a651bdb0bbe4fc40164a12ae41301ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2989bf78_79fd847a","updated":"2022-10-19 11:40:33.000000000","message":"Would it be possible to use and test the chart in the operator integration test?","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"8889f06f0304fdaca8ce1cd6789454a2a04ff0d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6113f242_e04a6782","in_reply_to":"2989bf78_79fd847a","updated":"2022-10-20 03:25:55.000000000","message":"Yes, I think so - this is just a sort of first cut that hits the basics, but I\u0027m going to iterate on this through a few more commits that\u0027ll make it a bit more full fledged as it were.  I was planning to update some of the deployment documentation when I got to that point as well.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"fb5c6ed84cb03a5de1a182129bdda58d8ad6d7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da0a7e8c_4bfe276b","in_reply_to":"6113f242_e04a6782","updated":"2022-11-04 03:49:55.000000000","message":"See: https://review.opendev.org/c/zuul/zuul-operator/+/863579/1\n\nThis is a first cut at what you\u0027re describing.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"21e049d6898846341b14c8b4cbff1cc4b93f36ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4d70362_278d765f","in_reply_to":"e01637cf_16a5b1f5","updated":"2022-11-04 03:50:41.000000000","message":"See: https://review.opendev.org/c/zuul/zuul-operator/+/863439/10\n\nI\u0027m going to revise this a bit further though s.t. it covers both the static template case and the helm case.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"3389d9b650803d4afce61491314e3e2f75211286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8aaaa6b3_34338968","updated":"2022-11-08 22:40:31.000000000","message":"recheck","commit_id":"3bf0d7d9d2f9ee40857dc55ec04c9987a544a909"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"d3f7819eb5e87a801dd4095b2e2fff917d01c906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"8fb96142_04ee1a7a","updated":"2023-01-27 05:06:09.000000000","message":"recheck","commit_id":"e89fca07ab5c7e292ace6e1db409b19bd668a5d8"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"f83018bf30d0e6443cf6927e2b8ece0db0660287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"9b36400a_a3cc4ca0","updated":"2023-05-19 18:12:43.000000000","message":"recheck","commit_id":"49ea14b9bc189e8aa38d89c29570810d13ffcd41"}],"helm/zuul-operator/crds/010-Crd-zuul.yaml":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"c8c6b8ee9b1de094730f45026f53d8d0a9deb543","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: apiextensions.k8s.io/v1"},{"line_number":2,"context_line":"kind: CustomResourceDefinition"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: zuuls.operator.zuul-ci.org"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f805ceb8_805177a1","line":1,"updated":"2022-10-19 11:44:08.000000000","message":"Should this use existing CRD, it seems like this is a different version","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"8a4dc98726daadb9070050fe23662aad12d4fd4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: apiextensions.k8s.io/v1"},{"line_number":2,"context_line":"kind: CustomResourceDefinition"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: zuuls.operator.zuul-ci.org"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0a0d4fcd_b3ce6b48","line":1,"in_reply_to":"f7800558_3f464241","updated":"2022-11-04 03:03:57.000000000","message":"I think that the CRD changed after I copied this. I\u0027ve since updated it.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"},{"author":{"_account_id":35201,"name":"Michael Kelly","display_name":"Michael Kelly","email":"mkelly@arista.com","username":"michael_kelly"},"change_message_id":"22a06a86a24967cbcb56d8c6e9a844c7e7b2bdde","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: apiextensions.k8s.io/v1"},{"line_number":2,"context_line":"kind: CustomResourceDefinition"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: zuuls.operator.zuul-ci.org"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f7800558_3f464241","line":1,"in_reply_to":"f805ceb8_805177a1","updated":"2022-10-20 03:27:20.000000000","message":"I just grabbed the CRD from the deploy/crds directory for this.  Should be the same thing.","commit_id":"926a3862c870aec7241057e688c9bfb964c4f18b"}]}