)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37112,"name":"Christoph Kulla","display_name":"Christoph Kulla","email":"christoph.kulla@de.bosch.com","username":"ckulla"},"change_message_id":"9ab2b405acdf779c2861c397fdc96b1d553ef388","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c1c51e2c_fbf188fb","updated":"2025-08-05 09:18:02.000000000","message":"I noticed a mismatch of variables using different naming conventions, e.g. ZOO_AUTOPURGE_PURGEINTERVAL (see https://opendev.org/zuul/zuul-operator/src/commit/a9858a5b77b7c2b2219950bc457de1d79d3cd7b5/zuul_operator/templates/zookeeper.yaml#L319) and ZK_PURGE_INTERVAL. Probably worth looking at while working on this issue.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":37112,"name":"Christoph Kulla","display_name":"Christoph Kulla","email":"christoph.kulla@de.bosch.com","username":"ckulla"},"change_message_id":"2e428185da0ecb7bc5686fda4f293aed8084d0c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4fb8a8d9_1583b2c4","updated":"2025-08-05 07:52:13.000000000","message":"Thanks for addressing this issue, we have experienced out of disk problems with zookeeper as well. Setting the purge interval to 2 contradicts the recommendation in the docs to set it to 6 hours, see https://zuul-ci.org/docs/zuul/latest/howtos/zookeeper.html#configuration. I suggest to keep both places in sync. Or make it configureable in the operator and set the default to the same value as in the docs.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":37112,"name":"Christoph Kulla","display_name":"Christoph Kulla","email":"christoph.kulla@de.bosch.com","username":"ckulla"},"change_message_id":"51cca57ef4ce7d438cb9cd21863f4a341ece25b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"159d16ab_11454f17","in_reply_to":"3de8b6e4_854338ac","updated":"2025-08-12 16:02:20.000000000","message":"Thanks for following up, this should be addressed in another change then.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"6bc606face4798d79b7f781e85fe0a7443d7de11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcbc3985_744ddc3f","in_reply_to":"4fb8a8d9_1583b2c4","updated":"2025-08-05 09:53:55.000000000","message":"Note that setting the zookeeper autopurge interval to a shorter period is probably a good idea: upstream opendev picked it to prevent ballooning disk sizes. An appreciable load will definitely fill up the volumes in short order.\n\nI believe one of the original ideas behind the zuul-operator was that you should set up an externally managed service rather than add parameters to the operator to tweak the behaviour of the internally managed dependency too much.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":37112,"name":"Christoph Kulla","display_name":"Christoph Kulla","email":"christoph.kulla@de.bosch.com","username":"ckulla"},"change_message_id":"51cca57ef4ce7d438cb9cd21863f4a341ece25b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b218b1c2_61916097","in_reply_to":"66784813_127c4453","updated":"2025-08-12 16:02:20.000000000","message":"Enhancing the Zookeeper configuration in the operator would be a lot more work. And probably not wanted in favor of an externally managed Zookeeper.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"d6753bffaf30adfcb11bf0e971b412ac340a8586","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3de8b6e4_854338ac","in_reply_to":"9899e765_5f19a504","updated":"2025-08-05 10:27:15.000000000","message":"Hah, I think I found the mismatch:\nhttps://github.com/31z4/zookeeper-docker/blob/master/3.9.3/docker-entrypoint.sh\n\nThe ZOO_ variables are used in the container ENTRYPOINT to generate a zoo.cfg\nENTRYPOINT [\"/docker-entrypoint.sh\"]\n\nHowever, the run script effectively ignores/overwrites them.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b4e9c25e841eff838ec42388ace2279957bb12e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66784813_127c4453","in_reply_to":"bcbc3985_744ddc3f","updated":"2025-08-12 14:54:46.000000000","message":"Yeah, going with 2 and updating the docs, based on opendev\u0027s experience, sounds good to me.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"6bc606face4798d79b7f781e85fe0a7443d7de11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9899e765_5f19a504","in_reply_to":"c1c51e2c_fbf188fb","updated":"2025-08-05 09:53:55.000000000","message":"As to the zookeeper templates, I think they might be really out of date - I believe a serious reassessment of keeping up the internal dependencies in the operator is due.\n\nWould you by chance know a good reference source for ZK? Unfortunately the recent changes to the bitnami charts I considered would make it hard to recommend.","commit_id":"3c3bf43b2ce8bc0bf4c0bc9f65448d09c8bf7579"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"04ae377e007f71f31b9591ba0f5c6fe0c5dbbbd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5458bd59_c8080959","updated":"2025-09-18 22:29:16.000000000","message":"recheck","commit_id":"c65de4e59a0fa25f12fb3ff89f40d0554ba155d3"}]}
