)]}'
{"zuul-preview/main.cc":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ad246718f8351c21e918b66bb25a231ce55d858c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      return {};"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    auto val \u003d *(location-\u003esecond);"},{"line_number":72,"context_line":"    queue.splice(queue.begin(), queue, location-\u003esecond);"},{"line_number":73,"context_line":"    return val.second;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-c","patch_set":1,"id":"3fce034c_a159fdfe","line":72,"updated":"2019-04-12 21:20:21.000000000","message":"Reading docs this is safe but won\u0027t be if we drop the location-\u003esecond arg (as it isn\u0027t valid to have this* be the same as the second arg in the two arg version of this method).\n\nMostly just me pointing out I checked the docs and this looks safe.","commit_id":"e55490b8b496d501242a5e421cec003e3f23b7d1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ad246718f8351c21e918b66bb25a231ce55d858c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    auto val \u003d *(location-\u003esecond);"},{"line_number":72,"context_line":"    queue.splice(queue.begin(), queue, location-\u003esecond);"},{"line_number":73,"context_line":"    return val.second;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  // Add an entry to the cache.  If the cache is full, drop the least"}],"source_content_type":"text/x-c","patch_set":1,"id":"3fce034c_216d0d98","line":73,"updated":"2019-04-12 21:20:21.000000000","message":"Could simplify this down to return location-\u003esecond-\u003esecond I think.","commit_id":"e55490b8b496d501242a5e421cec003e3f23b7d1"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"2f7ddd44f05d314954ef98318d03651299c69e1a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    auto val \u003d *(location-\u003esecond);"},{"line_number":72,"context_line":"    queue.splice(queue.begin(), queue, location-\u003esecond);"},{"line_number":73,"context_line":"    return val.second;"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  // Add an entry to the cache.  If the cache is full, drop the least"}],"source_content_type":"text/x-c","patch_set":1,"id":"3fce034c_fced6a25","line":73,"in_reply_to":"3fce034c_216d0d98","updated":"2019-04-12 22:36:20.000000000","message":"yes. it would actually be:\n\n  return location-\u003esecond.second;\n\nbut yes. I didn\u0027t do that just to keep the surface area of the change clear.","commit_id":"e55490b8b496d501242a5e421cec003e3f23b7d1"}]}