)]}'
{"zuul/ansible/callback/zuul_stream.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"36a352bcb91583e6abd823fb47c7753107a2fd37","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    of cmd it\u0027ll echo what the command was for folks."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for key in (\u0027changed\u0027, \u0027cmd\u0027, \u0027stderr\u0027, \u0027stderr_lines\u0027, \u0027stdout\u0027):"},{"line_number":63,"context_line":"        result.pop(key, None)"},{"line_number":64,"context_line":"    return result"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_a3e3f6d8","line":62,"updated":"2017-05-23 16:36:09.000000000","message":"-1: also add stdout_lines","commit_id":"96c8140e9f72c1f39a25f378a7cadb51aeb28ea8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a08ed8789aa3475eac55bffb46fff16476610bac","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    of cmd it\u0027ll echo what the command was for folks."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for key in (\u0027changed\u0027, \u0027cmd\u0027, \u0027stderr\u0027, \u0027stderr_lines\u0027, \u0027stdout\u0027):"},{"line_number":63,"context_line":"        result.pop(key, None)"},{"line_number":64,"context_line":"    return result"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_f8e4ca3d","line":62,"in_reply_to":"ff0f0b1f_a3e3f6d8","updated":"2017-05-25 00:21:16.000000000","message":"Done","commit_id":"96c8140e9f72c1f39a25f378a7cadb51aeb28ea8"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"36a352bcb91583e6abd823fb47c7753107a2fd37","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for key in (\u0027changed\u0027, \u0027cmd\u0027, \u0027stderr\u0027, \u0027stderr_lines\u0027, \u0027stdout\u0027):"},{"line_number":63,"context_line":"        result.pop(key, None)"},{"line_number":64,"context_line":"    return result"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_83e472e1","line":63,"updated":"2017-05-23 16:36:09.000000000","message":"0: Is it okay to modify the dict in place here?  I\u0027m sure it\u0027s fine for everything related to the callback, but is there any chance this is the same dict that might ultimately be used by something else, like register?\n\nWould it be safer to return a copy here and pass that copy to the superclass on_failed and on_ok methods?","commit_id":"96c8140e9f72c1f39a25f378a7cadb51aeb28ea8"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"a08ed8789aa3475eac55bffb46fff16476610bac","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for key in (\u0027changed\u0027, \u0027cmd\u0027, \u0027stderr\u0027, \u0027stderr_lines\u0027, \u0027stdout\u0027):"},{"line_number":63,"context_line":"        result.pop(key, None)"},{"line_number":64,"context_line":"    return result"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_98d70e4c","line":63,"in_reply_to":"ff0f0b1f_83e472e1","updated":"2017-05-25 00:21:16.000000000","message":"I\u0027m not sure it would be any different - what those methods take is a result instance, of which the dict here is the _result member. So if we did a copy, we\u0027d still have to assign it to result._result to pass it down.\n\nThat said - in the next patch we essentially completely replace the on_success method. We could do the same for the on_failure method if it\u0027s a problem.","commit_id":"96c8140e9f72c1f39a25f378a7cadb51aeb28ea8"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6df8a3848ba88c326b84f15f6c7e3454063eda02","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    for key in (\u0027changed\u0027, \u0027cmd\u0027,"},{"line_number":63,"context_line":"                \u0027stderr\u0027, \u0027stderr_lines\u0027,"},{"line_number":64,"context_line":"                \u0027stdout\u0027, \u0027stdout_lines\u0027):"},{"line_number":65,"context_line":"        result.pop(key, None)"},{"line_number":66,"context_line":"    return result"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_eb97153a","line":65,"updated":"2017-05-26 16:00:52.000000000","message":"result is a dict, right? Is there some reason we\u0027re not del\u0027ing these?","commit_id":"a047ba51cbc32ec203a3d3dba96e09b95828c431"}]}