)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"prometheus: add options to start the server and process collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new prometheus_port option to start a metric server"},{"line_number":10,"context_line":"to be scrapped by a prometheus service. By default, the server expose"},{"line_number":11,"context_line":"process informations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie329df6adc69768dfdb158d00283161f8b70f07a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_9a5cff7d","line":10,"updated":"2018-09-05 17:58:08.000000000","message":"s/expose/exposes/","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"prometheus: add options to start the server and process collector"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new prometheus_port option to start a metric server"},{"line_number":10,"context_line":"to be scrapped by a prometheus service. By default, the server expose"},{"line_number":11,"context_line":"process informations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie329df6adc69768dfdb158d00283161f8b70f07a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_fa6e482a","line":10,"in_reply_to":"3f79a3b5_9a5cff7d","updated":"2018-09-06 02:56:28.000000000","message":"Done","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"}],"doc/source/admin/monitoring.rst":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[{"line_number":333,"context_line":"~~~~~~~~~~~~~"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Prometheus support uses the ``prometheus_client`` python module."},{"line_number":336,"context_line":"Note that support is optional and Zuul will starts without"},{"line_number":337,"context_line":"the prometheus python module present."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"To enable the service, set the ``prometheus_port`` in a service section of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_3a55ab50","line":336,"updated":"2018-09-05 17:58:08.000000000","message":"s/starts/start/","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[{"line_number":333,"context_line":"~~~~~~~~~~~~~"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Prometheus support uses the ``prometheus_client`` python module."},{"line_number":336,"context_line":"Note that support is optional and Zuul will starts without"},{"line_number":337,"context_line":"the prometheus python module present."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"To enable the service, set the ``prometheus_port`` in a service section of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ba669050","line":336,"in_reply_to":"3f79a3b5_3a55ab50","updated":"2018-09-06 02:56:28.000000000","message":"Done","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Prometheus support uses the ``prometheus_client`` python module."},{"line_number":336,"context_line":"Note that support is optional and Zuul will starts without"},{"line_number":337,"context_line":"the prometheus python module present."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"To enable the service, set the ``prometheus_port`` in a service section of"},{"line_number":340,"context_line":"``zuul.conf``. For example setting :attr:`scheduler.prometheus_port` to 9091"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_5a52e768","line":337,"updated":"2018-09-05 17:58:08.000000000","message":"Is this important, since it\u0027s in requirements.txt?","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Prometheus support uses the ``prometheus_client`` python module."},{"line_number":336,"context_line":"Note that support is optional and Zuul will starts without"},{"line_number":337,"context_line":"the prometheus python module present."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"To enable the service, set the ``prometheus_port`` in a service section of"},{"line_number":340,"context_line":"``zuul.conf``. For example setting :attr:`scheduler.prometheus_port` to 9091"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_5a7e5ce3","line":337,"in_reply_to":"3f79a3b5_5a52e768","updated":"2018-09-06 02:56:28.000000000","message":"nop","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"}],"etc/zuul.conf-sample":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"pidfile\u003d/var/run/zuul/zuul.pid"},{"line_number":25,"context_line":"state_dir\u003d/var/lib/zuul"},{"line_number":26,"context_line":"prometheus_port\u003d9091"},{"line_number":27,"context_line":";prometheus_addr\u003d0.0.0.0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[merger]"},{"line_number":30,"context_line":"git_dir\u003d/var/lib/zuul/git"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3f79a3b5_fa4ad3aa","line":27,"updated":"2018-09-05 17:58:08.000000000","message":"can we please use ::, it\u0027s 2018","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"pidfile\u003d/var/run/zuul/zuul.pid"},{"line_number":25,"context_line":"state_dir\u003d/var/lib/zuul"},{"line_number":26,"context_line":"prometheus_port\u003d9091"},{"line_number":27,"context_line":";prometheus_addr\u003d0.0.0.0"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[merger]"},{"line_number":30,"context_line":"git_dir\u003d/var/lib/zuul/git"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3f79a3b5_3a692024","line":27,"in_reply_to":"3f79a3b5_fa4ad3aa","updated":"2018-09-06 02:56:28.000000000","message":"sure","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"}],"tests/unit/test_monitoring.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f79a3b5_1a48efb0","updated":"2018-09-05 17:58:08.000000000","message":"Shouldn\u0027t we call this file test_prometheus?","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f79a3b5_7a8318cc","in_reply_to":"3f79a3b5_1a48efb0","updated":"2018-09-06 02:56:28.000000000","message":"good idea","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"}],"zuul/cmd/__init__.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fecb94dc4894952f6a1c7821e21bcf319f9f904f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import traceback"},{"line_number":30,"context_line":"import threading"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"prometheus_client \u003d extras.try_import(\u0027prometheus_client\u0027)"},{"line_number":33,"context_line":"yappi \u003d extras.try_import(\u0027yappi\u0027)"},{"line_number":34,"context_line":"objgraph \u003d extras.try_import(\u0027objgraph\u0027)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_bac69b15","line":32,"updated":"2018-09-05 17:58:08.000000000","message":"Why are we just try_import\u0027ing? if we have it in requirements.txt, can\u0027t we expect it to be present?","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"440235de855e914ec48da1d74475f4a3abe1035d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import traceback"},{"line_number":30,"context_line":"import threading"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"prometheus_client \u003d extras.try_import(\u0027prometheus_client\u0027)"},{"line_number":33,"context_line":"yappi \u003d extras.try_import(\u0027yappi\u0027)"},{"line_number":34,"context_line":"objgraph \u003d extras.try_import(\u0027objgraph\u0027)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ba7d30e8","line":32,"in_reply_to":"3f79a3b5_bac69b15","updated":"2018-09-06 02:56:28.000000000","message":"It\u0027s for consistency with statsd where the documentation says that zuul can start without statsd. I agree it\u0027s not needed since you get it automatically with pip.","commit_id":"419a8fdfb2750fb48dd33e6355ba5eac86ee1875"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e45256fcb5ddcdbf71ed0325f9b2a79ca05e6598","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                raise RuntimeError(\"prometheus_client library is missing.\")"},{"line_number":207,"context_line":"            port \u003d int(self.config.get(section, \u0027prometheus_port\u0027))"},{"line_number":208,"context_line":"            addr \u003d get_default("},{"line_number":209,"context_line":"                self.config, section, \u0027prometheus_addr\u0027, \u00270.0.0.0\u0027)"},{"line_number":210,"context_line":"            prometheus_client.start_http_server(port, addr)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def main(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"f45fc407_af63b2df","line":209,"updated":"2021-04-26 13:31:02.000000000","message":"Should this be \"::\" ?","commit_id":"5f66a6d3a6dbd85546277986eee6ed27c038bf53"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"b2fb913f771a4b0c78bd7225d684bb22cd12741b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                raise RuntimeError(\"prometheus_client library is missing.\")"},{"line_number":207,"context_line":"            port \u003d int(self.config.get(section, \u0027prometheus_port\u0027))"},{"line_number":208,"context_line":"            addr \u003d get_default("},{"line_number":209,"context_line":"                self.config, section, \u0027prometheus_addr\u0027, \u00270.0.0.0\u0027)"},{"line_number":210,"context_line":"            prometheus_client.start_http_server(port, addr)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def main(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"88ccf09e_9b823303","line":209,"in_reply_to":"f45fc407_af63b2df","updated":"2021-04-26 14:34:09.000000000","message":"that seems to raise an error, i fixed the example to use 0.0.0.0","commit_id":"5f66a6d3a6dbd85546277986eee6ed27c038bf53"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"08537192a40875cf98adfbd887596eaaa13e0c67","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                raise RuntimeError(\"prometheus_client library is missing.\")"},{"line_number":207,"context_line":"            port \u003d int(self.config.get(section, \u0027prometheus_port\u0027))"},{"line_number":208,"context_line":"            addr \u003d get_default("},{"line_number":209,"context_line":"                self.config, section, \u0027prometheus_addr\u0027, \u00270.0.0.0\u0027)"},{"line_number":210,"context_line":"            prometheus_client.start_http_server(port, addr)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def main(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"d9394301_4eac8787","line":209,"updated":"2021-04-26 14:40:21.000000000","message":"If I\u0027m reading https://github.com/prometheus/client_python/issues/132 correctly, It looks like we can switch this to \"::\" once our minimum python is 3.8.0?\n\nMaybe it\u0027s worth a comment with a link to that so we know why we\u0027re defaulting to v4 only?","commit_id":"9d2be1b2752157b0cbbb138b780657fefa71b843"}]}