)]}'
{"zuul/cmd/runner.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"af73e307bc0e29542a60f5b4bdb16527794ab161","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        projects \u003d set()"},{"line_number":291,"context_line":"        if not self.args.depends_on:"},{"line_number":292,"context_line":"            self.args.depends_on \u003d []"},{"line_number":293,"context_line":"        for depends_on in self.args.depends_on:"},{"line_number":294,"context_line":"            url \u003d urllib.parse.urlparse(depends_on)"},{"line_number":295,"context_line":"            source \u003d self.connections.getSourceByHostname(url.hostname)"},{"line_number":296,"context_line":"            if not source:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_54ea8c73","line":293,"range":{"start_line":293,"start_character":36,"end_line":293,"end_character":46},"updated":"2019-02-18 05:10:49.000000000","message":"This looks like duplicated code. Is this elsewhere, and if so, can we put it in a lib?","commit_id":"a06d99b6c28270606dc8314170b3069e0c639c9b"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"25b20c5a42d4f758af37b02c2a4990ac55dc6e94","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        projects \u003d set()"},{"line_number":291,"context_line":"        if not self.args.depends_on:"},{"line_number":292,"context_line":"            self.args.depends_on \u003d []"},{"line_number":293,"context_line":"        for depends_on in self.args.depends_on:"},{"line_number":294,"context_line":"            url \u003d urllib.parse.urlparse(depends_on)"},{"line_number":295,"context_line":"            source \u003d self.connections.getSourceByHostname(url.hostname)"},{"line_number":296,"context_line":"            if not source:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_bf9b9170","line":293,"range":{"start_line":293,"start_character":36,"end_line":293,"end_character":46},"in_reply_to":"9fdfeff1_54ea8c73","updated":"2019-02-18 06:41:05.000000000","message":"The code comes from the base manager, but the logic requires access to the full tenant configuration. As noted bellow, perhaps we should give the depends-on list to the freeze_job handler so that it can prepare the required \u0027projects\u0027 and \u0027items\u0027 list.","commit_id":"a06d99b6c28270606dc8314170b3069e0c639c9b"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"85e7e9140e37444f368c07cf40e61e8ffde0bf86","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        projects \u003d set()"},{"line_number":291,"context_line":"        if not self.args.depends_on:"},{"line_number":292,"context_line":"            self.args.depends_on \u003d []"},{"line_number":293,"context_line":"        for depends_on in self.args.depends_on:"},{"line_number":294,"context_line":"            url \u003d urllib.parse.urlparse(depends_on)"},{"line_number":295,"context_line":"            source \u003d self.connections.getSourceByHostname(url.hostname)"},{"line_number":296,"context_line":"            if not source:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_78ee3e8c","line":293,"range":{"start_line":293,"start_character":36,"end_line":293,"end_character":46},"in_reply_to":"9fdfeff1_a561e3aa","updated":"2019-02-22 04:19:37.000000000","message":"Sure, so how about we use the PUT verb with a list of depends-on string as the json body? Server side, if the verb is GET, then we assume no depends-on, and if the verb is PUT, then we load the depends-on list, pass it to gearman and let the scheduler prepare the appropriate \u0027projects\u0027 and \u0027items\u0027 properties of the job_params.\n\nI can look into that implementing that next week.","commit_id":"a06d99b6c28270606dc8314170b3069e0c639c9b"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"4933a10afa719c2ecccb6f6e5f2d47ba15b8b9d9","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        projects \u003d set()"},{"line_number":291,"context_line":"        if not self.args.depends_on:"},{"line_number":292,"context_line":"            self.args.depends_on \u003d []"},{"line_number":293,"context_line":"        for depends_on in self.args.depends_on:"},{"line_number":294,"context_line":"            url \u003d urllib.parse.urlparse(depends_on)"},{"line_number":295,"context_line":"            source \u003d self.connections.getSourceByHostname(url.hostname)"},{"line_number":296,"context_line":"            if not source:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_a561e3aa","line":293,"range":{"start_line":293,"start_character":36,"end_line":293,"end_character":46},"in_reply_to":"9fdfeff1_bf9b9170","updated":"2019-02-22 02:22:03.000000000","message":"That actually makes a lot more sense to me if you\u0027re happy with that direction?","commit_id":"a06d99b6c28270606dc8314170b3069e0c639c9b"}]}