)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2de53e9eeae23fce1dfb88086628bd560a19f0bd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"to use this accordingly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I16173a73dbfb79dc2c2b05c2002ac41e20a48225"},{"line_number":16,"context_line":"Depends-On: https://review.openstack.org/635584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_33fb007b","line":16,"updated":"2020-02-21 14:04:10.000000000","message":"If you wind up revising the change again, this Depends-On line has the old domain name so is ignored by Zuul, but it has also merged so can simply be removed.","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"dc5cfa46f3da67981f35853f6ccfbd6fdd059d62","unresolved":false,"context_lines":[{"line_number":13,"context_line":"to use this accordingly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I16173a73dbfb79dc2c2b05c2002ac41e20a48225"},{"line_number":16,"context_line":"Depends-On: https://review.openstack.org/635584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_b98107a4","line":16,"in_reply_to":"3fa7e38b_33fb007b","updated":"2020-02-22 17:04:00.000000000","message":"Done","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"}],"zuul/cmd/__init__.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"70d45558d9e36b09f90f19d5997d4c31c98b0a7d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if hasattr(self.args, \u0027nodaemon\u0027) and self.args.nodaemon:"},{"line_number":154,"context_line":"                logging_config \u003d logconfig.ServerLoggingConfig()"},{"line_number":155,"context_line":"                if hasattr(self.args, \u0027debug\u0027) and self.args.debug:"},{"line_number":156,"context_line":"                    logging_config.setDebug()"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                # Setting a server value updates the defaults to use"},{"line_number":159,"context_line":"                # WatchedFileHandler on /var/log/zuul/{server}-debug.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_352d45fd","line":156,"updated":"2019-08-26 15:29:41.000000000","message":"How about we move the setDebug line outside of this conditional, so that it can be set for foreground or background use?","commit_id":"393efbb832066c3a4031b26ab685e3c8089ef95a"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"fa0b9d7b2085fb698ac89625eadbc56970b0ad51","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if hasattr(self.args, \u0027nodaemon\u0027) and self.args.nodaemon:"},{"line_number":154,"context_line":"                logging_config \u003d logconfig.ServerLoggingConfig()"},{"line_number":155,"context_line":"                if hasattr(self.args, \u0027debug\u0027) and self.args.debug:"},{"line_number":156,"context_line":"                    logging_config.setDebug()"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                # Setting a server value updates the defaults to use"},{"line_number":159,"context_line":"                # WatchedFileHandler on /var/log/zuul/{server}-debug.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_3301dd05","line":156,"updated":"2019-08-26 16:36:55.000000000","message":"If it\u0027s set in the background daemon case, then the idea is for it to include DEBUG level logs in the log file managed by the logging module, right?","commit_id":"393efbb832066c3a4031b26ab685e3c8089ef95a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"843920fceefc8aa8677ecf34ef8a61da6a0a22c1","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if hasattr(self.args, \u0027nodaemon\u0027) and self.args.nodaemon:"},{"line_number":154,"context_line":"                logging_config \u003d logconfig.ServerLoggingConfig()"},{"line_number":155,"context_line":"                if hasattr(self.args, \u0027debug\u0027) and self.args.debug:"},{"line_number":156,"context_line":"                    logging_config.setDebug()"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                # Setting a server value updates the defaults to use"},{"line_number":159,"context_line":"                # WatchedFileHandler on /var/log/zuul/{server}-debug.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_731515e5","line":156,"in_reply_to":"7faddb67_3301dd05","updated":"2019-08-26 16:54:31.000000000","message":"Yup, corvus clarified this on #zuul.\n\nBasically change the log level regardless of where it is emitted to (and by default backgrounded process emits to log file).","commit_id":"393efbb832066c3a4031b26ab685e3c8089ef95a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d339aa74b9b1f83607c444f9c1f7ec22538fa4fd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if hasattr(self.args, \u0027nodaemon\u0027) and self.args.nodaemon:"},{"line_number":154,"context_line":"                logging_config \u003d logconfig.ServerLoggingConfig()"},{"line_number":155,"context_line":"                if hasattr(self.args, \u0027debug\u0027) and self.args.debug:"},{"line_number":156,"context_line":"                    logging_config.setDebug()"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                # Setting a server value updates the defaults to use"},{"line_number":159,"context_line":"                # WatchedFileHandler on /var/log/zuul/{server}-debug.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_b5661555","line":156,"in_reply_to":"7faddb67_352d45fd","updated":"2019-08-26 15:33:42.000000000","message":"It won\u0027t hurt to apply it to both but I\u0027m not sure it will be useful in the background case as daemonization will close the stdout file descriptor.","commit_id":"393efbb832066c3a4031b26ab685e3c8089ef95a"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"db77feb227581035413d49f75c6e45ebe88daf1a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if hasattr(self.args, \u0027nodaemon\u0027) and self.args.nodaemon:"},{"line_number":154,"context_line":"                logging_config \u003d logconfig.ServerLoggingConfig()"},{"line_number":155,"context_line":"                if hasattr(self.args, \u0027debug\u0027) and self.args.debug:"},{"line_number":156,"context_line":"                    logging_config.setDebug()"},{"line_number":157,"context_line":"            else:"},{"line_number":158,"context_line":"                # Setting a server value updates the defaults to use"},{"line_number":159,"context_line":"                # WatchedFileHandler on /var/log/zuul/{server}-debug.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_dddafa1a","line":156,"in_reply_to":"7faddb67_731515e5","updated":"2020-01-31 10:28:35.000000000","message":"Done","commit_id":"393efbb832066c3a4031b26ab685e3c8089ef95a"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"ae9a745864de9c387d82685013321cead760ed9c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def createParser(self):"},{"line_number":175,"context_line":"        parser \u003d super(ZuulDaemonApp, self).createParser()"},{"line_number":176,"context_line":"        parser.add_argument(\u0027-d\u0027, dest\u003d\u0027debug\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":177,"context_line":"                            help\u003d\u0027do not run as a daemon with debug log\u0027)"},{"line_number":178,"context_line":"        parser.add_argument(\u0027-f\u0027, dest\u003d\u0027foreground\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":179,"context_line":"                            help\u003d\u0027do not run as a daemon with info log\u0027)"},{"line_number":180,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_33e220d5","line":177,"updated":"2020-02-21 14:03:07.000000000","message":"This has a misplaced modifier, read by me (and I expect many) as \"do not (run as a daemon with debug log)\" rather than \"(do not run as a daemon) [and] (with debug log)\" so could confuse users. Maybe rewording to this would help: \"run in foreground with debug log\"","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"dc5cfa46f3da67981f35853f6ccfbd6fdd059d62","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def createParser(self):"},{"line_number":175,"context_line":"        parser \u003d super(ZuulDaemonApp, self).createParser()"},{"line_number":176,"context_line":"        parser.add_argument(\u0027-d\u0027, dest\u003d\u0027debug\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":177,"context_line":"                            help\u003d\u0027do not run as a daemon with debug log\u0027)"},{"line_number":178,"context_line":"        parser.add_argument(\u0027-f\u0027, dest\u003d\u0027foreground\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":179,"context_line":"                            help\u003d\u0027do not run as a daemon with info log\u0027)"},{"line_number":180,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_f9977fe9","line":177,"in_reply_to":"3fa7e38b_33e220d5","updated":"2020-02-22 17:04:00.000000000","message":"Done","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"ae9a745864de9c387d82685013321cead760ed9c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parser.add_argument(\u0027-d\u0027, dest\u003d\u0027debug\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":177,"context_line":"                            help\u003d\u0027do not run as a daemon with debug log\u0027)"},{"line_number":178,"context_line":"        parser.add_argument(\u0027-f\u0027, dest\u003d\u0027foreground\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":179,"context_line":"                            help\u003d\u0027do not run as a daemon with info log\u0027)"},{"line_number":180,"context_line":"        return parser"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def getPidFile(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_d3c86c4f","line":179,"updated":"2020-02-21 14:03:07.000000000","message":"I have a similar concern here to the one noted in the -d option above.","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"dc5cfa46f3da67981f35853f6ccfbd6fdd059d62","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parser.add_argument(\u0027-d\u0027, dest\u003d\u0027debug\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":177,"context_line":"                            help\u003d\u0027do not run as a daemon with debug log\u0027)"},{"line_number":178,"context_line":"        parser.add_argument(\u0027-f\u0027, dest\u003d\u0027foreground\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":179,"context_line":"                            help\u003d\u0027do not run as a daemon with info log\u0027)"},{"line_number":180,"context_line":"        return parser"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def getPidFile(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_199b7b16","line":179,"in_reply_to":"3fa7e38b_d3c86c4f","updated":"2020-02-22 17:04:00.000000000","message":"Done","commit_id":"cd70f1f2cbd9ee788179ab94a773d1234d5ecdb4"}]}