)]}'
{"zuul/executor/common.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"6edbbfeeb2f7dbd3f02e2a837276561997c6f61c","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            self.log.exception(\"Unable to load result data:\")"},{"line_number":589,"context_line":"        return data"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    def mapLines(self, merger, args, data, commit, warnings):"},{"line_number":592,"context_line":"        # The data and warnings arguments are mutated in this method."},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        # If we received file comments, map the line numbers before"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5f294487","side":"PARENT","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":16},"updated":"2019-03-29 08:47:21.000000000","message":"Shouldn\u0027t this be undone in the \"Separate out executor server from runner\" patch?","commit_id":"56c0f24c87949f5a7e4436b9e9bd6d122bbcd477"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"0a514d5ceb3ca9553a47c530bf5a647825e8cb4c","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            self.log.exception(\"Unable to load result data:\")"},{"line_number":589,"context_line":"        return data"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    def mapLines(self, merger, args, data, commit, warnings):"},{"line_number":592,"context_line":"        # The data and warnings arguments are mutated in this method."},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        # If we received file comments, map the line numbers before"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5f4e246f","side":"PARENT","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":16},"in_reply_to":"5fc1f717_5f294487","updated":"2019-03-29 08:49:04.000000000","message":"Yes, but because it was already copied over I left it for now to make reviewing between diffs easier (in theory). If people want it moved back we can.","commit_id":"56c0f24c87949f5a7e4436b9e9bd6d122bbcd477"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"72dae5a2efc993fcbb545a3eca40e83377171b96","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    @abc.abstractmethod"},{"line_number":580,"context_line":"    def stop(self):"},{"line_number":581,"context_line":"        \"\"\"Stop (and abort) the job execution\"\"\""},{"line_number":582,"context_line":"        pass"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"class AnsibleJob(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_2d872e64","line":582,"updated":"2019-04-02 20:59:03.000000000","message":"Honestly, everything in this class just seems like something that should be (and is!) on the AnsibleJob classs.  The extra layer is more typing and more confusion when trying to follow the code.","commit_id":"e55e0cd96e54e292a39f0d49023ae5c41d7a1299"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"efe8f9e002abae415cc8137e2d3974e2035f6b7f","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    @abc.abstractmethod"},{"line_number":580,"context_line":"    def stop(self):"},{"line_number":581,"context_line":"        \"\"\"Stop (and abort) the job execution\"\"\""},{"line_number":582,"context_line":"        pass"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"class AnsibleJob(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_e379a8fb","line":582,"in_reply_to":"5fc1f717_2d872e64","updated":"2019-04-10 03:14:18.000000000","message":"So in the case of the executor server we need to do some gearman commands in these steps. Thus they can\u0027t be in a general AnsibleJob class. These could be abstract methods on the AnsibleJob though that the ExecutorAnsibleJob would then inherit from and implement.\n\nThat would be a similar outcome, but given the previous feedback I was looking to avoid it. However, the implementation due to complexities ended up coming back to a base class-like structure as I worked through the refactor.","commit_id":"e55e0cd96e54e292a39f0d49023ae5c41d7a1299"}]}