)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"bda3c60ff1e832fdae5cf1f51286eeffd091c1b8","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        data \u003d self.getResultData()"},{"line_number":965,"context_line":"        warnings \u003d []"},{"line_number":966,"context_line":"        self.mapLines(merger, args, data, item_commit, warnings)"},{"line_number":967,"context_line":"        warnings.extend(data.get(\u0027zuul\u0027, {}).get(\u0027warnings\u0027, []))"},{"line_number":968,"context_line":"        result_data \u003d json.dumps(dict(result\u003dresult,"},{"line_number":969,"context_line":"                                      warnings\u003dwarnings,"},{"line_number":970,"context_line":"                                      data\u003ddata))"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_07165256","line":967,"updated":"2019-05-15 08:37:29.000000000","message":"I think we need to validate these data before we use it.  See how we handle the artifact returns (we have a helper function to get the data and it uses voluptuous to verify the format and either return the real data or a null placeholder).  In this case I think our helper method should return either the real data or the empty list.\n\nThat will protect us if someone does:\nzuul_return:\n  data:\n    zuul:\n      warnings: [[1], [2]]","commit_id":"3c7b9bc7d8b5c6bf7d5039cee9a8b0d1200c3eb4"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"a086361e9e10bcc956935aa96ea3922da10c0e8e","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        data \u003d self.getResultData()"},{"line_number":965,"context_line":"        warnings \u003d []"},{"line_number":966,"context_line":"        self.mapLines(merger, args, data, item_commit, warnings)"},{"line_number":967,"context_line":"        warnings.extend(data.get(\u0027zuul\u0027, {}).get(\u0027warnings\u0027, []))"},{"line_number":968,"context_line":"        result_data \u003d json.dumps(dict(result\u003dresult,"},{"line_number":969,"context_line":"                                      warnings\u003dwarnings,"},{"line_number":970,"context_line":"                                      data\u003ddata))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c5f06d00","line":967,"in_reply_to":"dfbec78f_07165256","updated":"2019-09-24 13:39:29.000000000","message":"Done","commit_id":"3c7b9bc7d8b5c6bf7d5039cee9a8b0d1200c3eb4"}]}