)]}'
{"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"bb449448740eb439df1181035672a28c51034975","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"                break"},{"line_number":1251,"context_line":"            except github3.exceptions.GitHubException:"},{"line_number":1252,"context_line":"                self.log.warning("},{"line_number":1253,"context_line":"                    \"Failed to get reviews for PR %s#%s; retrying\" %"},{"line_number":1254,"context_line":"                    (project, number))"},{"line_number":1255,"context_line":"            time.sleep(1)"},{"line_number":1256,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_4e3ed58c","line":1253,"range":{"start_line":1253,"start_character":67,"end_line":1253,"end_character":68},"updated":"2019-04-28 23:51:01.000000000","message":"logger automatically format the string when needed, the \u0027% (...)\u0027 could be replaced by a \u0027,\u0027.","commit_id":"ec0a42a2a88ea42846cf34721883c94e302b672e"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"bb449448740eb439df1181035672a28c51034975","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"                    \"Failed to get reviews for PR %s#%s; retrying\" %"},{"line_number":1254,"context_line":"                    (project, number))"},{"line_number":1255,"context_line":"            time.sleep(1)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"        permissions \u003d {}"},{"line_number":1258,"context_line":"        reviews \u003d {}"},{"line_number":1259,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_8eba8d07","line":1256,"updated":"2019-04-28 23:51:01.000000000","message":"Shouldn\u0027t an exception be raised when retry \u003d\u003d 4?","commit_id":"ec0a42a2a88ea42846cf34721883c94e302b672e"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"8d7e70fc7449fbc6b8f795d8b74a291a6951bc8d","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"                    \"Failed to get reviews for PR %s#%s; retrying\" %"},{"line_number":1254,"context_line":"                    (project, number))"},{"line_number":1255,"context_line":"            time.sleep(1)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"        permissions \u003d {}"},{"line_number":1258,"context_line":"        reviews \u003d {}"},{"line_number":1259,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_a0956ce6","line":1256,"updated":"2019-05-07 17:02:30.000000000","message":"Yes, that\u0027s a bug. revs will be undefined if we retry all 5 times. This is the use case for the `for/else` construct in python: http://book.pythontips.com/en/latest/for_-_else.html. Also, this is such a weird thing to guard for, it probably deserves a test, and maybe a reference to a github bug report (if there are such things as public github bug reports.. I think there might not be)","commit_id":"ec0a42a2a88ea42846cf34721883c94e302b672e"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"cafd6a7fe4296bd96117ce5932a3616629b0baee","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"                    (project, number))"},{"line_number":1255,"context_line":"            time.sleep(1)"},{"line_number":1256,"context_line":"        else:"},{"line_number":1257,"context_line":"            raise Exception(\u0027Pull reviews not found\u0027)"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"        permissions \u003d {}"},{"line_number":1260,"context_line":"        reviews \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_7750da33","line":1257,"updated":"2019-05-17 00:32:26.000000000","message":"Raising an exception here still doesn\u0027t help too much, as it is possible zuul won\u0027t enqueue PR properly.  I\u0027d have to see what harm there is if PullReviews is empty.","commit_id":"21eb38d0fa4c9b415144dbf4b6a6eadbdb0bed56"}]}