)]}'
{"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"89d9f231a30158c1dcdea23874a9da8ea3086845","unresolved":false,"context_lines":[{"line_number":75,"context_line":"class GithubRequestLogger:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, zuul_event_id):"},{"line_number":78,"context_line":"        log \u003d logging.getLogger(\"zuul.GithubRequest\")"},{"line_number":79,"context_line":"        self.log \u003d get_annotated_logger(log, zuul_event_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def log_request(self, response, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_070d1be7","line":78,"updated":"2019-05-27 07:00:24.000000000","message":"nit: shouldn\u0027t this be a class variable?","commit_id":"1cf104d55480b27ad8c7bc06d6593122f3100204"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"2c8be62476f6572863176beb3f86489d27d87b74","unresolved":false,"context_lines":[{"line_number":75,"context_line":"class GithubRequestLogger:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, zuul_event_id):"},{"line_number":78,"context_line":"        log \u003d logging.getLogger(\"zuul.GithubRequest\")"},{"line_number":79,"context_line":"        self.log \u003d get_annotated_logger(log, zuul_event_id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def log_request(self, response, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_e793275a","line":78,"in_reply_to":"bfb3d3c7_070d1be7","updated":"2019-05-27 07:10:14.000000000","message":"normally yes, but in this case it\u0027s more efficient to have self.log being already the annotated logger. This is also in other places the case where we have the logger for an entire instance.","commit_id":"1cf104d55480b27ad8c7bc06d6593122f3100204"}]}