)]}'
{"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"b7e953d108b3fed532b2202135c6e106e20171a1","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"        reviews \u003d {}"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        for rev in revs:"},{"line_number":1261,"context_line":"            if rev.get(\u0027commit_id\u0027) is None:"},{"line_number":1262,"context_line":"                # NOTE(pabelanger): It is possible the commit was force pushed"},{"line_number":1263,"context_line":"                # out of the branch, if so discard the review."},{"line_number":1264,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_7281e1c2","line":1261,"updated":"2019-05-31 06:50:10.000000000","message":"We currently don\u0027t remove reviews on older commits as well. Further Github blocks a PR also on old negative reviews and old positive reviews are only discarded if enabled in the branch protection.\n\nSo we should not just ignore this review but it needs to be handled correctly depending on the branch protection settings.","commit_id":"7b9627014b71af93b2c4c5ab2faaba8439a78771"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"397ce064077aad66f855f7dac782dd283e8dea19","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"        reviews \u003d {}"},{"line_number":1259,"context_line":""},{"line_number":1260,"context_line":"        for rev in revs:"},{"line_number":1261,"context_line":"            if rev.get(\u0027commit_id\u0027) is None:"},{"line_number":1262,"context_line":"                # NOTE(pabelanger): It is possible the commit was force pushed"},{"line_number":1263,"context_line":"                # out of the branch, if so discard the review."},{"line_number":1264,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_913010a1","line":1261,"in_reply_to":"bfb3d3c7_7281e1c2","updated":"2019-05-31 10:57:19.000000000","message":"given that we don\u0027t use commit_id any place that I can see, maybe we can not to anything. And remove this patch all together.","commit_id":"7b9627014b71af93b2c4c5ab2faaba8439a78771"}]}