)]}'
{"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"48f92fdb5fd2a5d9d20bd89963ae24730a99eef7","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            self._process_event()"},{"line_number":214,"context_line":"        finally:"},{"line_number":215,"context_line":"            self.log.debug(\"Finished event processing\")"},{"line_number":216,"context_line":"            return self"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _process_event(self):"},{"line_number":219,"context_line":"        if self.connector._stopped:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_2788dbc4","line":216,"updated":"2019-06-03 20:58:15.000000000","message":"Instead of returning self I think you can return self.event which will slightly simplify run_event_forwarder below.","commit_id":"5bb76ce4abffb4728befab87e0d7fb0a2a044104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"48f92fdb5fd2a5d9d20bd89963ae24730a99eef7","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return user"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"class GithubEventConnector:"},{"line_number":461,"context_line":"    \"\"\"Move events from GitHub into the scheduler\"\"\""},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    log \u003d logging.getLogger(\"zuul.GithubEventConnector\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_e72083fa","line":460,"range":{"start_line":460,"start_character":6,"end_line":460,"end_character":27},"updated":"2019-06-03 20:58:15.000000000","message":"Zuul is python3 only so we don\u0027t have to worry about new style vs old style classes. Maybe we should do a zuul wide cleanup of the (object) inheritance for consistency?","commit_id":"5bb76ce4abffb4728befab87e0d7fb0a2a044104"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"48f92fdb5fd2a5d9d20bd89963ae24730a99eef7","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                future \u003d self._event_forward_queue.get()"},{"line_number":510,"context_line":"                if future is None:"},{"line_number":511,"context_line":"                    return"},{"line_number":512,"context_line":"                processor \u003d future.result()"},{"line_number":513,"context_line":"                if processor.event:"},{"line_number":514,"context_line":"                    self.connection.logEvent(processor.event)"},{"line_number":515,"context_line":"                    self.connection.sched.addEvent(processor.event)"},{"line_number":516,"context_line":"            except Exception:"},{"line_number":517,"context_line":"                self.log.exception(\"Exception moving GitHub event:\")"},{"line_number":518,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_27b1bb90","line":515,"range":{"start_line":512,"start_character":16,"end_line":515,"end_character":67},"updated":"2019-06-03 20:58:15.000000000","message":"If you return event above and not self then you can simplify this block a bit.","commit_id":"5bb76ce4abffb4728befab87e0d7fb0a2a044104"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"be2f09ecccbd0837d384699a05fa0146a8941d28","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                # change again, but to be correct we should at least wait until"},{"line_number":954,"context_line":"                # the other thread is done updating the change."},{"line_number":955,"context_line":"                with lock:"},{"line_number":956,"context_line":"                    log \u003d get_annotated_logger(self.log, event)"},{"line_number":957,"context_line":"                    log.debug(\"Updating %s is currently being updated, \""},{"line_number":958,"context_line":"                              \"waiting for it to finish\", change)"},{"line_number":959,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e959c78d","line":956,"updated":"2019-06-10 14:40:28.000000000","message":"This run after the lock is acquired, so the log msg is a little inaccurate.  Maybe this log line should be before \"with lock\", and inside the lock we should say \"Finished updating change ...\"","commit_id":"9f0dae6ca2b2ed36d76f7201e71f451defc91329"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"e62f3cf3e8b3b310aaa9c90f796af8e0c0c973c0","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                # change again, but to be correct we should at least wait until"},{"line_number":954,"context_line":"                # the other thread is done updating the change."},{"line_number":955,"context_line":"                with lock:"},{"line_number":956,"context_line":"                    log \u003d get_annotated_logger(self.log, event)"},{"line_number":957,"context_line":"                    log.debug(\"Updating %s is currently being updated, \""},{"line_number":958,"context_line":"                              \"waiting for it to finish\", change)"},{"line_number":959,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_bdc46592","line":956,"in_reply_to":"9fb8cfa7_e959c78d","updated":"2019-06-10 16:48:54.000000000","message":"Done","commit_id":"9f0dae6ca2b2ed36d76f7201e71f451defc91329"}]}