)]}'
{"tests/unit/test_v3.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0adef4edfe768c3df1f6727c77d240cd86b7e03b","unresolved":false,"context_lines":[{"line_number":2685,"context_line":""},{"line_number":2686,"context_line":"    def test_plugins(self):"},{"line_number":2687,"context_line":"        # This test runs a bit long and needs extra time."},{"line_number":2688,"context_line":"        self.wait_timeout \u003d 180"},{"line_number":2689,"context_line":""},{"line_number":2690,"context_line":"        # Keep the jobdir around so we can inspect contents if an"},{"line_number":2691,"context_line":"        # assert fails."}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_fe5e5374","line":2688,"updated":"2019-06-10 19:11:21.000000000","message":"The unit test job for Python 3.6 timed out here under Ansible 2.8... does it need increasing, or is it an indication something\u0027s still wrong with the test changes?","commit_id":"c8f6b7b9b103d620cedea5d5049a9bb1a32fc4fc"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"236bb8b101898a454191d30bdc6ce1ea61eb061f","unresolved":false,"context_lines":[{"line_number":2718,"context_line":"        # inside the tmpdir. Because the playbooks are mounted read-only this"},{"line_number":2719,"context_line":"        # will not work within zuul\u0027s context."},{"line_number":2720,"context_line":"        if self.ansible_version in (\u00272.5\u0027, \u00272.6\u0027):"},{"line_number":2721,"context_line":"            plugin_tests.append((\u0027password_read_good\u0027, \u0027SUCCESS\u0027))"},{"line_number":2722,"context_line":""},{"line_number":2723,"context_line":"        for job_name, result in plugin_tests:"},{"line_number":2724,"context_line":"            count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_29391fa3","line":2721,"updated":"2019-06-10 14:17:48.000000000","message":"Interesting. Can we create a file under zuul.executor.work_root to read in to work around this? The point of password_read_good was just to make sure the password lookup is able to read from an existing file at a path we\u0027re already allowing.","commit_id":"c8f6b7b9b103d620cedea5d5049a9bb1a32fc4fc"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"f1d7469616ffe7648ccb3d36029db8b8c22dd88c","unresolved":false,"context_lines":[{"line_number":2718,"context_line":"        # inside the tmpdir. Because the playbooks are mounted read-only this"},{"line_number":2719,"context_line":"        # will not work within zuul\u0027s context."},{"line_number":2720,"context_line":"        if self.ansible_version in (\u00272.5\u0027, \u00272.6\u0027):"},{"line_number":2721,"context_line":"            plugin_tests.append((\u0027password_read_good\u0027, \u0027SUCCESS\u0027))"},{"line_number":2722,"context_line":""},{"line_number":2723,"context_line":"        for job_name, result in plugin_tests:"},{"line_number":2724,"context_line":"            count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_7e4a63ac","line":2721,"in_reply_to":"9fb8cfa7_29391fa3","updated":"2019-06-10 19:11:59.000000000","message":"I think that should work.","commit_id":"c8f6b7b9b103d620cedea5d5049a9bb1a32fc4fc"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"52864638a0c707aaae51b0a2050affe09e9957e6","unresolved":false,"context_lines":[{"line_number":2685,"context_line":""},{"line_number":2686,"context_line":"    def test_plugins(self):"},{"line_number":2687,"context_line":"        # This test runs a bit long and needs extra time."},{"line_number":2688,"context_line":"        self.wait_timeout \u003d 270"},{"line_number":2689,"context_line":""},{"line_number":2690,"context_line":"        # Keep the jobdir around so we can inspect contents if an"},{"line_number":2691,"context_line":"        # assert fails."}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_a5066251","line":2688,"updated":"2019-06-12 15:33:40.000000000","message":"Additional research indicates this is not the test timeout, and in fact is 10 seconds in excess of our default hard timeout (OS_TEST_TIMEOUT\u003d240 passed in envvar from tox + 20 with gentle\u003dFalse from the BaseTestCase.setUp() method).","commit_id":"90dab68c21f78b218837db4c4b600a08c5e3b792"}],"zuul/ansible/base/lookup/password.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0e3859bf2d0f9e81ec983391e3c8670ae7094db7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from zuul.ansible import paths"},{"line_number":18,"context_line":"ini \u003d paths._import_ansible_lookup_plugin(\"password\")"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LookupModule(password.LookupModule):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_29e66d46","line":18,"updated":"2019-06-03 23:31:51.000000000","message":"Oops, this variable should have been named \"password\" instead (copy-paste error).","commit_id":"a30e72ef56b6a82be98ccf6e6d4c5119f41fb244"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"35fcb691be5fc635d36a98dfef4d2c523c7861ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        for term in terms:"},{"line_number":25,"context_line":"            # term parsing taken from a loose reinterpretation of"},{"line_number":26,"context_line":"            # ansible.lib.ansible.plugins.lookup.password._parse_parameters(),"},{"line_number":27,"context_line":"            # with /dev/null whitelisted because it\u0027s interpreted specially"},{"line_number":28,"context_line":"            relpath \u003d term.split(\u0027 \u0027)[0]"},{"line_number":29,"context_line":"            if relpath !\u003d \"/dev/null\":"},{"line_number":30,"context_line":"                path \u003d self._loader.path_dwim(relpath)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_c8d2b400","line":27,"updated":"2019-06-10 22:04:24.000000000","message":"I think you could call \"password._parse_parameters(term)\" here if you wanted to, but this seems simple enough, if slightly more restrictive in usage.","commit_id":"2c870189ea1ea8c2a1b869993dc642ad32fc02f1"}]}