)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3f1d5e3d4a15c1835787fa93c2f5726f454dbd2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Marking the nodes as USED will allow nodepool to delete them."},{"line_number":10,"context_line":"If we are unsuccessful in marking any of the held nodes as used,"},{"line_number":11,"context_line":"we simply log the error and try again at some future point until"},{"line_number":12,"context_line":"all nodes are eventually marked, allowing the hold request to be"},{"line_number":13,"context_line":"deleted."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idd41c58b5cce0aa9b6cd186fa5c33066012790b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5faad753_0e144b43","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":58},"updated":"2019-09-13 18:37:12.000000000","message":"shouldn\u0027t this refer to node instead of request?","commit_id":"577b6f75df46eacaf185a4fdc111c143e7b486c4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"66e617ecd564d2e6ceabc54c311085a6dbf9ca18","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Marking the nodes as USED will allow nodepool to delete them."},{"line_number":10,"context_line":"If we are unsuccessful in marking any of the held nodes as used,"},{"line_number":11,"context_line":"we simply log the error and try again at some future point until"},{"line_number":12,"context_line":"all nodes are eventually marked, allowing the hold request to be"},{"line_number":13,"context_line":"deleted."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Idd41c58b5cce0aa9b6cd186fa5c33066012790b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_2418f27f","line":12,"range":{"start_line":12,"start_character":51,"end_line":12,"end_character":58},"in_reply_to":"5faad753_0e144b43","updated":"2019-09-16 15:08:05.000000000","message":"No, \u0027request\u0027 is correct. This is attempting to state that the request is not deleted until all nodes are deleted.","commit_id":"577b6f75df46eacaf185a4fdc111c143e7b486c4"}],"zuul/zk.py":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"a21d70a9e9f84af3f6aebeca44cc4a671359ef9e","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                try:"},{"line_number":618,"context_line":"                    self.unlockNode(node_obj)"},{"line_number":619,"context_line":"                except Exception:"},{"line_number":620,"context_line":"                    pass"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        return not failure"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_8ab9927a","line":620,"updated":"2019-08-23 14:36:31.000000000","message":"Shouldn\u0027t we at least log the exception here? I know that unlocking shouldn\u0027t fail, but if it does for some reason we have not trace in the logs.","commit_id":"699c938d5b66b71023e5cf38adebc5a07370c1af"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"100b113033e2f8b007fb0fc6fd48334a7c1a4589","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                try:"},{"line_number":618,"context_line":"                    self.unlockNode(node_obj)"},{"line_number":619,"context_line":"                except Exception:"},{"line_number":620,"context_line":"                    pass"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        return not failure"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_05d4b3e8","line":620,"in_reply_to":"7faddb67_8ab9927a","updated":"2019-08-23 15:13:11.000000000","message":"Been a while since I coded this now, but I think my intention was to avoid the noise of the unlock failing if the lock above was the reason for the exception. But I can think of a better way to handle that now.","commit_id":"699c938d5b66b71023e5cf38adebc5a07370c1af"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3f1d5e3d4a15c1835787fa93c2f5726f454dbd2d","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        failure \u003d False"},{"line_number":591,"context_line":"        for node_id in hold_request.nodes:"},{"line_number":592,"context_line":"            node \u003d self.getNode(node_id)"},{"line_number":593,"context_line":"            if not node:"},{"line_number":594,"context_line":"                continue"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            node[\u0027state\u0027] \u003d zuul.model.STATE_USED"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_330c1440","line":593,"updated":"2019-09-13 18:37:12.000000000","message":"couldn\u0027t this also check for node[\u0027state\u0027] \u003d\u003d \u0027used\u0027?","commit_id":"577b6f75df46eacaf185a4fdc111c143e7b486c4"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"66e617ecd564d2e6ceabc54c311085a6dbf9ca18","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        failure \u003d False"},{"line_number":591,"context_line":"        for node_id in hold_request.nodes:"},{"line_number":592,"context_line":"            node \u003d self.getNode(node_id)"},{"line_number":593,"context_line":"            if not node:"},{"line_number":594,"context_line":"                continue"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            node[\u0027state\u0027] \u003d zuul.model.STATE_USED"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_27747499","line":593,"in_reply_to":"5faad753_330c1440","updated":"2019-09-16 15:08:05.000000000","message":"Done","commit_id":"577b6f75df46eacaf185a4fdc111c143e7b486c4"}]}