)]}'
{"zuul/executor/server.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"c40da2532dad05793d07f0e559a7bc450e5b9058","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        os.makedirs(self.control_path)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        localhost_facts \u003d os.path.join(self.fact_cache, \u0027localhost\u0027)"},{"line_number":408,"context_line":"        jobtime \u003d datetime.datetime.now()"},{"line_number":409,"context_line":"        date_time_facts \u003d {}"},{"line_number":410,"context_line":"        date_time_facts[\u0027year\u0027] \u003d jobtime.strftime(\u0027%Y\u0027)"},{"line_number":411,"context_line":"        date_time_facts[\u0027month\u0027] \u003d jobtime.strftime(\u0027%m\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_5fa2864d","line":408,"updated":"2019-06-17 15:56:02.000000000","message":"I think we should use utcnow() (and probably include a tz/tz_offset to match), for 2 reasons:\n1) Without a tz or offset, it\u0027s hard for users to know how to use this time.\n2) Because we\u0027re actually giving the local time here, and below, we give the UTC time, users who know this can calculate the tz offset and get an approximate location of the server.  That doesn\u0027t bother me that much, but it does run counter to one of the stated goals.  At the very least, it does seem a good idea to make executors in different locations behave consistently, so UTC would be a good match here.","commit_id":"652b9ab534b9a31e88cf352aeedd2a0bd926b93c"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"0f48959b6636dc02133d69696fb3095091e8f2fa","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        os.makedirs(self.control_path)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        localhost_facts \u003d os.path.join(self.fact_cache, \u0027localhost\u0027)"},{"line_number":408,"context_line":"        jobtime \u003d datetime.datetime.now()"},{"line_number":409,"context_line":"        date_time_facts \u003d {}"},{"line_number":410,"context_line":"        date_time_facts[\u0027year\u0027] \u003d jobtime.strftime(\u0027%Y\u0027)"},{"line_number":411,"context_line":"        date_time_facts[\u0027month\u0027] \u003d jobtime.strftime(\u0027%m\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_829dfd0b","line":408,"in_reply_to":"9fb8cfa7_5fa2864d","updated":"2019-06-18 05:06:31.000000000","message":"Yep, good points, done.","commit_id":"652b9ab534b9a31e88cf352aeedd2a0bd926b93c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e328981c744f2ff824c58419d771b73f6fb3d390","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        os.makedirs(self.control_path)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        localhost_facts \u003d os.path.join(self.fact_cache, \u0027localhost\u0027)"},{"line_number":408,"context_line":"        jobtime \u003d datetime.datetime.utcnow()"},{"line_number":409,"context_line":"        date_time_facts \u003d {}"},{"line_number":410,"context_line":"        date_time_facts[\u0027year\u0027] \u003d jobtime.strftime(\u0027%Y\u0027)"},{"line_number":411,"context_line":"        date_time_facts[\u0027month\u0027] \u003d jobtime.strftime(\u0027%m\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_bb4b885d","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":44},"updated":"2019-06-18 08:05:49.000000000","message":"I took the behaviour of Ansible, now we are a little different.\n\nI believe it\u0027s fine to use UTC (in fact, I think it\u0027s better) and expose TZ offset as 0, but I want to raise the fact it\u0027s different.","commit_id":"ee1771e312e2ae857a85bf49edf1be9d86a3db57"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"f94f146c2c58dc7a854aa81a7627016d4c1dea41","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        os.makedirs(self.control_path)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        localhost_facts \u003d os.path.join(self.fact_cache, \u0027localhost\u0027)"},{"line_number":408,"context_line":"        jobtime \u003d datetime.datetime.utcnow()"},{"line_number":409,"context_line":"        date_time_facts \u003d {}"},{"line_number":410,"context_line":"        date_time_facts[\u0027year\u0027] \u003d jobtime.strftime(\u0027%Y\u0027)"},{"line_number":411,"context_line":"        date_time_facts[\u0027month\u0027] \u003d jobtime.strftime(\u0027%m\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_17506032","line":408,"updated":"2019-06-18 16:20:20.000000000","message":"Yes, but omitting the TZ was also different, right?  And, really, the only difference here is that we\u0027re forcing the host to be on UTC time whether it is or not.  If the host happened to be configured to keep its local time in UTC, the behavior would be the same.  So I think this is less different than the alternative.  :)","commit_id":"ee1771e312e2ae857a85bf49edf1be9d86a3db57"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f1f31633995ab51756875b076063d720c1b5c952","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        os.makedirs(self.control_path)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        localhost_facts \u003d os.path.join(self.fact_cache, \u0027localhost\u0027)"},{"line_number":408,"context_line":"        jobtime \u003d datetime.datetime.utcnow()"},{"line_number":409,"context_line":"        date_time_facts \u003d {}"},{"line_number":410,"context_line":"        date_time_facts[\u0027year\u0027] \u003d jobtime.strftime(\u0027%Y\u0027)"},{"line_number":411,"context_line":"        date_time_facts[\u0027month\u0027] \u003d jobtime.strftime(\u0027%m\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_b5a14298","line":408,"in_reply_to":"9fb8cfa7_17506032","updated":"2019-06-19 06:22:59.000000000","message":"Sorry for my poor wording, I was explaining my agreement, but storing that for the record :)\n\nIt seems we are all in agreement.","commit_id":"ee1771e312e2ae857a85bf49edf1be9d86a3db57"}]}