)]}'
{"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"67954069eb51b41890aaded4a7157c40bd8f79f6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        rate_limit \u003d response.headers.get(\u0027x-ratelimit-limit\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # There is no rate limit information we have nothing to do here."},{"line_number":161,"context_line":"        if rate_limit:"},{"line_number":162,"context_line":"            self._log_rate_limit(response)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # If we got a 403 we could potentially have hit the rate limit. For"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_42370ae5","line":161,"updated":"2019-06-17 20:35:59.000000000","message":"If the header is always there, I agree there isn\u0027t a problem, and this is just a confusing comment.  I suggest we remove it (because of how confusing it could be).","commit_id":"4dc090ce1cd0ec0d6bf10256055e041a3a4587c1"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9f4174969fd70308b3581029f84f30c54d3cca30","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        rate_limit \u003d response.headers.get(\u0027x-ratelimit-limit\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # There is no rate limit information we have nothing to do here."},{"line_number":161,"context_line":"        if rate_limit:"},{"line_number":162,"context_line":"            self._log_rate_limit(response)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # If we got a 403 we could potentially have hit the rate limit. For"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_bfc13de7","line":161,"updated":"2019-06-17 20:28:29.000000000","message":"The comment makes me wonder if this is complete?  Did you mean to return if there is not rate_limit header?  If there is a case where we get a 403 but no rate limit headers, I think we will hit an exception inside handle_rate_limit, right?","commit_id":"4dc090ce1cd0ec0d6bf10256055e041a3a4587c1"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"741858be75816c64bbdd5dd2536fdd73802662e1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        rate_limit \u003d response.headers.get(\u0027x-ratelimit-limit\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # There is no rate limit information we have nothing to do here."},{"line_number":161,"context_line":"        if rate_limit:"},{"line_number":162,"context_line":"            self._log_rate_limit(response)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # If we got a 403 we could potentially have hit the rate limit. For"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_9f18f984","line":161,"in_reply_to":"9fb8cfa7_bfc13de7","updated":"2019-06-17 20:33:04.000000000","message":"oops, this is just a comment leftover from a refactoring. The rate limit header only triggers rate limit logging. The handling itself is triggered by 403 combined with the according messages (in this case the needed header is always there).","commit_id":"4dc090ce1cd0ec0d6bf10256055e041a3a4587c1"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"9f4174969fd70308b3581029f84f30c54d3cca30","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        except Exception:"},{"line_number":181,"context_line":"            # If we cannot decode the response body, log it here and return so"},{"line_number":182,"context_line":"            # the caller can handle the response."},{"line_number":183,"context_line":"            self.log.exception(\u0027Couldn\\\u0027t json decode the response body.\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class GithubShaCache(object):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_5fb6018d","line":183,"updated":"2019-06-17 20:28:29.000000000","message":"Nit: really good time to use \"double quotes\". :)","commit_id":"4dc090ce1cd0ec0d6bf10256055e041a3a4587c1"}]}