)]}'
{"zuul/reporter/__init__.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e9cc5d9f8e4d383ee817ca47963511e648df3c6","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _formatItemReportStart(self, item, with_jobs\u003dTrue):"},{"line_number":129,"context_line":"        status_url \u003d get_default(self.connection.sched.config,"},{"line_number":130,"context_line":"                                 \u0027web\u0027, \u0027status_url\u0027, \u0027\u0027)"},{"line_number":131,"context_line":"        return item.pipeline.start_message.format(pipeline\u003ditem.pipeline,"},{"line_number":132,"context_line":"                                                  change\u003ditem.change,"},{"line_number":133,"context_line":"                                                  status_url\u003dstatus_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b79dd40b","line":130,"updated":"2019-06-18 16:15:53.000000000","message":"I think this is wrong -- we probably just missed it in v3.  We now expect status_url itself to be a format string.  So I think here we need to have:\n\n  if status_url: status_url \u003d item.formatUrlPattern(status_url)","commit_id":"e2312c0f65a345758b89f1a3457185267c3ffdd4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"0e9cc5d9f8e4d383ee817ca47963511e648df3c6","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        status_url \u003d get_default(self.connection.sched.config,"},{"line_number":130,"context_line":"                                 \u0027web\u0027, \u0027status_url\u0027, \u0027\u0027)"},{"line_number":131,"context_line":"        return item.pipeline.start_message.format(pipeline\u003ditem.pipeline,"},{"line_number":132,"context_line":"                                                  change\u003ditem.change,"},{"line_number":133,"context_line":"                                                  status_url\u003dstatus_url)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _formatItemReportSuccess(self, item, with_jobs\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d7a2c84b","line":132,"updated":"2019-06-18 16:15:53.000000000","message":"Let\u0027s use \"item.change.getSafeAttributes()\" here.  Same for pipeline too, while we\u0027re at it.","commit_id":"e2312c0f65a345758b89f1a3457185267c3ffdd4"}]}