)]}'
{"tests/unit/test_executor.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f8d236c8d7934bec2cc6dea3f419f9f8d3e11078","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        date_time \u003d \\"},{"line_number":734,"context_line":"            j[0][\u0027plays\u0027][0][\u0027tasks\u0027][0][\u0027hosts\u0027][\u0027localhost\u0027][\u0027ansible_date_time\u0027]"},{"line_number":735,"context_line":"        self.assertEqual(18, len(ansible_date_time))"},{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a4cfd255","line":736,"updated":"2019-06-19 11:28:18.000000000","message":"I think pep8 will complain about not having a space after the #","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cef94546a95d4fb4814995eda41ade2cb648661f","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        date_time \u003d \\"},{"line_number":734,"context_line":"            j[0][\u0027plays\u0027][0][\u0027tasks\u0027][0][\u0027hosts\u0027][\u0027localhost\u0027][\u0027ansible_date_time\u0027]"},{"line_number":735,"context_line":"        self.assertEqual(18, len(ansible_date_time))"},{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_84440eb9","line":736,"in_reply_to":"9fb8cfa7_a4cfd255","updated":"2019-06-19 11:34:08.000000000","message":"Done","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"f8d236c8d7934bec2cc6dea3f419f9f8d3e11078","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"},{"line_number":740,"context_line":"        self.assertEqual(self.getJobFromHistory(\u0027other-fact\u0027).result,"},{"line_number":741,"context_line":"                         \u0027SUCCESS\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_04eb3eb0","line":739,"range":{"start_line":739,"start_character":10,"end_line":739,"end_character":44},"updated":"2019-06-19 11:28:18.000000000","message":"(nit) It\u0027s a bit of duplication, but this could be a separate job to confirm the facts are indeed restricted. Alternatively, if there is a way in ansible to list all the facts we could check that it only has what we want.","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4c400a47925e037090bbcc8d407ac567c642de9a","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"},{"line_number":740,"context_line":"        self.assertEqual(self.getJobFromHistory(\u0027other-fact\u0027).result,"},{"line_number":741,"context_line":"                         \u0027SUCCESS\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_c4ad2632","line":739,"range":{"start_line":739,"start_character":10,"end_line":739,"end_character":44},"in_reply_to":"9fb8cfa7_04d57eb9","updated":"2019-06-19 11:42:09.000000000","message":"Ok got it. I thought that, due to the fact I would be testing something very close to standard, it would expose things so ensuring the rest is not exposed seemed the same topic.\nI can split in two patches. I will first check it passes to not loose precious infra testing time :)","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cef94546a95d4fb4814995eda41ade2cb648661f","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"},{"line_number":740,"context_line":"        self.assertEqual(self.getJobFromHistory(\u0027other-fact\u0027).result,"},{"line_number":741,"context_line":"                         \u0027SUCCESS\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e4814ac5","line":739,"range":{"start_line":739,"start_character":10,"end_line":739,"end_character":44},"in_reply_to":"9fb8cfa7_04eb3eb0","updated":"2019-06-19 11:34:08.000000000","message":"It is a separate \"job\".\nIt isn\u0027t a separate test. I thought using a setUp/teardown for this was too much and running those time the executor to waitUntilSettled was a waste of resoures.\nDid you mean a separate test?\n\nThere is a way to list all facts is to query for {{ ansible_facts }}. Did you want to register this, and evaluate its length? This is also something we can do.","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cf2bd7c6e0d82d55f6956048bbe35cd665e2613d","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        #This ensures we are exposing the right TZ offset, and not ansible one."},{"line_number":737,"context_line":"        self.assertEqual(\u0027+0000\u0027, ansible_date_time[\u0027tz_offset\u0027])"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        # Ensure other facts are not exposed"},{"line_number":740,"context_line":"        self.assertEqual(self.getJobFromHistory(\u0027other-fact\u0027).result,"},{"line_number":741,"context_line":"                         \u0027SUCCESS\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_04d57eb9","line":739,"range":{"start_line":739,"start_character":10,"end_line":739,"end_character":44},"in_reply_to":"9fb8cfa7_e4814ac5","updated":"2019-06-19 11:37:23.000000000","message":"Yes, I did mean \u0027test\u0027 sorry. And yes, the pre-work to run it requires a bit of repetition so it was more a nit/comment and I could go either way on it.\n\nIt would be neat to confirm that we aren\u0027t exposing other facts to affirm we are correctly restricting the executors. However that doesn\u0027t have to be done in this patch.","commit_id":"424dfbc789eae12a6fd25727358c939d29478740"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"60a56ffff6516ab7123d062282920d2447262fb8","unresolved":false,"context_lines":[{"line_number":734,"context_line":"            \u0027ansible_date_time\u0027"},{"line_number":735,"context_line":"        ]"},{"line_number":736,"context_line":"        self.assertEqual(18, len(date_time))"},{"line_number":737,"context_line":"        # This ensures we are exposing the right TZ offset, and not ansible one"},{"line_number":738,"context_line":"        self.assertEqual(\u0027+0000\u0027, date_time[\u0027tz_offset\u0027])"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Ensure other facts are not exposed"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_c3c0aee3","line":737,"updated":"2019-06-20 00:42:59.000000000","message":"(nit) well, I mean it\u0027s possible this test is running on a UTC+0 host","commit_id":"dd55cac45a19cdd65363d654878346fe11ab9729"}]}