)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"3dce0671e0aef0dc30ec081ace71cf249f76f9f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"executor: add merge_jobs options to disable gearman merge jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a zuul.conf option to disable the global merge"},{"line_number":10,"context_line":"jobs from running on an executor node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icd6374a6c97a404662b39de9df54f4b7c5ab36aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_36dd3241","line":10,"updated":"2019-08-27 20:23:55.000000000","message":"I\u0027m curious about the issue this solves for you? Do you have some sort of scaling issues without this?","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"852019492c43ff8e9ca1c7be2eae1e83061a3cfb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"executor: add merge_jobs options to disable gearman merge jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a zuul.conf option to disable the global merge"},{"line_number":10,"context_line":"jobs from running on an executor node."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icd6374a6c97a404662b39de9df54f4b7c5ab36aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_ec34744b","line":10,"in_reply_to":"7faddb67_36dd3241","updated":"2019-08-30 13:53:36.000000000","message":"We would like to run executor on remote slow network and we don\u0027t want them to perform global merge actions.","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"}],"doc/source/admin/components.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0c258c152a6d9e29728b0acf83252b7901c42aba","unresolved":false,"context_lines":[{"line_number":739,"context_line":"   .. attr:: merge_jobs"},{"line_number":740,"context_line":"      :default: True"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"      To disable global merge job, set it to false."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":".. attr:: merger"},{"line_number":745,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_4470e3a4","line":742,"updated":"2019-08-16 15:33:37.000000000","message":"We should probably add a bit more documentation around why this option can be toggled off and why for most cases leaving it on is preferable.","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"852019492c43ff8e9ca1c7be2eae1e83061a3cfb","unresolved":false,"context_lines":[{"line_number":739,"context_line":"   .. attr:: merge_jobs"},{"line_number":740,"context_line":"      :default: True"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"      To disable global merge job, set it to false."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":".. attr:: merger"},{"line_number":745,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_6c1964cf","line":742,"in_reply_to":"7faddb67_4470e3a4","updated":"2019-08-30 13:53:36.000000000","message":"Done","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"}],"etc/zuul.conf-sample":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0c258c152a6d9e29728b0acf83252b7901c42aba","unresolved":false,"context_lines":[{"line_number":33,"context_line":"default_username\u003dzuul"},{"line_number":34,"context_line":"trusted_ro_paths\u003d/opt/zuul-scripts:/var/cache"},{"line_number":35,"context_line":"trusted_rw_paths\u003d/opt/zuul-logs"},{"line_number":36,"context_line":"merge_jobs\u003dtrue"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[web]"},{"line_number":39,"context_line":"listen_address\u003d127.0.0.1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_a45e7710","line":36,"updated":"2019-08-16 15:33:37.000000000","message":"I would not mention this in the same since the default should be fine for most cases.","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"852019492c43ff8e9ca1c7be2eae1e83061a3cfb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"default_username\u003dzuul"},{"line_number":34,"context_line":"trusted_ro_paths\u003d/opt/zuul-scripts:/var/cache"},{"line_number":35,"context_line":"trusted_rw_paths\u003d/opt/zuul-logs"},{"line_number":36,"context_line":"merge_jobs\u003dtrue"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[web]"},{"line_number":39,"context_line":"listen_address\u003d127.0.0.1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_0c61d039","line":36,"in_reply_to":"7faddb67_a45e7710","updated":"2019-08-30 13:53:36.000000000","message":"Done","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"}],"zuul/executor/server.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0c258c152a6d9e29728b0acf83252b7901c42aba","unresolved":false,"context_lines":[{"line_number":2416,"context_line":"                self.ansible_manager.install()"},{"line_number":2417,"context_line":"        self.ansible_manager.copyAnsibleFiles()"},{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"        if get_default(self.config, \u0027executor\u0027, \u0027merge_jobs\u0027,"},{"line_number":2420,"context_line":"                       \"true\").lower() \u003d\u003d \"true\":"},{"line_number":2421,"context_line":"            self.merger_jobs \u003d {"},{"line_number":2422,"context_line":"                \u0027merger:merge\u0027: self.merge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_645f1fe5","line":2419,"updated":"2019-08-16 15:33:37.000000000","message":"get_default calls https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.getboolean if the default value is of boolean type. I think you should set the default to True instead of \"true\" and do that comparison instead.","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"852019492c43ff8e9ca1c7be2eae1e83061a3cfb","unresolved":false,"context_lines":[{"line_number":2416,"context_line":"                self.ansible_manager.install()"},{"line_number":2417,"context_line":"        self.ansible_manager.copyAnsibleFiles()"},{"line_number":2418,"context_line":""},{"line_number":2419,"context_line":"        if get_default(self.config, \u0027executor\u0027, \u0027merge_jobs\u0027,"},{"line_number":2420,"context_line":"                       \"true\").lower() \u003d\u003d \"true\":"},{"line_number":2421,"context_line":"            self.merger_jobs \u003d {"},{"line_number":2422,"context_line":"                \u0027merger:merge\u0027: self.merge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6cdc04e1","line":2419,"in_reply_to":"7faddb67_645f1fe5","updated":"2019-08-30 13:53:36.000000000","message":"Done","commit_id":"5c34fd1b2876431913213bdbf3696993a38bf397"}]}