)]}'
{"web/src/actions/build.js":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d52651768c8c976b3e5da66abccfd2d51baa96e6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  if (task.failed) {"},{"line_number":61,"context_line":"    return true"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"  if (\u0027failed_when_result\u0027 in task \u0026\u0026 !task.failed_when_result) {"},{"line_number":64,"context_line":"    return false"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":"  if (\u0027rc\u0027 in task \u0026\u0026 task.rc) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"7faddb67_48c5518d","line":63,"updated":"2019-08-16 23:28:37.000000000","message":"Here we check that failed_when_result is in task before accessing it and also we return false if !failed_when_result is true.\n\nBelow we don\u0027t check if it is set first and we return false when failed_when_result is true. Can we simplify this by replacing this condition with if failed_when_result in task\nor is there a bug in the condition below?","commit_id":"6d28b9634862e2c26e8d810668556fcb9a9d68cc"}]}