)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"6b470b7cc9bf1b168ebd626053716e238bd39cb9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"web: fix connections list github base_url"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The toDict() method of the github connection should use base_url instead"},{"line_number":10,"context_line":"of baseurl."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2fa7a2bfde781371816da533530beb81c188bc9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a9aa0717","line":10,"updated":"2019-08-29 09:32:45.000000000","message":"Why?  What is the difference?  What is this used for?","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"07754f95479d40f9a8f96c0c6a70c589aa604e27","unresolved":false,"context_lines":[{"line_number":7,"context_line":"web: fix connections list github base_url"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The toDict() method of the github connection should use base_url instead"},{"line_number":10,"context_line":"of baseurl."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2fa7a2bfde781371816da533530beb81c188bc9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_0cbb10e5","line":10,"in_reply_to":"7faddb67_a9aa0717","updated":"2019-08-30 13:36:11.000000000","message":"It\u0027s to prevent an AttributeError exception being through as\nbaseurl doesn\u0027t exists.","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"}],"zuul/driver/github/githubconnection.py":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d68d2baabff9c314c745ad2812d3e3bbf32b74fe","unresolved":false,"context_lines":[{"line_number":722,"context_line":"        if self.server \u003d\u003d \u0027github.com\u0027:"},{"line_number":723,"context_line":"            self.base_url \u003d GITHUB_BASE_URL"},{"line_number":724,"context_line":"        else:"},{"line_number":725,"context_line":"            self.base_url \u003d \u0027https://%s/api/v3\u0027 % self.server"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        # ssl verification must default to true"},{"line_number":728,"context_line":"        verify_ssl \u003d self.connection_config.get(\u0027verify_ssl\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f4fc560d","line":725,"updated":"2019-08-29 09:39:54.000000000","message":"Should we have a test case for this one as well?  I suggest this because it\u0027s a *very* different url than what is used for the public site.","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"07754f95479d40f9a8f96c0c6a70c589aa604e27","unresolved":false,"context_lines":[{"line_number":722,"context_line":"        if self.server \u003d\u003d \u0027github.com\u0027:"},{"line_number":723,"context_line":"            self.base_url \u003d GITHUB_BASE_URL"},{"line_number":724,"context_line":"        else:"},{"line_number":725,"context_line":"            self.base_url \u003d \u0027https://%s/api/v3\u0027 % self.server"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"        # ssl verification must default to true"},{"line_number":728,"context_line":"        verify_ssl \u003d self.connection_config.get(\u0027verify_ssl\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0ca0f0a4","line":725,"in_reply_to":"7faddb67_f4fc560d","updated":"2019-08-30 13:36:11.000000000","message":"I don\u0027t know what is the difference with the default GITHUB_BASE_URL... I assume the client can use both similarly.","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"388af6d036ef9eaf0a64e111515f1405d81aee97","unresolved":false,"context_lines":[{"line_number":771,"context_line":"    def toDict(self):"},{"line_number":772,"context_line":"        d \u003d super().toDict()"},{"line_number":773,"context_line":"        d.update({"},{"line_number":774,"context_line":"            \"baseurl\": self.base_url,"},{"line_number":775,"context_line":"            \"canonical_hostname\": self.canonical_hostname,"},{"line_number":776,"context_line":"            \"server\": self.server,"},{"line_number":777,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2c8a9a63","line":774,"range":{"start_line":774,"start_character":13,"end_line":774,"end_character":20},"updated":"2019-08-29 18:56:16.000000000","message":"Should we use the same underscore\u0027d name for this key as well? That may help avoid confusion in the future if the two map to each other.","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"07754f95479d40f9a8f96c0c6a70c589aa604e27","unresolved":false,"context_lines":[{"line_number":771,"context_line":"    def toDict(self):"},{"line_number":772,"context_line":"        d \u003d super().toDict()"},{"line_number":773,"context_line":"        d.update({"},{"line_number":774,"context_line":"            \"baseurl\": self.base_url,"},{"line_number":775,"context_line":"            \"canonical_hostname\": self.canonical_hostname,"},{"line_number":776,"context_line":"            \"server\": self.server,"},{"line_number":777,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4cc4a860","line":774,"range":{"start_line":774,"start_character":13,"end_line":774,"end_character":20},"in_reply_to":"7faddb67_2c8a9a63","updated":"2019-08-30 13:36:11.000000000","message":"It\u0027s because baseurl is consistent with the gerrit connection.","commit_id":"44b0abe3cca1b8b385002313fba6cbaf60a3d80a"}]}