)]}'
{"zuul/scheduler.py":[{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"80d6c641981569689aee6296ee2f3d2afc8db28f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        request.reason \u003d reason"},{"line_number":565,"context_line":"        request.max_count \u003d count"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if not node_hold_expiration:"},{"line_number":568,"context_line":"            node_hold_expiration \u003d get_default(self.config, \u0027scheduler\u0027,"},{"line_number":569,"context_line":"                                               \u0027max_hold_age\u0027, 0)"},{"line_number":570,"context_line":"        request.node_expiration \u003d node_hold_expiration"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e0f4ed5d","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":36},"updated":"2019-09-17 17:18:10.000000000","message":"If someone wants to set this to 0 (whatever the scheduler max_hold_age default is) shouldn\u0027t this be \"is not None\"? (And removing the default\u003d0 command line parser argument)","commit_id":"f0a3a83113f7ceae3ad572d738449c84ea6ed3c6"},{"author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"change_message_id":"92ec6a9c51a9a19090b2255d38ba3adce9e97d80","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        request.reason \u003d reason"},{"line_number":565,"context_line":"        request.max_count \u003d count"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if not node_hold_expiration:"},{"line_number":568,"context_line":"            node_hold_expiration \u003d get_default(self.config, \u0027scheduler\u0027,"},{"line_number":569,"context_line":"                                               \u0027max_hold_age\u0027, 0)"},{"line_number":570,"context_line":"        request.node_expiration \u003d node_hold_expiration"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_16ff0fab","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":36},"in_reply_to":"3fa7e38b_20fa0542","updated":"2019-09-17 19:11:50.000000000","message":"This brings up an interesting point on if we want user supplied values to override the scheduler default. The general consensus seems to be that we should have settings for both a default (when not supplied by the user) and a max value that cannot be overridden. I\u0027ll make those changes.","commit_id":"f0a3a83113f7ceae3ad572d738449c84ea6ed3c6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"4f5f971ac67b73d81f2c3ec2335125c06c18a739","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        request.reason \u003d reason"},{"line_number":565,"context_line":"        request.max_count \u003d count"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if not node_hold_expiration:"},{"line_number":568,"context_line":"            node_hold_expiration \u003d get_default(self.config, \u0027scheduler\u0027,"},{"line_number":569,"context_line":"                                               \u0027max_hold_age\u0027, 0)"},{"line_number":570,"context_line":"        request.node_expiration \u003d node_hold_expiration"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_20fa0542","line":567,"range":{"start_line":567,"start_character":8,"end_line":567,"end_character":36},"in_reply_to":"3fa7e38b_e0f4ed5d","updated":"2019-09-17 17:19:47.000000000","message":"Or rather \"if node_hold_expiration is None:\"","commit_id":"f0a3a83113f7ceae3ad572d738449c84ea6ed3c6"}]}