)]}'
{"zuul/cmd/client.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e9b24c98fa32a83ca418509774cb2d623290cc94","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0fe158fc","line":226,"updated":"2019-11-25 21:15:27.000000000","message":"I don\u0027t have the answer for this, but I think it would be good to update the help info here so that we better understand why triggers were included in the first place.\n\nThey don\u0027t seem to be used for anything (and don\u0027t end up in job inventories), but maybe there are plans to make use of this somehow? If there is no plan for using this info maybe help should include a deprecation notice and the flag will be removed. If there is a plan we can expand on that here and maybe not make it optional depending on the plan?","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":16068,"name":"Tobias Henkel","email":"tobias.henkel@bmw.de","username":"tobias.henkel"},"change_message_id":"013cb376c527ed5a23a91c8365e1a5923fcc2a3f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bccd6331","line":226,"in_reply_to":"","updated":"2019-12-04 18:57:13.000000000","message":"In the past there were already some discussions about making jobs aware of the trigger. All of them were rejected because zuul is meant to be a git driven system where it doesn\u0027t matter how a job was triggered. Judging from this design philosophy the trigger won\u0027t be used in future as well and if that changes the enqueue could hard code a \u0027manual\u0027 trigger inside zuul.\n\nNevertheless I think we should deprecate (and just ignore) the trigger argument.","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"38886c4c0204e4750472ce96895c8659f9fd7526","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_732eaa43","line":226,"in_reply_to":"3fa7e38b_0fe158fc","updated":"2019-11-26 14:11:37.000000000","message":"I don\u0027t know the exact history but I assume the idea was to mimic a real event, which always has a trigger by definition.  It turns out providing the project, pipeline \u0026 change info is enough for zuul to enqueue an event.\n\nShould we instead define a default \"manual\" or \"admin\" trigger that covers CLI/GUI events to be consistent with other triggers?","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6a708d936f8def72f5a2c9b3156df0a59ad4eb30","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ce3f3784","line":226,"in_reply_to":"3fa7e38b_6ec3aa3a","updated":"2019-12-05 16:08:02.000000000","message":"Given tobiash response I think we should update the help message to be something like:\n\n  help\u003d\"Deprecated and ignored. Kept only for backward compatbility.\"","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"c23423461a5dd0f9fc0de55a798ac114135f0f91","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6ec3aa3a","line":226,"in_reply_to":"3fa7e38b_bccd6331","updated":"2019-12-05 09:24:33.000000000","message":"Do I need to document that in the help message?","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"be4208132d8203f19992327cc3668b9a045b17ac","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        cmd_enqueue.add_argument(\u0027--tenant\u0027, help\u003d\u0027tenant name\u0027,"},{"line_number":224,"context_line":"                                 required\u003dTrue)"},{"line_number":225,"context_line":"        cmd_enqueue.add_argument(\u0027--trigger\u0027, help\u003d\u0027trigger name\u0027,"},{"line_number":226,"context_line":"                                 required\u003dFalse, default\u003dNone)"},{"line_number":227,"context_line":"        cmd_enqueue.add_argument(\u0027--pipeline\u0027, help\u003d\u0027pipeline name\u0027,"},{"line_number":228,"context_line":"                                 required\u003dTrue)"},{"line_number":229,"context_line":"        cmd_enqueue.add_argument(\u0027--project\u0027, help\u003d\u0027project name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ee5f9372","line":226,"in_reply_to":"3fa7e38b_ce3f3784","updated":"2019-12-05 16:44:08.000000000","message":"Done","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"}],"zuul/rpclistener.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6a708d936f8def72f5a2c9b3156df0a59ad4eb30","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            if pipeline:"},{"line_number":191,"context_line":"                event.forced_pipeline \u003d args[\u0027pipeline\u0027]"},{"line_number":192,"context_line":"                # check the trigger if provided"},{"line_number":193,"context_line":"                if args.get(\u0027trigger\u0027, None) is not None:"},{"line_number":194,"context_line":"                    for trigger in pipeline.triggers:"},{"line_number":195,"context_line":"                        if trigger.name \u003d\u003d args[\u0027trigger\u0027]:"},{"line_number":196,"context_line":"                            event.trigger_name \u003d args[\u0027trigger\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_0e630fb3","line":193,"updated":"2019-12-05 16:08:02.000000000","message":"Then we can remove this block entirely.","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"be4208132d8203f19992327cc3668b9a045b17ac","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            if pipeline:"},{"line_number":191,"context_line":"                event.forced_pipeline \u003d args[\u0027pipeline\u0027]"},{"line_number":192,"context_line":"                # check the trigger if provided"},{"line_number":193,"context_line":"                if args.get(\u0027trigger\u0027, None) is not None:"},{"line_number":194,"context_line":"                    for trigger in pipeline.triggers:"},{"line_number":195,"context_line":"                        if trigger.name \u003d\u003d args[\u0027trigger\u0027]:"},{"line_number":196,"context_line":"                            event.trigger_name \u003d args[\u0027trigger\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ceb6578a","line":193,"in_reply_to":"3fa7e38b_0e630fb3","updated":"2019-12-05 16:44:08.000000000","message":"Done","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"e9b24c98fa32a83ca418509774cb2d623290cc94","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    for trigger in pipeline.triggers:"},{"line_number":195,"context_line":"                        if trigger.name \u003d\u003d args[\u0027trigger\u0027]:"},{"line_number":196,"context_line":"                            event.trigger_name \u003d args[\u0027trigger\u0027]"},{"line_number":197,"context_line":"                            continue"},{"line_number":198,"context_line":"                    if not event.trigger_name:"},{"line_number":199,"context_line":"                        errors +\u003d \u0027Invalid trigger: %s\\n\u0027 % (args[\u0027trigger\u0027],)"},{"line_number":200,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cf6340aa","line":197,"range":{"start_line":197,"start_character":28,"end_line":197,"end_character":36},"updated":"2019-11-25 21:15:27.000000000","message":"Can this be a break? (not a -1 as it was previously a continue).","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"38886c4c0204e4750472ce96895c8659f9fd7526","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                    for trigger in pipeline.triggers:"},{"line_number":195,"context_line":"                        if trigger.name \u003d\u003d args[\u0027trigger\u0027]:"},{"line_number":196,"context_line":"                            event.trigger_name \u003d args[\u0027trigger\u0027]"},{"line_number":197,"context_line":"                            continue"},{"line_number":198,"context_line":"                    if not event.trigger_name:"},{"line_number":199,"context_line":"                        errors +\u003d \u0027Invalid trigger: %s\\n\u0027 % (args[\u0027trigger\u0027],)"},{"line_number":200,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_33283232","line":197,"range":{"start_line":197,"start_character":28,"end_line":197,"end_character":36},"in_reply_to":"3fa7e38b_cf6340aa","updated":"2019-11-26 14:11:37.000000000","message":"Done","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"}],"zuul/web/__init__.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6a708d936f8def72f5a2c9b3156df0a59ad4eb30","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        body \u003d cherrypy.request.json"},{"line_number":313,"context_line":"        if \u0027trigger\u0027 not in body:"},{"line_number":314,"context_line":"            body[\u0027trigger\u0027] \u003d None"},{"line_number":315,"context_line":"        if all(p in body for p in [\u0027change\u0027, \u0027pipeline\u0027]):"},{"line_number":316,"context_line":"            return self._enqueue(tenant, project, **body)"},{"line_number":317,"context_line":"        elif all(p in body for p in [\u0027ref\u0027, \u0027oldrev\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ae53dbdd","line":314,"updated":"2019-12-05 16:08:02.000000000","message":"And this block.","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"},{"author":{"_account_id":7186,"name":"Matthieu Huin","email":"mhuin@redhat.com","username":"mhu"},"change_message_id":"be4208132d8203f19992327cc3668b9a045b17ac","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        body \u003d cherrypy.request.json"},{"line_number":313,"context_line":"        if \u0027trigger\u0027 not in body:"},{"line_number":314,"context_line":"            body[\u0027trigger\u0027] \u003d None"},{"line_number":315,"context_line":"        if all(p in body for p in [\u0027change\u0027, \u0027pipeline\u0027]):"},{"line_number":316,"context_line":"            return self._enqueue(tenant, project, **body)"},{"line_number":317,"context_line":"        elif all(p in body for p in [\u0027ref\u0027, \u0027oldrev\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6eaf232b","line":314,"in_reply_to":"3fa7e38b_ae53dbdd","updated":"2019-12-05 16:44:08.000000000","message":"Done","commit_id":"d1307ccf7a298758d5741d6e669aa46a118367d5"}]}